Merge pull request #10864 from Icinga/fix-http-message-sendfile-failbit-handling

Fix handling the `std::ifstream::failbit` in `OutgoingHttpMessage`

lib/remote/configfileshandler.cpp

@@ -81,9 +81,12 @@ bool ConfigFilesHandler::HandleRequest(
 		response.result(http::status::ok);
 		response.set(http::field::content_type, "application/octet-stream");
 		response.SendFile(path, yc);
-	} catch (const std::exception& ex) {
-		HttpUtility::SendJsonError(response, params, 500, "Could not read file.",
-			DiagnosticInformation(ex));
+	} catch (const std::ios_base::failure& ex) {
+		if (response.HasSerializationStarted()) {
+			throw;
+		}
+
+		HttpUtility::SendJsonError(response, params, 500, "Could not read file.", DiagnosticInformation(ex));
 	}
 
 	return true;

lib/remote/httpmessage.cpp

@@ -226,7 +226,7 @@ void OutgoingHttpMessage<isRequest, Body, StreamVariant>::SendFile(
 )
 {
 	std::ifstream fp(path.CStr(), std::ifstream::in | std::ifstream::binary | std::ifstream::ate);
-	fp.exceptions(std::ifstream::badbit | std::ifstream::eofbit);
+	fp.exceptions(std::ifstream::failbit | std::ifstream::badbit | std::ifstream::eofbit);
 
 	std::uint64_t remaining = fp.tellg();
 	fp.seekg(0);

lib/remote/httputility.cpp

@@ -86,6 +86,16 @@ void HttpUtility::SendJsonBody(HttpApiResponse& response, const Dictionary::Ptr&
 void HttpUtility::SendJsonError(HttpApiResponse& response,
 	const Dictionary::Ptr& params, int code, const String& info, const String& diagnosticInformation)
 {
+	if (response.HasSerializationStarted()) {
+		std::ostringstream err;
+		err << "Impossible to send error response after streaming has started: error: '" << code << "', status: '"
+			<< info << "'";
+		if (!diagnosticInformation.IsEmpty()) {
+			err << ", diagnostic_information: '" << diagnosticInformation << "'";
+		}
+		BOOST_THROW_EXCEPTION(std::logic_error{err.str()});
+	}
+
 	Dictionary::Ptr result = new Dictionary({ { "error", code } });
 
 	if (!info.IsEmpty()) {

test/remote-httpmessage.cpp

@@ -353,4 +353,19 @@ BOOST_AUTO_TEST_CASE(response_sendfile)
 	BOOST_REQUIRE_EQUAL(ss.str(), parser.get().body());
 }
 
+BOOST_AUTO_TEST_CASE(response_sendfile_invalid_path)
+{
+	auto future = SpawnSynchronizedCoroutine([this](boost::asio::yield_context yc) {
+		HttpApiResponse response(server);
+
+		response.result(http::status::ok);
+		BOOST_REQUIRE_THROW(response.SendFile("", yc), std::ios_base::failure);
+	});
+
+	auto status = future.wait_for(10s);
+	if (status != std::future_status::ready) {
+		BOOST_FAIL("Exception not thrown.");
+	}
+}
+
 BOOST_AUTO_TEST_SUITE_END()