helm/pkg/chart/loader
Matt Farina 512544b9ab
Fixing PAX Header handling (#8086)
* Fixing issue with PAX headers in plugin archive

PAX Headers can be added by some systems that create archives. Helm
should ignore them when extracting.

There are two PAX headers. One is global and the other is not. Both
are ignored. The test adds only the PAX global header because the
Go tar package is unable to write the header that is not global.

Closes #8084

Signed-off-by: Matt Farina <matt@mattfarina.com>

* Removing the PAX header test as it is not working

The PAX header test was making a WriteHeader call and ignoring the
error. When writing the type TypeXHeader it was causing an error
that was being silently ignored. The Go tar package cannot write
this type and produces an error when one tries to. The error reads
"cannot manually encode TypeXHeader, TypeGNULongName, or TypeGNULongLink
headers"

Signed-off-by: Matt Farina <matt@mattfarina.com>

* Adding check of returned error in test

Adding a check for the returned error to make sure a non-nil value
is not returned.

Signed-off-by: Matt Farina <matt@mattfarina.com>
2020-05-13 17:09:27 -05:00
..
testdata fix(*): remove bom in utf files when loading chart files (#6081) 2020-04-23 14:56:26 +02:00
archive.go fix(*): remove bom in utf files when loading chart files (#6081) 2020-04-23 14:56:26 +02:00
archive_test.go Fixing PAX Header handling (#8086) 2020-05-13 17:09:27 -05:00
directory.go fix(*): remove bom in utf files when loading chart files (#6081) 2020-04-23 14:56:26 +02:00
load.go fix(*): Helm v3 handling of APIVersion v1 charts dependencies (#7009) 2019-12-11 17:07:05 +00:00
load_test.go test: add test for bom test data integrity 2020-04-24 11:09:27 +02:00