helm/pkg/chart
Matt Farina 512544b9ab
Fixing PAX Header handling (#8086)
* Fixing issue with PAX headers in plugin archive

PAX Headers can be added by some systems that create archives. Helm
should ignore them when extracting.

There are two PAX headers. One is global and the other is not. Both
are ignored. The test adds only the PAX global header because the
Go tar package is unable to write the header that is not global.

Closes #8084

Signed-off-by: Matt Farina <matt@mattfarina.com>

* Removing the PAX header test as it is not working

The PAX header test was making a WriteHeader call and ignoring the
error. When writing the type TypeXHeader it was causing an error
that was being silently ignored. The Go tar package cannot write
this type and produces an error when one tries to. The error reads
"cannot manually encode TypeXHeader, TypeGNULongName, or TypeGNULongLink
headers"

Signed-off-by: Matt Farina <matt@mattfarina.com>

* Adding check of returned error in test

Adding a check for the returned error to make sure a non-nil value
is not returned.

Signed-off-by: Matt Farina <matt@mattfarina.com>
2020-05-13 17:09:27 -05:00
..
loader Fixing PAX Header handling (#8086) 2020-05-13 17:09:27 -05:00
chart.go Fixes issue where non-CRDs are read in from the crd directory 2020-02-07 11:24:05 -05:00
chart_test.go Add unit test for pkg/chart/chart.go 2020-04-27 14:19:02 +08:00
dependency.go Spelling (#7258) 2019-12-18 12:04:08 +00:00
errors.go ref(pkg/chartutil): break up chartutil into logical files 2019-05-22 19:38:11 +02:00
file.go fix(chart): add JSON tags to chart object 2019-11-01 14:50:32 -07:00
metadata.go feat: Add support for a crds/ directory 2019-08-16 16:26:55 -06:00
metadata_test.go add unit test for metadata Validate 2020-04-14 11:29:34 +08:00