Commit graph

4349 commits

Author SHA1 Message Date
Martin Hickey
ecf4eda6c5 Fix scaffold chart label in helper template
The 'app.kubernetes.io/version' label was not being rendered as
expected. It was appending onto the label before it and also
the next label label was appending onto it on the same line.

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-05-09 10:56:46 +01:00
Matt Farina
2a06c2baba
Merge pull request #5684 from mattfarina/add-app-version
Add app version
2019-05-07 16:09:43 -04:00
Adam Reese
b8bced2649
fix(pkg/action): load clients after flags have been parsed (#5681)
Signed-off-by: Adam Reese <adam@reese.io>
2019-05-07 12:02:07 -07:00
Matt Farina
250b63eced
Updating the labels for consistency
Signed-off-by: Matt Farina <matt@mattfarina.com>
2019-05-07 14:13:29 -04:00
Luis Davim
82ffe56ca6
Reduce template code duplication. Fixes #5372
Signed-off-by: Luis Davim <luis.davim@jet.com>
2019-05-07 12:03:54 -04:00
Luis Davim
4425f86865
Add app.kubernetes.io/version label
Signed-off-by: Luis Davim <luis.davim@jet.com>
2019-05-07 11:59:49 -04:00
Matt Farina
af7eab0325
Updating to the k8s label convention
Closes #4335

Signed-off-by: Matt Farina <matt@mattfarina.com>
2019-05-07 11:26:31 -04:00
Matthew Fisher
f39e3da306
Merge pull request #5656 from hickeyma/replace-k8s-helm
fix(docs): 'From Source' section in install doc
2019-05-07 08:06:57 -07:00
Martin Hickey
75624afb73
Merge pull request #5662 from hickeyma/fix-scaffold-chart-image
fix(chartutil): Scaffold chart fails to deploy pod
2019-05-07 09:38:49 +01:00
Josh Dolitsky
a12a396aab
Helm 3: registry login/logout (#5597)
* login/logout placeholders

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* use latest oras

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* use docker auth system

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* working login+push

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* working on tests

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* fix typo in htpasswd

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* rename credsfile to config.json

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* add flags for username/password

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* disable logout test broken on linux

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* upgrade to oras 0.4.0

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* re-enable logout test

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* panic for uncaught errors

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

* move login/logout to new registry subcommand

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
2019-05-06 16:15:34 -05:00
Martin Hickey
f12c2a3111 Change the nginx app version to a set tag
Want to avoid moving tags like using 'stable'. Therefore,
specify the specifc nginx version/tag.

Update from comment review:
- https://github.com/helm/helm/pull/5662#discussion_r280122531

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-05-02 10:00:41 +01:00
Martin Hickey
86c5e52ac4 Fix the image field for the scaffold chart application
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-30 18:13:17 +01:00
Matthew Fisher
b1ae1acc8b
Merge pull request #5283 from bacongobbler/purge-by-default
ref(uninstall): purge release history by default
2019-04-30 06:55:27 -07:00
Martin Hickey
1915358a21
Merge pull request #5538 from hickeyma/add-app-version
feat(*): Add app version to history table
2019-04-30 09:23:21 +01:00
Martin Hickey
4ad8b0cb00 Update from source section in install doc
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-29 09:59:22 +01:00
Matthew Fisher
1b77848c89
Merge pull request #5649 from VilledeMontreal/docs/replacek8sByHelm
docs: Replace reference to k8s.io to helm.sh
2019-04-26 12:48:13 -07:00
Marc Khouzam
3eef735305 docs: Replace reference to k8s.io to helm.sh
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
2019-04-26 15:27:00 -04:00
Ian Howell
ffff0e8c33 Feat/schema validation (#5350)
* Add the Schema type and a function to read it

* Added a function to read a schema from a file

* Check that values.yaml matches schema

This commit uses the gojsonschema package to validate a values.yaml file
against a corresponding values.schema.yaml file.

* Add functionality to generate a schema from a values.yaml

* Add Schema to Chart and loader

* Clean up implementation in chartutil

* Add tests for helm install with schema

* Add schema validation to helm lint

* Clean up "matchSchema"

* Modify error output

* Add documentation

* Fix a linter issue

* Fix a test that broke during a rebase

* Clean up documentation

* Specify JSONSchema spec

Since JSONSchema is still in a draft state as of this commit, we need to
specify a particular version of the JSONSchema spec

* Switch to using builtin functionality for file extensions

* Switch to using a third-party library for JSON conversion

* Use the constants from the gojsonschema package

* Updates to unit tests

* Minor change to avoid string cast

* Remove JSON Schema generation

* Change Schema type from map[string]interface{} to []byte

* Convert all Schema YAML to JSON

* Fix some tests that were broken by a rebase

* Fix up YAML/JSON conversions

* This checks subcharts for schema validation

The final coalesced values for a given chart will be validated against
that chart's schema, as well as any dependent subchart's schema

* Add unit tests for ValidateAgainstSchema

* Remove nonessential test files

* Remove a misleading unit test

The TestReadSchema unit test was simply testing the ReadValues function,
which is already being validated in the TestReadValues unit test

* Update documentation to reflect changes to subchart schemas
2019-04-26 08:45:03 -07:00
Michelle Noorali
3dd1765491
Merge pull request #5631 from michelleN/test-run
add helm test run
2019-04-25 16:56:10 -04:00
Matthew Fisher
e2ccf13294
Merge pull request #5553 from bacongobbler/same-appversion-as-version
ref(create): app version should be 0.1.0
2019-04-23 14:22:03 -07:00
Michelle Noorali
ceab13e9a1 fix test command, move test to test run subcmd
Signed-off-by: Michelle Noorali <michellemolu@gmail.com>
2019-04-23 16:47:29 -04:00
Martin Hickey
b72e25cfb9 Change header "APP_VERSION" to "APP VERSION"
Update following review comment:
- https://github.com/helm/helm/pull/5538#pullrequestreview-221803355

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-23 17:43:43 +01:00
Martin Hickey
b600f6090e Add app version to history table
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-23 17:02:01 +01:00
Matthew Fisher
5264ebd5aa
Merge pull request #5572 from ian-howell/fix/template-error-messages
fix(pkg/engine): Clean up template error messages
2019-04-23 08:56:10 -07:00
Matthew Fisher
d3f0ac9343
ref(create): app version should be 0.1.0
When creating a Helm chart for the first time, the assumption should be that the app version is also 0.1.0, implying this is for a new application.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-04-15 12:06:16 -07:00
Adam Reese
658c66dc66
Merge pull request #5560 from adamreese/v3/chart-validate
ref(pkg/chart): add validation method to chart
2019-04-12 12:31:14 -07:00
Michelle Noorali
b2a912324c
Merge pull request #5591 from michelleN/uninstall-bug
fix multi uninstall bug
2019-04-11 17:13:10 -04:00
Michelle Noorali
0d08044776 fix multi uninstall bug
Signed-off-by: Michelle Noorali <michellemolu@gmail.com>
2019-04-11 17:04:06 -04:00
Ian Howell
278594fb0f fix(pkg/engine): Style changes on template errors
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
2019-04-09 12:34:13 -05:00
Ian Howell
92b86f6e74 fix(pkg/engine): Catch non-templating errors when rendering templates
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
2019-04-09 10:54:01 -05:00
Ian Howell
33b1ede570 fix(pkg/engine): Clean up template error messages
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
2019-04-08 16:48:21 -05:00
Adam Reese
e458a67f0c
ref(pkg/chart): add validation method to chart
Consolidate validation of Chart.yaml.

Signed-off-by: Adam Reese <adam@reese.io>
2019-04-05 13:40:06 -07:00
Adam Reese
d4323c1da8
Merge pull request #5529 from ian-howell/docs/V2toV3
docs: Update the "Developer Guide"
2019-04-01 11:44:33 -07:00
Matthew Fisher
9ac1b756e1
Merge pull request #5458 from hickeyma/fix-make-docs-target
Fix the docs targets
2019-04-01 09:02:51 -07:00
Martin Hickey
bd7c970ff9 Fix files copyright
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-01 16:47:24 +01:00
Martin Hickey
030fef5765 Fix docs targets
Update to the `docs` and `verify-docs` targets for v3.

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-01 11:40:44 +01:00
Martin Hickey
46e6539e63 Remove docs target and generated docs folder
It would seem that generated docs were removed in `5048ed8`

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-01 10:07:42 +01:00
Martin Hickey
d59835fb67 Fix make docs target
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-01 10:07:42 +01:00
Ian Howell
8f87eb1fac docs: Update the "Developer Guide"
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
2019-03-29 14:08:36 -05:00
Adam Reese
4b9bdf5baa
Merge pull request #5528 from adamreese/v3/capabilities-marshal
fix(pkg/chartutil): marshal capabilities VersionSet into slice
2019-03-29 09:01:54 -07:00
Adam Reese
31819e4796
fix(pkg/chartutil): marshal capabilities VersionSet into slice
Marshal capabilities VersionSet into readable value.

Signed-off-by: Adam Reese <adam@reese.io>
2019-03-29 08:49:15 -07:00
Adam Reese
5f9ff4cdae
Merge pull request #5527 from adamreese/v3/capabilites-external-only
fix(pkg/chartutil): only include external objects in capabilities
2019-03-29 08:34:02 -07:00
Adam Reese
87e789f01f
fix(pkg/chartutil): only include external objects in capabilities
Signed-off-by: Adam Reese <adam@reese.io>
2019-03-28 23:37:32 -07:00
Adam Reese
fe06343b8f
Merge pull request #5512 from adamreese/v3/linter-fixes
ref(pkg/action): refactoring dup code and linter fixes
2019-03-26 13:48:39 -07:00
Matthew Fisher
5f579aaf47
Merge pull request #5506 from bacongobbler/k8s-1.14
chore(dep): bump kubernetes to 1.14.0
2019-03-26 13:29:12 -07:00
Adam Reese
295092cd7d
ref(pkg/action): refactoring dup code and linter fixes
Signed-off-by: Adam Reese <adam@reese.io>
2019-03-26 11:11:27 -07:00
Matthew Fisher
bb179bdead
chore(dep): bump kubernetes to 1.14.0
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-03-25 14:01:01 -07:00
Matthew Fisher
0805a87140
ref(uninstall): purge release history by default
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-03-25 09:30:58 -07:00
Matthew Fisher
0b1caa14a7
Merge pull request #5489 from bacongobbler/list-move-namespaces-field
ref(list): move namespaces field closer to the name
2019-03-22 15:46:12 -07:00
Matthew Fisher
32712201ec
ref(list): move namespaces field closer to the name
Most users want to see the release name and the namespace it was deployed to,
as those are the unique identifiers where the release is stored. I also added
integration tests for `helm list` to better test the command output.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-03-20 13:43:22 -07:00