Commit graph

5136 commits

Author SHA1 Message Date
Naseem
b9a8e98bca
Add hpa boilerplate
Signed-off-by: Naseem <naseem@transit.app>
2020-01-11 01:03:01 -05:00
海的澜色
985827d09a stop with an error immediately if a file or directory with that name already exists (#7187)
* fix #7182

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* fix testcase

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* update error message

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* complete testCase when file/dir existed.

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* fix the case with current directory

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* fix conflict subdirectory when untardir is the clashing directory

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* update comment

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* add case when destination exists.

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
2020-01-10 15:01:59 +00:00
Taylor Thomas
f35719a62a
Merge pull request #7320 from PhilGrayson/issue-7279
Do not delete templated CRDs
2020-01-09 11:03:55 -07:00
Naseem
a963736f66 [helm create] Include serviceAccount.annotations value (#7246)
* Include serviceAccount.annotations value

Signed-off-by: Naseem <naseemkullah@gmail.com>

* Add comment about service account annotations

Signed-off-by: Naseem <naseemkullah@gmail.com>
2020-01-09 14:04:02 +00:00
Marc Khouzam
edaac9649e
Merge pull request #7298 from VilledeMontreal/fix/relativePathAcceptance
fix(tests): Use relative path to acceptance tests
2020-01-08 13:32:56 -05:00
Matthew Fisher
7d72c43a66
Merge pull request #7352 from bacongobbler/fix-use-sigs-k8s-yaml
fix(tests): use sigs.k8s.io/yaml
2020-01-08 10:29:43 -08:00
Matthew Fisher
826ad655f2
Merge pull request #7354 from bacongobbler/go-mod-tidy
chore(go.sum): run `go mod tidy`
2020-01-08 10:05:36 -08:00
Matthew Fisher
7432fdc9ef
Merge pull request #7355 from dastrobu/#7159-cannot-install-service-account-token-due-to-install-order
fix(helm): move ServiceAccount before Secret in InstallOrder.
2020-01-08 10:04:33 -08:00
Matthew Fisher
9e4d42e18c
Merge pull request #7245 from waveywaves/fix/crd-install-api-extensions
fix(kube/client) crd install with apiextensions.k8s.io/v1
2020-01-08 09:58:16 -08:00
Matthew Fisher
d2b89119a0
Merge pull request #6904 from bakito/master
print gvk information on existing resource conflict
2020-01-08 09:54:35 -08:00
Daniel Strobusch
08663e6bb3
fix(helm): move ServiceAccount before Secret in InstallOrder.
Service accounts must be installed before secrets when service account tokens (secrets) are be managed by Helm. Otherwise Kubernetes will delete any service account token right after creation, since there is no service account mounting the token (see https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/#token-controller)

Closes #7159.

Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
2020-01-08 18:54:08 +01:00
Matthew Fisher
1230df8822
chore(go.sum): run go mod tidy
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2020-01-08 09:46:14 -08:00
bakito
ab905010fd fix error output
Signed-off-by: Marc Brugger <github@bakito.ch>
2020-01-08 18:46:10 +01:00
Matthew Fisher
ff0257de29
fix(tests): use sigs.k8s.io/yaml
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2020-01-08 09:45:37 -08:00
Matthew Fisher
8207d64b1a
Merge pull request #6988 from Dean-Coakley/add-390x-support
Add s390x build target
2020-01-08 09:29:51 -08:00
Matthew Fisher
840bbc951e
Merge pull request #6842 from AndiDog/object-order
fix(template): process manifests in file path order, then in order found in each file (before sorting manifests)
2020-01-08 09:28:33 -08:00
Hu Shuai
de9118b879 Fix a typo "update" -> "updates" (#7346)
Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
2020-01-08 09:19:00 +00:00
Jorge I. Gasca
ad07bb690d fix(cmd): Fixes logging on action conf init error (#6909)
* fix(cmd): Fixes logging on action conf init error

Errors relating to initializing the action config cause helm to exit silently,
except when in debug mode. This now emits the useful error.

Closes #6863

Signed-off-by: Jorge Gasca <jorge.ignacio.gasca@gmail.com>

* Remove unnecessary formatting of err struct

Signed-off-by: Jorge Gasca <jorge.ignacio.gasca@gmail.com>
2020-01-07 17:25:15 +00:00
Nguyen Hai Truong
29cc5efc18 Remove duplicated words (#7336)
Although it is spelling mistakes, it might make an affects while reading.

Signed-off-by: Nguyen Hai Truong <truongnh@fujitsu.com>
2020-01-06 15:54:47 +00:00
Xiang Dai
40df2f2a63 Improve description for --all flag (#7144)
* Improve description for `--all` flag

Signed-off-by: Xiang Dai <764524258@qq.com>

* feedback

Signed-off-by: Xiang Dai <764524258@qq.com>
2020-01-06 11:33:07 +00:00
Matthew Fisher
8dddb18de7
Merge pull request #7327 from jugatsu/jugatsu-fix-typo-values
Fix typo in --values cmd flag
2020-01-02 08:06:39 -08:00
Anton Kvashenkin
a58430a944 Fix typo in --values cmd flag
Fix a small typo in `--values` flag in `helm install/upgrade --help` output.

Signed-off-by: Anton Kvashenkin <anton.jugatsu@gmail.com>
2020-01-02 19:39:07 +04:00
Phil Grayson
600970459e Do not delete templated CRDs
Fixes issue #7279.

Prevent the deletion of CRDs that were defined in the `templates/`
directory. This makes CRD deletion behaviour consistent with Helm
documentation:

 > CRDs are never deleted. Deleting a CRD automatically deletes all of the
 > CRD’s contents across all namespaces in the cluster. Consequently, Helm
 > will not delete CRDs.

Previous the documentation only applied to CRDs that were defined in the
`crds/` directory. It did not consider that Charts could have CRDs in the
`templates/` directory (for example charts that were written before the
`crds/` directory feature or if the Chart author needed templated CRDs).

Signed-off-by: Phil Grayson <phil@philgrayson.com>
2020-01-01 22:02:03 +00:00
Marc Khouzam
6c604a400e
Merge pull request #7307 from finkr/fix-completion7304
fix(comp): tail cannot open +2 for reading
2019-12-31 17:46:10 -05:00
Matthew Fisher
38670ebe3d
Merge pull request #7316 from hs0210/work
Fix a typo "the the" -> "the"
2019-12-30 23:15:13 -08:00
Hu Shuai
3eb8df0c5e Fix a typo "the the" -> "the"
Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
2019-12-31 13:52:19 +08:00
Frank Lin PIAT
2eab781b35 fix(comp): tail cannot open +2 for reading
Signed-off-by: Frank Lin PIAT <fpiat@klabs.be>
2019-12-28 22:51:44 +01:00
Marc Khouzam
b47a5b746d fix(tests): Use relative path to acceptance tests
With Helm using go modules, its git repo need not reside under
$GOPATH/src/helm.sh anymore.  In fact it may be desirable for a user to
move it to another location (e.g., to get the debugger to work).

In the same train of thought, the acceptance-testing repo, which is not
even a go program, need not be in the GOPATH.

This commit reduces the requirement on the location of the
acceptance-testing repo to a relative path to the helm repo, instead
of an absolute path within GOPATH.

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
2019-12-25 16:12:15 -05:00
Taylor Thomas
1ff8272748
Merge pull request #7290 from fenggw-fnst/work
Add corresponding unit test to the function in resource.go.
2019-12-23 09:22:35 -07:00
Guangwen Feng
cedd480199 Add corresponding unit test to the function in resource.go.
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2019-12-23 20:53:25 +08:00
Matthew Fisher
07a3d7299c
Merge pull request #7286 from phumberdroz/master
Point users to helm hub instead of the helm chart repo
2019-12-20 15:05:43 -08:00
Pierre Humberdroz
36c06141f8
docs: point users to helm hub
Signed-off-by: Pierre Humberdroz <pierre.humberdroz@prezero.com>
2019-12-20 22:39:46 +01:00
Taylor Thomas
12e0ab7e44
Merge pull request #7284 from heyleke/feat/hg-orig
fix(helm): add .orig as typical backup file in .helmignore
2019-12-20 10:31:17 -07:00
Taylor Thomas
df13e24513
Merge pull request #7269 from adriangonz/fix-crd-update
Add back fix for CRD patch creation
2019-12-20 10:11:39 -07:00
Jan Heylen
a2bbb67839 fix(helm): add .orig as typical backup file
Mercurial VCS (hg) backout's can generate '.orig' files
to avoid these being picked, generate a .helmignore where
also the .orig files are ignored.

Signed-off-by: Jan Heylen <jan.heylen@nokia.com>
2019-12-20 17:28:00 +01:00
Matthew Fisher
d876daa362
Merge pull request #7272 from Hiruma31/bugfix/7220
Port PR #4161 to Helmv3 - Fix incorrect timestamp when helm package
2019-12-19 12:28:20 -08:00
Romain Grenet
8cb3c02c47 Port PR #4161 Fix incorrect timestamp when helm package to Helmv3
Lint CRLF
Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
2019-12-19 13:22:08 -05:00
Adrian Gonzalez-Martin
afa612df9d Add back fix for CRD patch creation
Signed-off-by: Adrian Gonzalez-Martin <agm@seldon.io>
2019-12-19 13:58:02 +00:00
Dean Coakley
f3249b5ee2 Add new Makefile targets
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
2019-12-18 13:14:29 +00:00
Josh Soref
02ad2b1187 Spelling (#7258)
* spelling: constraint

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cryptographic

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dependency

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: doesnot

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: don't

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unexpected

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dreadnought

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: default

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: envvars

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: evaluates

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: execute

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extractor

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: frobnitz

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: generated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: implementation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: jabba

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: keywords

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: kubernetes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: override

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: package

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: parsable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: progress

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: recursively

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: release

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cache

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: representing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: serializer

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: subchart

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: utilities

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2019-12-18 12:04:08 +00:00
Dean Coakley
e4c0eb8720
Merge branch 'master' into add-390x-support 2019-12-18 11:55:38 +00:00
Matt Butcher
bd8dbcac8b
add technosophos public key (#7256)
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
2019-12-17 11:33:52 -07:00
Martin Hickey
b6e2a14306
fix(kube): Port use of watcher with retries to wait for resources (#7217)
* Port watcher with retries to wait for resources

Port of Helm 2 PR #6014 to Helm 3

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

* Add fix from PR #6907

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-12-17 17:41:04 +00:00
Matt Farina
63bc47ecb6
Merge pull request #7227 from mattfarina/bump-sprig-3.0.2
Updating to sprig 3.0.2 to bring in a bugfix
2019-12-17 12:31:43 -05:00
Marc Khouzam
0edb09e4fa
Merge pull request #6860 from VilledeMontreal/fix/protectAgainstAliases
v3: fix(comp): Protect against user's aliases
2019-12-16 19:20:01 -05:00
Marc Khouzam
c7ac4151e2 Merge branch 'master' into fix/protectAgainstAliases 2019-12-16 19:11:55 -05:00
Vibhav Bobade
1c6424cb18 fix(install) crd install with apiextensions.k8s.io/v1
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
2019-12-17 01:32:29 +05:30
Andreas Sommer
4d8160eedf feat(template): process manifests in file path order, then in order found in each file (before sorting manifests)
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
2019-12-16 20:51:22 +01:00
Matthew Fisher
f4f5b2e46f
Merge pull request #7240 from Blokje5/fix/incorrect-error-message-in-helm-install
fix(helm): Validate number of arguments in install client
2019-12-16 09:26:50 -08:00
Lennard Eijsackers
a3f00fde69 fix(helm): Validate number of arguments in install client
The 'helm install' command returned confusing error messages if a flag was misspecified (e.g. `helm install name chart --set value foo`). This lead to an error indicating that a name should be specified for the command. Now an explicit check is done on the number of arguments passed, returning a message indicating the invalid arguments (`foo` in the example`).

Closes #7225

Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
2019-12-16 18:14:06 +01:00