Commit graph

409 commits

Author SHA1 Message Date
Martin Hickey
f08db5c899
Merge pull request #10834 from stan-sz/stan-sz/10285
Log error message on failed download
2022-08-12 09:57:16 +01:00
Martin Hickey
1d15ad7ea4
Merge pull request #10506 from suzaku/support-no-headers
Add support for`helm list --no-headers`
2022-08-12 09:55:31 +01:00
Dominic Evans
7c74f1dd02 fix: improve logging & safety of statefulSetReady
Confirm that the current and updated revision numbers also match as part
of the readiness check. Add coverage for readiness scenarios where
StatefulSet status does not reflect the most recent generation of the
StatefulSet yet.

Also add additional logging around the sts transitions from non-ready to
ready.

Fixes: #10163

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
2022-06-28 09:48:17 +01:00
Matthew Fisher
2ae4937e42
Merge pull request #10762 from yxxhero/fix_registry_config_issue
fix --registry-config issue
2022-05-13 10:08:04 -07:00
Matthew Fisher
e54e24cc90
Merge pull request #10852 from IamMayankThakur/main
Fixed helm uninstall not deleting the resource.
2022-05-13 10:05:52 -07:00
Matt Farina
2cd709c4a6
Merge pull request #10106 from presztak/lint_quiet_flag
feat(*): add --quiet flag to 'helm lint'
2022-05-06 16:30:38 -04:00
Martin Hickey
c477d697ec
Merge pull request #10458 from SimonAlling/remove-AssertGoldenBytes
Remove AssertGoldenBytes test helper
2022-04-29 09:37:23 +01:00
Mayank Thakur
fe00c9296d Fixed helm uninstall not deleting the resource.
* Added `nil` check for returned err.
  * Return in case of `err` when deleting the release

Signed-off-by: Mayank Thakur <thakurmayank88@gmail.com>
2022-04-12 12:55:47 +05:30
Graham Reed
82a2a2e85c Populate Capabilities.HelmVersion during install
Signed-off-by: Graham Reed <greed@7deadly.org>
2022-04-11 14:33:00 +01:00
stan-sz
6c55d9e3e9 Fix linter
Signed-off-by: GitHub <noreply@github.com>
2022-04-11 09:14:26 +00:00
stan-sz
a7e4ae752a Update install.go
Feedback from PR

Signed-off-by: GitHub <noreply@github.com>
2022-04-11 09:00:48 +00:00
stan-sz
660e4ffe7a Log error message on failed download
Signed-off-by: GitHub <noreply@github.com>
2022-04-11 09:00:48 +00:00
suzaku
d76f86b01c Add support helm list --no-headers
Signed-off-by: suzaku <satorulogic@gmail.com>

Add test

Signed-off-by: suzaku <satorulogic@gmail.com>

Revert change to value semantic

Signed-off-by: satoru <satorulogic@gmail.com>
2022-03-26 09:07:18 +08:00
yxxhero
9f199b6517 fix --registry-config issue
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-03-12 16:56:23 +08:00
Matthew Fisher
e9abdc5efe
Merge pull request #9751 from cndoit18/fix-issue-9747
fix(rollback): fix helm rollback doesn't have meta.helm.sh annotations
2022-03-11 12:39:09 -08:00
Eng Zer Jun
2e3e22a003
test: use T.TempDir to create temporary test directory
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-02-12 13:54:54 +08:00
Matt Farina
1ec0aacb88
Merge pull request #10486 from gridai/fix-install-leak
Fix install memory/goroutine leak
2022-01-27 15:03:58 -05:00
Piotr Resztak
383086d397 feat(*): add --quiet flag to 'helm lint'
Quiet flag reduce the verbosity, such that the only text
that is written to the console is lint warnings/errors

Closes #9994

Signed-off-by: Piotr Resztak <piotr.resztak@gmail.com>
2022-01-20 17:21:03 +01:00
David Peraza
9661e39dce Moving uploader and pusher out of action into pkg
Signed-off-by: David Peraza <dperaza@redhat.com>
2022-01-13 08:22:51 -05:00
David Peraza
7cab1a09e3 Move all the remainder module out of experimental.
All the experimental modules were moved to pkg/action

Signed-off-by: David Peraza <dperaza@redhat.com>
2022-01-12 22:51:32 -05:00
Thomas Runyon
353d74e967 refactor internal/experimental/registry to pkg/registry
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
2022-01-12 21:49:26 -05:00
Matt Farina
548ec55cf9
Fix panic with OCI for install, upgrade, and show
When range support for OCI went in via #10527 it created a situation
where some lookups for a chart could cause a panic. This change
makes sure the registry client is available to lookup OCI charts

Signed-off-by: Matt Farina <matt.farina@suse.com>
2022-01-12 21:30:27 -05:00
Andrew Block
1a9cb93551
Handling name of OCI file
Signed-off-by: Andrew Block <andy.block@gmail.com>
2022-01-12 15:49:12 -06:00
Scott Rigby
4d50526a2b
Move OCI tag semver range logic from OCIGetter to ChartDownloader
Signed-off-by: Scott Rigby <scott@r6by.com>
2022-01-12 14:36:54 -05:00
Andrew Block
4f62d3dc1b
Started work on 'helm pull'
Signed-off-by: Andrew Block <andy.block@gmail.com>
2022-01-11 21:47:03 -05:00
Andrew Block
df98e18eb7
Working oci code without providing versions
Signed-off-by: Andrew Block <andy.block@gmail.com>
2022-01-11 21:47:03 -05:00
mengjiao.liu
160da867d0 validate release name during install
Signed-off-by: mengjiao.liu <mengjiao.liu@daocloud.io>
2021-12-29 14:45:05 +08:00
Neven Miculinic
5059ae843e Fix install memory/goroutine leak
Signed-off-by: Neven Miculinic <neven.miculinic@gmail.com>
2021-12-20 10:17:38 +01:00
Simon Alling
dd5db7bc40 Remove AssertGoldenBytes test helper
The test suite is thereby simplified somewhat.

Signed-off-by: Simon Alling <alling.simon@gmail.com>
2021-12-13 10:56:45 +01:00
Jerome Küttner
9a492f8240 Channel should remain open if there is still a routine that wants to write into it
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
2021-12-06 18:07:47 +01:00
Jerome Küttner
ad3d2cc8ef Fix memory leak in upgrade action
fixes helm/helm#10439

Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
2021-12-06 17:54:46 +01:00
cndoit18
94dc605968
fix(rollback): fix helm rollback doesn't have meta.helm.sh annotations
Signed-off-by: cndoit18 <cndoit18@outlook.com>
2021-11-30 10:45:34 +08:00
Matthew Fisher
a8d33e7df4
Merge pull request #9918 from cndoit18/fix-issue-9915
fix(install): fix 9915
2021-11-26 08:47:31 -08:00
Timofey Kirillov
7f68bfa1fa
fix: added resource info into the validation error
Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
2021-11-12 19:00:43 +03:00
Guangwen Feng
9b7a45a384 Fix a golint issue caused by typo
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2021-11-01 17:39:58 +08:00
Alexey Igrychev
5753f61ae3 docs: fix typo Charts.yaml
Signed-off-by: Alexey Igrychev <alexey.igrychev@flant.com>
2021-10-07 16:50:25 +01:00
cndoit18
da15d96a68
fix(install): if subcharts are disabled, the CRD for subcharts should not be installed
Signed-off-by: cndoit18 <cndoit18@outlook.com>
2021-09-01 13:57:46 +08:00
Matt Farina
accf82ba1c
Merge pull request #9180 from Moser-ss/feature-handle-SIGINT
Handle SIGTERMs during helm upgrade and helm install
2021-08-30 18:18:13 -04:00
Matt Farina
2062a59566
Merge pull request #9702 from mikeshng/uninstall-wait
feat: add optional boolean '--wait' flag to 'uninstall' command.
2021-08-30 17:43:50 -04:00
Josh Dolitsky
caa97158d0
Revert moving registry actions back to pkg/
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
2021-08-30 15:54:42 -04:00
Josh Dolitsky
77750962d5
Move registry actions back to pkg/
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
2021-08-30 11:24:18 -04:00
Mike Ng
75fe8883cc Rename newly introduced interface to InterfaceExt
Signed-off-by: Mike Ng <ming@redhat.com>
2021-08-27 09:38:04 -04:00
Mike Ng
d51a61f9ab Introduce a new interface for WaitForDelete() to avoid breaking backwards compatibility
Signed-off-by: Mike Ng <ming@redhat.com>
2021-08-26 17:30:55 -04:00
Josh Dolitsky
0121f6a328
Merge branch 'main' of github.com:helm/helm into hip-6
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
2021-08-26 16:51:02 -04:00
Mike Ng
655bdcd2fd feat: add optional boolean '--wait' flag to 'uninstall' command.
If set, 'uninstall' command will wait until all the resources are deleted before returning.
It will wait for as long as --timeout

closes #2378

Signed-off-by: Mike Ng <ming@redhat.com>
2021-08-26 15:31:49 -04:00
Matt Farina
0ff53945bf
Fixing issue where helm show all fails to show crds when no readme
Closes #10058

Signed-off-by: Matt Farina <matt.farina@suse.com>
2021-08-25 11:50:17 -04:00
Matt Farina
9443a7ead4
Merge pull request #10033 from avorima/show-crds-command
Implement show crds subcommand
2021-08-24 12:36:00 -04:00
John Howard
82a2abf512 Update oras-go to v0.4.0
Signed-off-by: John Howard <howardjohn@google.com>
2021-08-19 08:33:22 -07:00
Mario Valderrama
fae7853c2a Implement show crds subcommand
This subcommand will display manifests under `crds/` if some exist.

This also changes the behaviour of `show all` to include CRDs.

Signed-off-by: Mario Valderrama <woldy401@gmail.com>
2021-08-18 19:22:47 +02:00
Stephane Moser
c62ce12bed Refactor SIGTERM logic
Use context to handle SIGTERM in the cmd/helm instead of pkg/action

Signed-off-by: Stephane Moser <moser.sts@gmail.com>
2021-07-26 01:04:58 +01:00