upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-28 04:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Rename newly introduced interface to InterfaceExt

Browse source 
Signed-off-by: Mike Ng <ming@redhat.com>
This commit is contained in:
Mike Ng 2021-08-27 09:38:04 -04:00
parent d51a61f9ab
commit 75fe8883cc
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/action/uninstall.go
View file

@ -120,7 +120,7 @@ func (u *Uninstall) Run(name string) (*release.UninstallReleaseResponse, error)
res.Info = kept
if u.Wait {
if kubeClient, ok := u.cfg.KubeClient.(kube.ClientInterface); ok {
if kubeClient, ok := u.cfg.KubeClient.(kube.InterfaceExt); ok {
if err := kubeClient.WaitForDelete(deletedResources, u.Timeout); err != nil {
errs = append(errs, err)
}

8
pkg/kube/interface.go
View file

@ -70,13 +70,13 @@ type Interface interface {
IsReachable() error
}
// ClientInterface is introduced to avoid breaking backwards compatibility for Interface implementers.
// InterfaceExt is introduced to avoid breaking backwards compatibility for Interface implementers.
//
// TODO Helm 4: Remove ClientInterface and integrate its method(s) into the Interface.
type ClientInterface interface {
// TODO Helm 4: Remove InterfaceExt and integrate its method(s) into the Interface.
type InterfaceExt interface {
// WaitForDelete wait up to the given timeout for the specified resources to be deleted.
WaitForDelete(resources ResourceList, timeout time.Duration) error
}
var _ Interface = (*Client)(nil)
var _ ClientInterface = (*Client)(nil)
var _ InterfaceExt = (*Client)(nil)