Commit graph

8493 commits

Author SHA1 Message Date
Matt Farina
4f018e4f42
Merge pull request #30973 from manslaughter03/fix/issue-13648
fix: wrap run release test error in case GetPodLogs failed.
2025-06-12 14:37:09 -06:00
manslaughter03
bc44614a78 fix: wrap run release test error in case GetPodLogs failed.
Signed-off-by: manslaughter03 <manslaughter03@gmail.com>
2025-06-11 00:45:34 +02:00
Matt Farina
0a8194c9a3
Merge pull request #30972 from TerryHowe/kube-client-update-mutex
fix: kube client create mutex
2025-06-10 13:57:54 -06:00
Terry Howe
744c6b5a97
fix: kube client create mutex
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-06-10 09:28:52 -06:00
Matt Farina
a73c51ca08
Merge pull request #30961 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.39.0
build(deps): bump golang.org/x/crypto from 0.38.0 to 0.39.0
2025-06-06 11:44:36 -06:00
Matt Farina
919933553b
Merge pull request #30958 from TerryHowe/repo-update-cmd-mutex
fix: repo update cmd mutex
2025-06-06 11:42:20 -06:00
dependabot[bot]
b250b1de82
build(deps): bump golang.org/x/crypto from 0.38.0 to 0.39.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.38.0 to 0.39.0.
- [Commits](https://github.com/golang/crypto/compare/v0.38.0...v0.39.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.39.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-06 17:37:49 +00:00
Matt Farina
284ca17ae9
Merge pull request #30962 from helm/dependabot/go_modules/main/golang.org/x/text-0.26.0
build(deps): bump golang.org/x/text from 0.25.0 to 0.26.0
2025-06-06 11:35:27 -06:00
Terry Howe
93ec064640
fix: repo update cmd mutex
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-06-06 06:47:50 -06:00
dependabot[bot]
fee9907a80
build(deps): bump golang.org/x/text from 0.25.0 to 0.26.0
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](https://github.com/golang/text/compare/v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-version: 0.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-05 21:58:39 +00:00
Robert Sirchia
3ebad60d3c
Merge pull request #30957 from acceptacross/main
chore: fix some function names in comment
2025-06-04 11:53:06 -06:00
acceptacross
9623fb80f1 chore: fix some function names in comment
Signed-off-by: acceptacross <csqcqs@gmail.com>
2025-06-04 23:54:30 +08:00
Matt Farina
7031000b7d
Merge pull request #30955 from carloslima/fix-test-deleting-local-directories
Fix tests deleting XDG_DATA_HOME
2025-06-04 09:33:40 -06:00
Scott Rigby
069b525332
Merge pull request #13586 from jessesimpson36/cleaner-stacktraces
fix: add formatting for errors to make multiline stacktraces in helm templates
2025-06-03 21:37:54 -04:00
Carlos Lima
f8204031f1 Fix tests deleting XDG_DATA_HOME
That includes ~/.local/share/keyrings which was the most immediatelly
visible effect.

Signed-off-by: Carlos Lima <carlos@cpan.org>
2025-06-04 09:01:47 +08:00
Robert Sirchia
c0aa690c90
Merge pull request #30909 from jinjiadu/main
refactor: replace HasPrefix+TrimPrefix with CutPrefix
2025-06-03 15:59:11 -06:00
Scott Rigby
e2630d1aba
Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex
fix: action hooks delete policy mutex
2025-06-03 15:04:57 -04:00
Scott Rigby
de745ea34b
Merge pull request #12581 from Nordix/considerAllGroupVersionKind
Consider full GroupVersionKind when matching resources
2025-06-03 15:02:18 -04:00
Scott Rigby
e8c1acf228
Merge pull request #30809 from mmorel-35/usetesting
chore: enable usetesting linter
2025-06-03 14:57:06 -04:00
Scott Rigby
4023c3b5ff
Merge pull request #30917 from TerryHowe/oci-transport-debugging
fix: add debug logging to oci transport
2025-06-01 18:12:15 -04:00
Robert Sirchia
f9ebe18dae
Merge pull request #30943 from helm/dependabot/github_actions/main/ossf/scorecard-action-2.4.2
build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2
2025-05-31 19:45:39 -04:00
dependabot[bot]
8706c441c4
build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](f49aabe0b5...05b42c6244)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-version: 2.4.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-30 21:34:15 +00:00
Matt Farina
be607c9ec7
Merge pull request #30937 from TerryHowe/legacy-docker-support
fix: legacy docker support broken for login
2025-05-30 15:36:14 -04:00
Terry Howe
a8cbf3aa51 fix: action hooks delete policy mutex
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-05-30 08:12:20 -04:00
Matthieu MOREL
56a2bb4188 chore: enable usetesting linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-05-30 08:12:11 +02:00
Terry Howe
6ab7aa3612 fix: legacy docker support broken for login
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-05-29 19:32:55 -04:00
Terry Howe
5fe7a87138 fix: add debug logging to oci transport
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
2025-05-29 07:12:06 -04:00
Robert Sirchia
de62ed1b2e
Merge pull request #30930 from benoittgt/30927-ci-fix
Fix flaky TestFindChartURL due to non-deterministic map iteration
2025-05-28 15:03:46 -04:00
Benoit Tigeot
6df8eb3b3b
Fix flaky TestFindChartURL due to non-deterministic map iteration
The test was failing intermittently because Go's map iteration order
is randomized (see `range repos` in `findChartUrl`).
When looking up the `baz` chart with repository URL http://example.com/helm,
two repositories match due to trailing slash equivalence:

- testing-relative (URL: http://example.com/helm) - contains baz chart GOOD
- testing-relative-trailing-slash (URL: http://example.com/helm/) - does not contain baz chart.. NOT GOOD

The urlutil.Equal() function treats these URLs as equivalent, but
depending on which repository the random map iterator encounters
first, the test would either pass or fail with "entry not found".

So I changed the third test case from baz to foo chart, since foo exists
in both matching repositories. This eliminates the race condition while
preserving all test expectations and logic.

`findChartURL()` iterates over a map without deterministic
ordering, causing the first-match-wins behavior to be non-deterministic
when multiple repositories match the same URL pattern.

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-05-28 19:02:42 +02:00
Scott Rigby
d4e58c54ba
Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet
fix: plugin installer test with no Internet
2025-05-28 10:27:56 -04:00
Terry Howe
cc39d2428f fix: plugin installer test with no Internet
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-05-27 13:34:37 -06:00
George Jenkins
01adbab466
Merge pull request #30914 from benoittgt/fix-30907
Fix dependabot upgrade of jsonschema to v6.0.2
2025-05-27 07:59:01 -07:00
Benoit Tigeot
b2fd91b8d0
Adapt error of invalid json schema with the new expected output
Closes: https://github.com/helm/helm/pull/30907

To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade
this test.

I am wondering if it's related to this commit:
86cca28795

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-05-26 09:44:02 +02:00
jinjiadu
6f8e9e09a4 refactor: replace HasPrefix+TrimPrefix with CutPrefix
Signed-off-by: jinjiadu <jinjiadu@aliyun.com>
2025-05-24 13:23:03 +08:00
dependabot[bot]
6638935d74
build(deps): bump github.com/santhosh-tekuri/jsonschema/v6
Bumps [github.com/santhosh-tekuri/jsonschema/v6](https://github.com/santhosh-tekuri/jsonschema) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/santhosh-tekuri/jsonschema/releases)
- [Commits](https://github.com/santhosh-tekuri/jsonschema/compare/v6.0.1...v6.0.2)

---
updated-dependencies:
- dependency-name: github.com/santhosh-tekuri/jsonschema/v6
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-23 21:48:49 +00:00
Robert Sirchia
39305fc160
Merge pull request #30905 from robertsirc/forward-port-30902
forward porting 30902
2025-05-23 16:33:39 -04:00
Robert Sirchia
b7e127dd6b
amending missed line to delete
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-05-23 16:22:39 -04:00
Robert Sirchia
937c533e37
forward porting 30902
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-05-23 16:19:03 -04:00
Robert Sirchia
52dddba759
Merge pull request #30894 from benoittgt/fix-#30881-main
Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store
2025-05-23 15:51:14 -04:00
Robert Sirchia
54eae46d1d
Merge pull request #30903 from helm/dependabot/go_modules/main/sigs.k8s.io/controller-runtime-0.21.0
build(deps): bump sigs.k8s.io/controller-runtime from 0.20.4 to 0.21.0
2025-05-23 08:09:34 -04:00
Robert Sirchia
83c26845ad
Merge pull request #30904 from benoittgt/document-ideal-registry-login-command
[Doc] Help users avoid specifying URL scheme and path with `helm registry`
2025-05-23 08:06:12 -04:00
Benoit Tigeot
f939f6145f
Prevent fetching newReference again as we have in calling method
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-05-23 11:49:55 +02:00
Benoit Tigeot
cb730c94b5
Help users avoid specifying URL scheme an path
We’ve noticed that some users still include the URL scheme and full path
when logging into an OCI registry, for example:

```sh
helm registry login -u $OCI_REGISTRY_USER --password-stdin oci://ghcr.io/org/repo
```

This is no longer necessary and will not be supported in Helm v4.

To guide users toward the correct usage, we should show an example of
the ideal command.

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-05-23 11:44:52 +02:00
dependabot[bot]
85ba33bb1d
build(deps): bump sigs.k8s.io/controller-runtime from 0.20.4 to 0.21.0
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.20.4 to 0.21.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.20.4...v0.21.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-22 21:32:21 +00:00
Robert Sirchia
1b21f04b3b
Merge pull request #30865 from mmorel-35/github.com/evanphx/json-patch/v5
fix: update json-patch import path and add gomodguard settings
2025-05-22 10:34:35 -04:00
Benoit Tigeot
875e149d6b
Prevent failure when resolving version tags in oras memory store
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.

I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.

Close: #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-05-21 21:38:44 +02:00
Robert Sirchia
707f1aee42
Merge pull request #30884 from mattfarina/revert-toml-change
Reverting fix "renders int as float"
2025-05-21 15:18:11 -04:00
Matt Farina
cf7613ba6b
Reverting fix "renders int as float"
This reverts #13533

This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.

The change caused a significant regression.

Note: This kind of change can be put into v3 charts, that are in
active development, without causing a regression.

Closes #30880

Signed-off-by: Matt Farina <matt@mattfarina.com>
2025-05-21 15:09:01 -04:00
Robert Sirchia
334045d002
Merge pull request #30882 from helm/add-lfx-insights
Add new LFX Insights Health Score Badge
2025-05-20 14:17:35 -04:00
Matt Farina
0c91649ec8
Merge pull request #30871 from gjenkins8/gjenkins/test_registry_localhost
Run test OCI registry localhost
2025-05-20 18:57:13 +01:00