Commit graph

94 commits

Author SHA1 Message Date
Matthieu MOREL
7edfff33eb chore: fix unnecessary-format issues from revive
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-23 07:07:27 +01:00
George Jenkins
610547b570
Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250
chore(pkg): fix perfsprint linter issues part 5
2026-03-13 19:00:01 -07:00
George Jenkins
df8e0301ed
Merge pull request #31878 from mmorel-35/perfsprint-pkg-3-39f7a9f
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
chore(pkg): fix perfsprint linter issues part 3
2026-03-02 07:28:25 -08:00
Matthieu MOREL
1d2d63cc43 chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:56 +01:00
Matthieu MOREL
c25c988cfb chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/registry

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Mads Jensen
36cb3a2fe9 Replace unneeded use of t.Fatalf with t.Fatal
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2026-02-26 18:18:57 +01:00
Matthieu MOREL
5b6c6bbfc7 fix: enable nolinlint linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-25 07:50:29 +01:00
George Jenkins
be7cdb69e5
Merge pull request #31806 from mmorel-35/errorlint-pkg-4-15f432a
fix(pkg): errorlint linter
2026-02-24 16:00:34 -08:00
George Jenkins
92b64e87ad
chore: fixes
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-02-23 16:46:35 -08:00
Matt Farina
794372e317
Merge pull request #31816 from mmorel-35/errorlint-pkg-7-6d6a660
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
govulncheck / govulncheck (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix(pkg): errorlint linter
2026-02-18 21:46:10 +01:00
Joe Julian
947b429cdd
Merge pull request #31801 from mmorel-35/modernize-pkg-4-062b248
chore(pkg): fix modernize linter
2026-02-10 21:42:25 -08:00
Joe Julian
78f5af72be
Merge pull request #31802 from mmorel-35/modernize-pkg-5-a3c8fdb
chore(pkg): fix modernize linter
2026-02-10 21:41:08 -08:00
Matthieu MOREL
259f76a849 fix(pkg): errorlint linter
errorlint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:54:59 +01:00
Matthieu MOREL
6d1490ed1e fix(pkg): errorlint linter
#### Description

errorlint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:41 +01:00
Matthieu MOREL
4d0ae7f33a fix(pkg): errorlint linter
#### Description

errorlint linter in pkg

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:34 +01:00
Matthieu MOREL
5cc2e55714 chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/chart/v2/lint/rules

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:11:01 +01:00
Matthieu MOREL
ba38159313 chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/strvals

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:10:54 +01:00
Matthieu MOREL
111d4e6e0e chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/chart/common/util

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:10:41 +01:00
Branch Vincent
c6d9a5bdc2 build: set kube version via debug.BuildInfo
Signed-off-by: Branch Vincent <branchevincent@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-12-19 21:13:47 -08:00
Mads Jensen
a490bb3c20 Use errors.Is to check for io.EOF and gzip.ErrHeader
In GoLang, using the == operator to check for a certain error will not
unwrap the error chain, and therefore may hide the problem.

Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-12-14 08:54:11 +01:00
Robert Sirchia
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
chore: fix some comments to improve readability
2025-12-12 19:34:20 +01:00
wangjingcun
858cf31583 chore: fix some comments to improve readability
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2025-12-12 12:01:35 +08:00
Mads Jensen
a18e59e465 Enable the sloglint linter
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-12-09 08:24:36 +01:00
Matt Farina
ff35414bed
Merge pull request #31546 from benoittgt/31544-nil-pointer
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix(lint): prevent segmentation violation on only comment yaml in multidoc
2025-12-01 09:15:14 -05:00
Benoit Tigeot
81d244ca21
fix: prevent segmentation violation on empty yaml in multidoc
Fixes: https://github.com/helm/helm/issues/31544

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-20 20:59:53 +01:00
Scott Rigby
b740071279
Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3
chore: replace github.com/mitchellh/copystructure
2025-11-14 15:26:10 -05:00
Matt Farina
15300549f0
When time not available, using time.Now
Note, when time is not available, the builds are not reproducible.
This problem would only happen when an SDK user is using parts of
the API to build their own tooling. Helm will consistently inject
the dates through the higher level APIs.

Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-29 15:11:20 -04:00
Matt Farina
ca8eae9361
Reproducible chart archive builds
Building the same chart into an archive multiple times will have
the same sha256 hash.

Perviously, the time in the headers for a file was time.Now() which
changed each time. The time is now collected from the operating
system when the file is loaded and this time is used.

Fixes: #3612

Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-29 11:49:22 -04:00
Matt Farina
37de51428c
Merge pull request #31376 from benoittgt/accept-yaml-yml
Do not ignore *.yml file on linting while accepting *.yaml
2025-10-21 15:23:40 -04:00
Benoit Tigeot
06188f9dfe
Add test for isYamlFileExtension functions
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-10-11 13:28:36 +02:00
Matt Farina
78cd44bd75
Merge pull request #30712 from gjenkins8/gjenkins/cleanup_lint_template
cleanup: Remove extra lint/rules.Template functions
2025-10-10 16:55:17 -04:00
Benoit Tigeot
4a944230ea
Do not ignore *.yml file on linting while accepting *.yaml
From : https://github.com/helm/helm/pull/30712/files#r2417446037

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-10-09 22:52:52 +02:00
Terry Howe
ee322a9671
fix: flakey lint test on shuffle
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-10-01 10:24:42 -06:00
Terry Howe
bee9c1a108
chore: replace github.com/mitchellh/copystructure
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-09-29 10:30:08 -06:00
George Jenkins
efcb5735e5 cleanup: Remove extra lint/rules.Template functions
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-09-21 11:49:33 -07:00
Matt Farina
8dc7c57f50
Update the action interfaces for chart apiversions
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.

Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-09-17 15:19:02 -04:00
Benoit Tigeot
072e2a689a
Extend --skip-schema-validation for lint command
When --skip-schema-validation is enabled, the lint command will now skip
JSON schema validation for values.yaml files, allowing charts with schema
validation errors to pass linting when the flag is used.

This addresses the gap where --skip-schema-validation only applied to
templates but not to values files, providing complete schema validation
bypass when needed.

Fixes: #13413

Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-09-10 15:23:05 +02:00
Kamil Swiechowski
a645dfb7f8 fix:semverv2 lint test error message
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
2025-09-05 13:10:41 +02:00
Kamil Swiechowski
38d1a7376f fix: throw warning when chart version is not semverv2
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
2025-09-03 07:49:41 +02:00
Matt Farina
9dcc49cbd5 Move lint pkg to be part of each chart version
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.

To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:

1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
   provide access to its data via an interface. There is an
   interface, factory, and implementation for each version of
   chart.
3. Common packages were moved to a common and util packages.
   Due to some package loops, there are 2 packages which may
   get some consolidation in the future.

The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.

Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-09-02 12:14:37 -04:00
Robert Sirchia
30404b4173
Merge pull request #31138 from islewis/release-3.18
fix(helm-lint): Add HTTP/HTTPS URL support for json schema references
2025-08-19 15:47:25 -04:00
Isaiah Lewis
62e0c78ef8
fix(helm-lint): fmt
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
2025-08-19 12:35:12 -07:00
Isaiah Lewis
fb12b44493
fix(helm-lint): Add TLSClientConfig
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
2025-08-18 11:35:59 -07:00
Isaiah Lewis
fa73b6743b
fix(helm-lint): Add HTTP/HTTPS URL support for json schema references
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
2025-08-15 07:31:30 -07:00
joemicky
fab70472af refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
Signed-off-by: joemicky <joemickychang@outlook.com>
2025-08-14 19:21:52 +08:00
Joe Julian
6ecf033700
Merge pull request #13111 from rawtaz/style-cosmetics
style(pkg/chartutil): add missing dots and indentation to defaultValues
2025-08-13 13:44:57 -07:00
Joe Julian
3fe1cb6f02
Merge remote-tracking branch 'upstream/main' into style-cosmetics 2025-08-13 13:22:35 -07:00
Matt Farina
0c64ad1c97
fix Chart.yaml handling
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-07-29 13:18:29 -04:00
Borys Hulii
9f6beaad48
fix: k8s version parsing to match original
Signed-off-by: Borys Hulii <borys.hulii@bitvavo.com>
2025-07-21 09:40:45 +02:00
yumeiyin
8c22fbfe4a refactor: replace Split in loops with more efficient SplitSeq
Signed-off-by: yumeiyin <yin.yumei@qq.com>
2025-07-14 16:21:15 +08:00