upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-28 04:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: enable nolinlint linter

Browse source 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This commit is contained in:
Matthieu MOREL 2026-02-25 07:47:53 +01:00
parent d275b925c4
commit 5b6c6bbfc7
8 changed files with 27 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
.golangci.yml
View file

@ -25,6 +25,7 @@ linters:
- ineffassign
- misspell
- nakedret
- nolintlint
- revive
- sloglint
- staticcheck
@ -67,6 +68,9 @@ linters:
dupl:
threshold: 400
exhaustive:
default-signifies-exhaustive: true
gomodguard:
blocked:
modules:
@ -74,8 +78,8 @@ linters:
recommendations:
- github.com/evanphx/json-patch/v5
exhaustive:
default-signifies-exhaustive: true
nolintlint:
require-specific: true
run:
timeout: 10m

2
internal/chart/v3/util/chartfile_test.go
View file

@ -35,7 +35,7 @@ func TestLoadChartfile(t *testing.T) {
func verifyChartfile(t *testing.T, f *chart.Metadata, name string) {
t.Helper()
if f == nil { //nolint:staticcheck
if f == nil {
t.Fatal("Failed verifyChartfile because f is nil")
}

2
internal/plugin/signing_info.go
View file

@ -23,7 +23,7 @@ import (
"path/filepath"
"strings"
"github.com/ProtonMail/go-crypto/openpgp/clearsign" //nolint
"github.com/ProtonMail/go-crypto/openpgp/clearsign"
"helm.sh/helm/v4/pkg/helmpath"
)

4
pkg/chart/v2/util/chartfile_test.go
View file

@ -35,11 +35,11 @@ func TestLoadChartfile(t *testing.T) {
func verifyChartfile(t *testing.T, f *chart.Metadata, name string) {
t.Helper()
if f == nil { //nolint:staticcheck
if f == nil {
t.Fatal("Failed verifyChartfile because f is nil")
}
if f.APIVersion != chart.APIVersionV1 { //nolint:staticcheck
if f.APIVersion != chart.APIVersionV1 {
t.Errorf("Expected API Version %q, got %q", chart.APIVersionV1, f.APIVersion)
}

20
pkg/getter/httpgetter_test.go
View file

@ -583,10 +583,10 @@ func verifyInsecureSkipVerify(t *testing.T, g *HTTPGetter, caseName string, expe
t.Fatal(err)
}
if returnVal == nil { //nolint:staticcheck
if returnVal == nil {
t.Fatalf("Expected non nil value for http client")
}
transport := (returnVal.Transport).(*http.Transport) //nolint:staticcheck
transport := (returnVal.Transport).(*http.Transport)
gotValue := false
if transport.TLSClientConfig != nil {
gotValue = transport.TLSClientConfig.InsecureSkipVerify
@ -607,11 +607,11 @@ func TestDefaultHTTPTransportReuse(t *testing.T) {
t.Fatal(err)
}
if httpClient1 == nil { //nolint:staticcheck
if httpClient1 == nil {
t.Fatalf("Expected non nil value for http client")
}
transport1 := (httpClient1.Transport).(*http.Transport) //nolint:staticcheck
transport1 := (httpClient1.Transport).(*http.Transport)
httpClient2, err := g.httpClient(g.opts)
@ -619,11 +619,11 @@ func TestDefaultHTTPTransportReuse(t *testing.T) {
t.Fatal(err)
}
if httpClient2 == nil { //nolint:staticcheck
if httpClient2 == nil {
t.Fatalf("Expected non nil value for http client")
}
transport2 := (httpClient2.Transport).(*http.Transport) //nolint:staticcheck
transport2 := (httpClient2.Transport).(*http.Transport)
if transport1 != transport2 {
t.Fatalf("Expected default transport to be reused")
@ -641,11 +641,11 @@ func TestHTTPTransportOption(t *testing.T) {
t.Fatal(err)
}
if httpClient1 == nil { //nolint:staticcheck
if httpClient1 == nil {
t.Fatalf("Expected non nil value for http client")
}
transport1 := (httpClient1.Transport).(*http.Transport) //nolint:staticcheck
transport1 := (httpClient1.Transport).(*http.Transport)
if transport1 != transport {
t.Fatalf("Expected transport option to be applied")
@ -657,11 +657,11 @@ func TestHTTPTransportOption(t *testing.T) {
t.Fatal(err)
}
if httpClient2 == nil { //nolint:staticcheck
if httpClient2 == nil {
t.Fatalf("Expected non nil value for http client")
}
transport2 := (httpClient2.Transport).(*http.Transport) //nolint:staticcheck
transport2 := (httpClient2.Transport).(*http.Transport)
if transport1 != transport2 {
t.Fatalf("Expected applied transport to be reused")

6
pkg/provenance/sign.go
View file

@ -25,9 +25,9 @@ import (
"os"
"strings"
"github.com/ProtonMail/go-crypto/openpgp" //nolint
"github.com/ProtonMail/go-crypto/openpgp/clearsign" //nolint
"github.com/ProtonMail/go-crypto/openpgp/packet" //nolint
"github.com/ProtonMail/go-crypto/openpgp"
"github.com/ProtonMail/go-crypto/openpgp/clearsign"
"github.com/ProtonMail/go-crypto/openpgp/packet"
"sigs.k8s.io/yaml"
)

4
pkg/provenance/sign_test.go
View file

@ -24,8 +24,8 @@ import (
"strings"
"testing"
pgperrors "github.com/ProtonMail/go-crypto/openpgp/errors" //nolint
"github.com/ProtonMail/go-crypto/openpgp/packet" //nolint
pgperrors "github.com/ProtonMail/go-crypto/openpgp/errors"
"github.com/ProtonMail/go-crypto/openpgp/packet"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"sigs.k8s.io/yaml"

4
pkg/repo/v1/repo_test.go
View file

@ -114,11 +114,11 @@ func TestRepoFile_Get(t *testing.T) {
name := "second"
entry := repo.Get(name)
if entry == nil { //nolint:staticcheck
if entry == nil {
t.Fatalf("Expected repo entry %q to be found", name)
}
if entry.URL != "https://example.com/second" { //nolint:staticcheck
if entry.URL != "https://example.com/second" {
t.Errorf("Expected repo URL to be %q but got %q", "https://example.com/second", entry.URL)
}