Commit graph

3776 commits

Author SHA1 Message Date
MrJack
42db90d9e8
Merge branch 'helm:main' into feature/rollback-revision-history 2026-04-03 09:54:56 +02:00
Debasish Mohanty
85bf56ea82
docs(registry): fix incorrect and improve clarity of comments in client.go
- Fixed incorrect comment in ClientOptPlainHTTP
- Improved clarity of LoginOptPlainText comment
- Enhanced Login function documentation
- Improved wording for ClientOptHTTPClient

No functional changes.

Signed-off-by: Debasish Mohanty <139056705+Debasish-87@users.noreply.github.com>
2026-03-27 11:54:38 +05:30
Terry Howe
8e44f8e3fe
Merge pull request #31957 from Mentigen/add-mustToToml
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
govulncheck / govulncheck (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
feat(engine): add mustToToml template function
2026-03-24 06:16:46 +01:00
Ilya Kiselev
c1a5a6e260 docs(engine): fix misleading toTOML doc comment
The toTOML doc comment said "returns empty string on marshal error"
but the implementation actually returns err.Error(). Fix the comment
to match the real behavior. Also mention mustToToml as the strict
alternative.

Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
2026-03-23 18:38:57 +03:00
Ilya Kiselev
b075f7a35d feat(engine): add mustToToml template function
Add `mustToToml` that panics on marshal error, consistent with
`mustToYaml` and `mustToJson`. This makes it possible for chart authors
to get a hard failure when TOML serialization fails, rather than having
to inspect the output manually.

`toToml` behavior is unchanged in this commit.

Closes #31430

Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
2026-03-23 18:20:54 +03:00
Matthieu MOREL
7edfff33eb chore: fix unnecessary-format issues from revive
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-23 07:07:27 +01:00
George Jenkins
42f78ba60e
Merge pull request #31872 from mmorel-35/perfsprint-pkg-6-5f845e3
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
chore(pkg): fix perfsprint linter issues part 6
2026-03-13 19:04:07 -07:00
George Jenkins
e3b4808450
Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58
chore(pkg): fix perfsprint linter issues part 4
2026-03-13 19:03:04 -07:00
George Jenkins
610547b570
Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250
chore(pkg): fix perfsprint linter issues part 5
2026-03-13 19:00:01 -07:00
MrJack
a753caca76
Merge branch 'helm:main' into feature/rollback-revision-history 2026-03-13 14:20:02 +01:00
George Jenkins
d3df72e560
Merge pull request #31932 from TerryHowe/fix/remove-legacy-import-comments-test-files
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
pkg/kube: remove legacy import comments from test files
2026-03-12 12:30:10 -07:00
Terry Howe
e64d628a13
fix(kube): remove legacy import comments from test files
Remove pre-Go modules import path comments from pkg/kube test files
(ready_test.go, resource_test.go, statuswait_test.go) for consistency
with the rest of the package.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2026-03-12 06:12:04 -06:00
abhay1999
d7cdc9e8fb pkg/kube: remove legacy import comments
Import path comments (e.g. `// import "helm.sh/helm/v4/pkg/kube"`) are
a pre-Go modules convention no longer needed in module-aware builds.
Some files in pkg/kube had these comments while others did not, causing
inconsistency that triggered downstream Kythe indexing errors.

Remove the import comments from all affected files to make the package
declaration consistent across the directory.

Fixes #31846

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
2026-03-12 11:10:44 +05:30
tsinglua
259f181808 chore: fix some minor issues in the comments
Signed-off-by: tsinglua <tsinglua@outlook.com>
2026-03-11 16:55:34 +08:00
Terry Howe
3e7b38fd04
Merge pull request #31868 from matheuscscp/fix-31867
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
govulncheck / govulncheck (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: insert newline after doc separators glued to content by template trimming
2026-03-09 12:30:56 -06:00
Matheus Pimenta
af94abf976
fix: insert newline after doc separators glued to content by template trimming
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-03-09 17:22:18 +00:00
MrJack
6927cde3f9 fix: address Copilot review feedback on rollback revision PR
- Clarify --show-rollback flag help text to specify it only affects table output
- Add RollbackRevision JSON round-trip tests for pkg/release/v1 and internal/release/v2
- Add omitempty behavior verification for zero rollback_revision

Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2026-03-09 15:43:27 +01:00
MrJack
e889cff089 feat(history): add --show-rollback flag for opt-in rollback column
Replace the always-visible ROLLBACK column with an opt-in --show-rollback
flag to avoid breaking the default table output (HIP-0004). JSON and YAML
formats continue to include rollback_revision when present via omitempty.

Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2026-03-09 09:45:04 +01:00
MrJack
9ea6b5ab99
Merge branch 'helm:main' into feature/rollback-revision-history 2026-03-09 09:34:26 +01:00
Matthieu MOREL
e31a078e6e
chore: enable modernize linter (#31860)
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-06 14:54:33 +00:00
MrJack
681ccb19a6
Update pkg/cmd/testdata/output/history-with-rollback.txt
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2026-03-05 13:45:55 +01:00
MrJack
0737e438aa
Update pkg/cmd/history_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2026-03-05 12:49:05 +01:00
MrJack
643e6d581d
Merge branch 'helm:main' into feature/rollback-revision-history 2026-03-05 09:01:22 +01:00
Travis Leeden
16573f87f5 Restored --atomic flag on install command
Signed-off-by: Travis Leeden <travis.leeden@octopus.com>
2026-03-04 15:53:35 +10:00
George Jenkins
df8e0301ed
Merge pull request #31878 from mmorel-35/perfsprint-pkg-3-39f7a9f
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
chore(pkg): fix perfsprint linter issues part 3
2026-03-02 07:28:25 -08:00
George Jenkins
4f9f18c453
Merge pull request #31875 from mmorel-35/perfsprint-pkg-2-0e1acbc
chore(pkg): fix perfsprint linter issues part 2
2026-03-02 07:26:50 -08:00
George Jenkins
c4392033cc
Merge pull request #31853 from atombrella/feature/fmt_unneeded
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
Replace non-format use of t.Fatalf with t.Fatal
2026-03-01 21:24:21 -08:00
Terry Howe
58f066b9a5
Merge pull request #31879 from mmorel-35/perfsprint-pkg-7-a389500
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
chore(pkg): fix perfsprint linter issues part 7
2026-02-28 08:00:55 -07:00
Matthieu MOREL
5d40f17011
Update pkg/cmd/status.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-28 11:11:02 +01:00
Matthieu MOREL
dc0e3f10c3 chore(pkg): fix perfsprint linter issues part 6
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 19:06:38 +01:00
Matthieu MOREL
e3c74fd9fa chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/storage/driver

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:56 +01:00
Matthieu MOREL
1d2d63cc43 chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:56 +01:00
Matthieu MOREL
63f03c0f5c chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/action

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Matthieu MOREL
c25c988cfb chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/registry

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Matthieu MOREL
0fecfd04c2 chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Matthieu MOREL
6c2cb2f547 chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Mads Jensen
36cb3a2fe9 Replace unneeded use of t.Fatalf with t.Fatal
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2026-02-26 18:18:57 +01:00
Matthieu MOREL
5b6c6bbfc7 fix: enable nolinlint linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-25 07:50:29 +01:00
Terry Howe
d275b925c4
Merge pull request #31852 from rohansood10/fix/31846-import-comment
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: correct import comment in statuswait.go from v3 to v4
2026-02-24 17:58:00 -07:00
George Jenkins
be7cdb69e5
Merge pull request #31806 from mmorel-35/errorlint-pkg-4-15f432a
fix(pkg): errorlint linter
2026-02-24 16:00:34 -08:00
George Jenkins
3dfc4f3cf6
Merge pull request #31858 from helm/gjenkins/go_fix
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
chore: `go fix` fixes
2026-02-24 15:35:00 -08:00
MrJack
d52b489459 Added missing pkg/cmd/testdata/output files
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2026-02-24 09:35:22 +01:00
MrJack
300f71b1eb feat(history): add rollback revision column to helm history output
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2026-02-24 09:33:53 +01:00
George Jenkins
3ad9ccdb19
Merge pull request #31563 from Mujib-Ahasan/dry-run-fix
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: --dry-run=server now respect generateName
2026-02-23 20:28:50 -08:00
George Jenkins
b667317422
fixup strings.Cut variables
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-02-23 19:17:02 -08:00
George Jenkins
92b64e87ad
chore: fixes
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-02-23 16:46:35 -08:00
rohansood10
c59c140ce0 fix: correct import comment in statuswait.go from v3 to v4
The import comment in pkg/kube/statuswait.go still referenced
helm.sh/helm/v3/pkg/kube while all other files in the package
correctly reference helm.sh/helm/v4/pkg/kube. This mismatch
causes downstream processing errors (e.g. kythe) when vendoring
Helm.

Fixes #31846

Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
2026-02-21 09:32:44 -08:00
Evans Mungai
ee018608f6
fix: handle OCI digest algorithm prefix in chart downloader (#31601)
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
* fix: strip digest algorithm prefix before hex decoding

OCI references with tag+digest (e.g., chart:1.0@sha256:abc...) failed with "invalid byte" error because the sha256: prefix was passed to hex.DecodeString().

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Add cmd test for OCI references with tag+digest

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Move oci registry push result to a struct

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Review comments from PR review

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Fix failing test

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

---------

Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-02-20 16:58:32 +00:00
Terry Howe
b26ec6b09e
Merge pull request #31566 from TerryHowe/fix-test-concurrency-download-index
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
fix: test concurrency download index
2026-02-19 11:06:41 -07:00
Matt Farina
794372e317
Merge pull request #31816 from mmorel-35/errorlint-pkg-7-6d6a660
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
govulncheck / govulncheck (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix(pkg): errorlint linter
2026-02-18 21:46:10 +01:00