Calvin Bui
abf2007685
Use length check for MetaDependencies instead of nil comparison
...
Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
(cherry picked from commit b33d4ae0c0 )
2026-01-14 17:33:30 -05:00
Benoit Tigeot
4b3de18628
Deal with golint warning with private executeShutdownFunc
...
```
Error: pkg/action/release_testing.go:60:57: unexported-return: exported method Run returns unexported type action.executeShutdownFunc, which can be annoying to use (revive)
func (r *ReleaseTesting) Run(name string) (ri.Releaser, executeShutdownFunc, error) {
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit 45c5f3aaca )
2026-01-14 17:01:55 -05:00
Benoit Tigeot
321277002a
Code review
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit 70fc5f97e2 )
2026-01-14 17:01:49 -05:00
Michelle Fernandez Bieber
6c838b4a18
Update pkg/action/hooks.go
...
Co-authored-by: Marco Lecheler <marco@task.media>
Signed-off-by: Michelle Fernandez Bieber <37021266+mfbieber@users.noreply.github.com>
(cherry picked from commit 6bb5bcc212 )
2026-01-14 17:01:41 -05:00
Michelle Fernandez Bieber
c5d87f2f7d
added check for nil shutdown
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
(cherry picked from commit d9301441f4 )
2026-01-14 17:01:37 -05:00
Michelle Fernandez Bieber
53175b76c7
cleaned up empty line
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
(cherry picked from commit 7a61ebf013 )
2026-01-14 17:01:32 -05:00
Michelle Fernandez Bieber
d2df1ab59e
updated comment and made defer of shutdown function return errors as before and not the possible shutdown error
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
(cherry picked from commit 10714772be )
2026-01-14 17:01:28 -05:00
Michelle Fernandez Bieber
5b223de7c8
added shutdown hook that is executed after the logs have been retrieved
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
(cherry picked from commit 7a557580e1 )
2026-01-14 17:01:24 -05:00
Hidde Beydals
e2021f8818
fix(rollback): errors.Is instead of string comp
...
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
(cherry picked from commit d158708fbf )
2026-01-14 16:51:38 -05:00
Hidde Beydals
af7c15303a
fix(uninstall): supersede deployed releases
...
This ensures that when `helm uninstall` is run with `--keep-history`
any release in a `deployed` state other than the last release (e.g.
due to a failed upgrade) is being marked as `superseded`.
As a by-effect, running `helm upgrade` on a release which has been
uninstalled after an upgrade failure now no longer works. But instead
fails with a `"<name>" has no deployed releases` error. Which is the
(likely) intended behavior, and prevents other side-effects like
rolling back to a release version which happened before the uninstall
if `--atomic` (or `--rollback-on-failure`) was provided.
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
(cherry picked from commit 2f1ecc7100 )
2026-01-14 16:51:38 -05:00
George Jenkins
12500dd401
Copy adopted resource info
...
build-test / build (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
(cherry picked from commit 855ebb6884 )
2025-11-24 08:57:30 -05:00
George Jenkins
9dfe3b35ec
fix: Use server-side apply for object create during update
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
(cherry picked from commit 18616e6ce9 )
2025-11-24 08:56:05 -05:00
Matt Farina
ca8eae9361
Reproducible chart archive builds
...
Building the same chart into an archive multiple times will have
the same sha256 hash.
Perviously, the time in the headers for a file was time.Now() which
changed each time. The time is now collected from the operating
system when the file is loaded and this time is used.
Fixes : #3612
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-29 11:49:22 -04:00
Scott Rigby
f4c5220d99
Merge pull request #31411 from banjoh/em/reinstate-logger-param
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
feat: reinstate logger parameter to actions package
2025-10-29 10:03:03 -04:00
Evans Mungai
2ddeb50fa6
Set default logger in Configuration constructor
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-23 18:09:58 +01:00
Evans Mungai
a112bf5aa6
Remove non-reachable code
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-23 09:53:25 +01:00
Robert Sirchia
25ad74f5a7
Merge pull request #31337 from rachelvweber/rawo/fixingWaitStrategy
...
Fixing rollback and uninstall client WaitStrategy
2025-10-22 15:40:33 -04:00
Evans Mungai
aed687eaa1
Add config options to NewConfiguration()
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 19:18:32 +01:00
Evans Mungai
b6eca1c0f1
Refactor logging functionality to use slog.Handler
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 15:26:48 +01:00
Evans Mungai
5ab4ca5490
Embed logging functionality to DRY code
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 13:55:12 +01:00
Evans Mungai
9c32e34d60
Add logger to sql driver and ensure storage has logger
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 13:29:37 +01:00
Evans Mungai
50e43f4017
nil logger should be handled by discard handler
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-22 00:40:03 +01:00
Evans Mungai
7a5816b106
Self review changes
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-21 23:53:09 +01:00
Evans Mungai
b1d4dc680d
feat: reinstate logger parameter to actions package
...
Fixes : #31399
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-10-21 22:48:51 +01:00
George Jenkins
7dd2484aed
Merge pull request #31295 from TerryHowe/fix-make-helm-list-show-all-by-default
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
Fix make helm list show all by default
2025-10-13 20:04:19 +01:00
Scott Rigby
f0530309f0
Merge pull request #31302 from TerryHowe/fix-helm-verify-signature
...
fix: helm verify Run signature
2025-10-13 14:38:21 -04:00
Terry Howe
c3aa5c51e6
chore: clean up for comments
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-10-13 10:28:44 -06:00
Terry Howe
8a73d97984
fix: make helm list show all by default
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-10-13 10:27:58 -06:00
Matt Farina
fbf02e494e
Merge pull request #30980 from gjenkins8/gjenkins/cleanup_kubeclient_interfaces
...
cleanup: Remove/consolidate redundant kube client Interfaces
2025-10-10 17:05:09 -04:00
Matt Farina
a229bf6529
Ensure the release interface is used in actions instead of the type
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-10 11:52:33 -04:00
Matt Farina
9c958dec76
Making uninstall response generic
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-10 11:49:08 -04:00
Matt Farina
f80cbe43d0
Moved release objects to enable versioning
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-10 11:49:08 -04:00
Matt Farina
2247a0074b
Move all the get commands to the new release interface
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-10 11:49:08 -04:00
Matt Farina
94bfe9ba12
Move action get metadata to chart interfaces
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-10-10 11:49:08 -04:00
George Jenkins
4877e2d7e9
Merge pull request #30833 from gjenkins8/gjenkins/refactor_dry_run_flag
...
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
refactor/cleanup: Replace action 'DryRun' string with DryRunStrategy type + deprecations
2025-10-09 13:29:29 -07:00
Robert Sirchia
acb1b2c651
Merge pull request #31354 from TerryHowe/fix-flake-upgrade-test
...
fix: flake upgrade test
2025-10-07 15:34:50 -04:00
George Jenkins
0adfe83ff8
Merge pull request #31227 from evankanderson/windows-filepath
...
Use filepath.Path when handling directory names
2025-10-02 17:41:41 -07:00
Terry Howe
a24318c7f1
fix: flake upgrade test
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-10-02 12:50:37 -06:00
Rachel Weber
472f8b2628
Fixing rollback and uninstall client WaitStrategy.
...
Signed-off-by: Rachel Weber <rawo@microsoft.com>
2025-09-25 18:09:12 -07:00
Terry Howe
9c7bf37c6f
fix: Ignore absolute path when RepoUrl is provided
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Mohammad Forutan <mforutan@users.noreply.github.com>
2025-09-24 17:01:44 -06:00
George Jenkins
561a7da61c
Merge pull request #31297 from TerryHowe/fix-hide-notes-in-helm-test
...
fix: hide notes in helm test command
2025-09-22 16:55:09 -07:00
George Jenkins
b5de5b1591
chore: Cleanup additional/redundant kube client Interfaces
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-09-21 11:37:16 -07:00
George Jenkins
f21b143bef
refactor: Replace action 'DryRun' string with DryRunStrategy type + deprecations
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-09-21 08:03:02 -07:00
Matt Farina
d2236e95ed
Merge pull request #31303 from mattfarina/unified-loader
...
Update the action interfaces for chart apiversions
2025-09-18 14:22:31 -06:00
Matt Farina
8dc7c57f50
Update the action interfaces for chart apiversions
...
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-09-17 15:19:02 -04:00
Terry Howe
020a8eccfd
fix: helm verify run signature
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-09-17 11:14:34 -06:00
Matt Farina
da595e0e71
Merge pull request #31293 from TerryHowe/copilot/fix-8
...
chore: remove pkg/time which is no longer needed
2025-09-16 13:35:13 -06:00
Terry Howe
dab4fd2909
fix: hide notes in helm test command
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-09-15 19:24:59 -06:00
Terry Howe
3e1dd9a5dc
chore: remove pkg/time which is no longer needed
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-09-15 12:29:35 -06:00
reddaisyy
1c67fbf108
refactor: use strings.builder
...
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
2025-09-15 17:13:58 +08:00