upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-28 04:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Self review changes

Browse source 
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
This commit is contained in:
Evans Mungai 2025-10-21 23:53:09 +01:00
parent 0f90c83118
commit 7a5816b106
No known key found for this signature in database
GPG key ID: BBEB812143DD14E1
7 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/action/action.go
View file

@ -530,7 +530,6 @@ func (cfg *Configuration) Init(getter genericclioptions.RESTClientGetter, namesp
case "sql":
d, err := driver.NewSQL(
os.Getenv("HELM_DRIVER_SQL_CONNECTION_STRING"),
cfg.Logger(),
namespace,
)
if err != nil {

2
pkg/kube/client.go
View file

@ -1204,7 +1204,7 @@ func (c *Client) Logger() *slog.Logger {
if lg := c.logger.Load(); lg != nil {
return lg
}
return slog.Default() // We rarely get here, just be defensive
return slog.Default() // We rarely get here, just being defensive
}
func (c *Client) SetLogger(newLogger *slog.Logger) {

2
pkg/storage/driver/cfgmaps.go
View file

@ -287,7 +287,7 @@ func (cfgmaps *ConfigMaps) Logger() *slog.Logger {
if lg := cfgmaps.logger.Load(); lg != nil {
return lg
}
return slog.Default() // We rarely get here, just be defensive
return slog.Default() // We rarely get here, just being defensive
}
func (cfgmaps *ConfigMaps) SetLogger(newLogger *slog.Logger) {

2
pkg/storage/driver/memory.go
View file

@ -258,7 +258,7 @@ func (mem *Memory) Logger() *slog.Logger {
if lg := mem.logger.Load(); lg != nil {
return lg
}
return slog.Default() // We rarely get here, just be defensive
return slog.Default() // We rarely get here, just being defensive
}
func (mem *Memory) SetLogger(newLogger *slog.Logger) {

2
pkg/storage/driver/secrets.go
View file

@ -284,7 +284,7 @@ func (secrets *Secrets) Logger() *slog.Logger {
if lg := secrets.logger.Load(); lg != nil {
return lg
}
return slog.Default() // We rarely get here, just be defensive
return slog.Default() // We rarely get here, just being defensive
}
func (secrets *Secrets) SetLogger(newLogger *slog.Logger) {

6
pkg/storage/driver/sql.go
View file

@ -280,7 +280,7 @@ type SQLReleaseCustomLabelWrapper struct {
}
// NewSQL initializes a new sql driver.
func NewSQL(connectionString string, logger *slog.Logger, namespace string) (*SQL, error) {
func NewSQL(connectionString string, namespace string) (*SQL, error) {
db, err := sqlx.Connect(postgreSQLDialect, connectionString)
if err != nil {
return nil, err
@ -296,7 +296,7 @@ func NewSQL(connectionString string, logger *slog.Logger, namespace string) (*SQ
}
driver.namespace = namespace
driver.SetLogger(logger)
driver.SetLogger(slog.Default())
return driver, nil
}
@ -712,7 +712,7 @@ func (s *SQL) Logger() *slog.Logger {
if lg := s.logger.Load(); lg != nil {
return lg
}
return slog.Default() // We rarely get here, just be defensive
return slog.Default() // We rarely get here, just being defensive
}
func (s *SQL) SetLogger(newLogger *slog.Logger) {

2
pkg/storage/storage.go
View file

@ -347,7 +347,7 @@ func (s *Storage) Logger() *slog.Logger {
if lg := s.logger.Load(); lg != nil {
return lg
}
return slog.Default() // We rarely get here, just be defensive
return slog.Default() // We rarely get here, just being defensive
}
func (s *Storage) SetLogger(newLogger *slog.Logger) {