Commit graph

256 commits

Author SHA1 Message Date
Robert Sirchia
6c3f397d2c
Merge pull request #32122 from quyentonndbs/chore/lint-deprecations-comment-typo
docs: fix typo in deprecated API godoc
2026-05-19 15:11:17 -04:00
Kai Tanaka
2032ec5cba docs: fix 'than'->'that' typo in deprecatedAPIError godoc
Signed-off-by: Kai Tanaka <275430420+quyentonndbs@users.noreply.github.com>
2026-05-12 14:12:03 +00:00
box4wangjing
432fc8a217 refactor: use slices.Backward to simplify the code
Signed-off-by: box4wangjing <box4wangjing@outlook.com>
2026-05-12 01:22:24 +08:00
George Jenkins
19b3656306
Bump to version v4.2 (#32102)
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-05-06 13:35:57 -04:00
Matheus Pimenta
a4a9cc7a31
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2026-04-25 17:06:10 +01:00
George Jenkins
4bd9e90aa0
Merge pull request #30811 from mmorel-35/testifylint
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
chore: fix bool-compare issues from testifylint
2026-04-24 21:35:35 -07:00
Evans Mungai
a8e249714f Update pkg/chart/common/util/coalesce.go
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-04-13 20:09:47 +02:00
Johannes Lohmer
52fc971da3 test(values): Add test for nil cleanup in partially overridden subchart maps
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
2026-04-13 20:09:47 +02:00
Johannes Lohmer
00638773d1 fix(values): do not copy chart-default nils into coalesced values
Only user-supplied nils should survive coalescing. Chart-default nils
defaults, not just user overrides. This caused:
- %!s(<nil>) in templates using Bitnami common.secrets.key (#31919)
- pluck fallbacks returning nil instead of falling through to globals
  (#31971)

Fixes #31919
Fixes #31971

Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
2026-04-13 20:09:47 +02:00
Johannes Lohmer
5cb4e7d992 test(values): add tests for subchart nil value regressions
Three test cases that cover the regression scenarios introduced
by the #31644 nil preservation fix:

- subchart default nils should be cleaned up
when parent doesn't set those keys (#31919)
- user-supplied null should erase subchart defaults (#31919)
- subchart default nil should not shadow global values via pluck (#31971)

Tests are expected to fail until the regression is fixed.

Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
2026-04-13 20:09:47 +02:00
George Jenkins
f7c4d75574
Merge commit from fork
fix: Chart dot-name path bug
2026-04-08 21:23:52 -07:00
Anmol Virdi
de58531ca7 Minor nit: fix import instructions to comply with canonical import paths
Signed-off-by: Anmol Virdi <anmolvirdi2000@gmail.com>
2026-04-07 01:23:50 +05:30
Matthieu MOREL
7edfff33eb chore: fix unnecessary-format issues from revive
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-23 07:07:27 +01:00
Matthieu MOREL
071558d69f chore: fix bool-compare issues from testifylint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-14 09:40:34 +01:00
George Jenkins
e3b4808450
Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58
chore(pkg): fix perfsprint linter issues part 4
2026-03-13 19:03:04 -07:00
George Jenkins
610547b570
Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250
chore(pkg): fix perfsprint linter issues part 5
2026-03-13 19:00:01 -07:00
George Jenkins
60184996e5
fix: Chart dot-name path bug
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-03-10 22:58:26 -07:00
George Jenkins
df8e0301ed
Merge pull request #31878 from mmorel-35/perfsprint-pkg-3-39f7a9f
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
chore(pkg): fix perfsprint linter issues part 3
2026-03-02 07:28:25 -08:00
Matthieu MOREL
1d2d63cc43 chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:56 +01:00
Matthieu MOREL
63f03c0f5c chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/action

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Matthieu MOREL
c25c988cfb chore(pkg): enable perfsprint linter
#### Description

enable perfsprint linter in pkg/registry

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Mads Jensen
36cb3a2fe9 Replace unneeded use of t.Fatalf with t.Fatal
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2026-02-26 18:18:57 +01:00
Matthieu MOREL
5b6c6bbfc7 fix: enable nolinlint linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-25 07:50:29 +01:00
George Jenkins
be7cdb69e5
Merge pull request #31806 from mmorel-35/errorlint-pkg-4-15f432a
fix(pkg): errorlint linter
2026-02-24 16:00:34 -08:00
George Jenkins
92b64e87ad
chore: fixes
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-02-23 16:46:35 -08:00
Evans Mungai
ee018608f6
fix: handle OCI digest algorithm prefix in chart downloader (#31601)
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
* fix: strip digest algorithm prefix before hex decoding

OCI references with tag+digest (e.g., chart:1.0@sha256:abc...) failed with "invalid byte" error because the sha256: prefix was passed to hex.DecodeString().

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Add cmd test for OCI references with tag+digest

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Move oci registry push result to a struct

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Review comments from PR review

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

* Fix failing test

Signed-off-by: Evans Mungai <mbuevans@gmail.com>

---------

Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-02-20 16:58:32 +00:00
Matt Farina
794372e317
Merge pull request #31816 from mmorel-35/errorlint-pkg-7-6d6a660
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
govulncheck / govulncheck (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix(pkg): errorlint linter
2026-02-18 21:46:10 +01:00
Joe Julian
947b429cdd
Merge pull request #31801 from mmorel-35/modernize-pkg-4-062b248
chore(pkg): fix modernize linter
2026-02-10 21:42:25 -08:00
Joe Julian
78f5af72be
Merge pull request #31802 from mmorel-35/modernize-pkg-5-a3c8fdb
chore(pkg): fix modernize linter
2026-02-10 21:41:08 -08:00
Joe Julian
7f9703fe22
Merge pull request #31811 from mmorel-35/errorlint-pkg-3-39f7a9f
fix(pkg): errorlint linter
2026-02-10 06:24:45 -08:00
Matthieu MOREL
259f76a849 fix(pkg): errorlint linter
errorlint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:54:59 +01:00
Matthieu MOREL
6d1490ed1e fix(pkg): errorlint linter
#### Description

errorlint linter in pkg/cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:41 +01:00
Matthieu MOREL
4d0ae7f33a fix(pkg): errorlint linter
#### Description

errorlint linter in pkg

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:34 +01:00
Matthieu MOREL
4330bdea04 fix(pkg): errorlint linter
#### Description

errorlint linter in pkg

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:25 +01:00
Matthieu MOREL
5cc2e55714 chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/chart/v2/lint/rules

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:11:01 +01:00
Matthieu MOREL
ba38159313 chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/strvals

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:10:54 +01:00
Matthieu MOREL
111d4e6e0e chore(pkg): fix modernize linter
#### Description

fix modernize linter in pkg/chart/common/util

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-06 16:10:41 +01:00
Evans Mungai
5b78ee8dff
Merge pull request #31644 from banjoh/em/fix-nil-values
Some checks failed
build-test / build (push) Has been cancelled
CodeQL / Analyze (push) Has been cancelled
golangci-lint / golangci-lint (push) Has been cancelled
release / release (push) Has been cancelled
release / canary-release (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
fix(values): preserve nil values when chart default is empty map
2026-01-31 13:03:55 +00:00
Evans Mungai
0298b2ffd0
Remove refactorring changes from coalesce_test.go
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-07 13:16:11 +00:00
Evans Mungai
b8937ad192
Fix import
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-07 12:58:21 +00:00
Evans Mungai
a333bbaf27
Update pkg/chart/common/util/coalesce_test.go
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2026-01-07 12:51:47 +00:00
Mads Jensen
2d6d9c09c4 Replace reflect.Ptr with reflect.Pointer
The reflect package has a go:fix annotation for Ptr = Pointer.

Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-12-31 10:05:43 +01:00
Branch Vincent
c6d9a5bdc2 build: set kube version via debug.BuildInfo
Signed-off-by: Branch Vincent <branchevincent@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-12-19 21:13:47 -08:00
Mads Jensen
a490bb3c20 Use errors.Is to check for io.EOF and gzip.ErrHeader
In GoLang, using the == operator to check for a certain error will not
unwrap the error chain, and therefore may hide the problem.

Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-12-14 08:54:11 +01:00
Robert Sirchia
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
chore: fix some comments to improve readability
2025-12-12 19:34:20 +01:00
Evans Mungai
3416dd5f21
Fix lint warning
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-12-12 17:09:18 +00:00
Evans Mungai
679f051980
Preserve nil values in chart already
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-12-12 17:00:18 +00:00
Evans Mungai
292fe70219
fix(values): preserve nil values when chart default is empty map
Only delete nil user values when overriding a non-nil chart default.
When chart has empty map or no default for a key, preserve user's nil.

| Scenario | Result |
|----------|--------|
| User sets `baz: ~`, chart has `baz: "value"` | Key deleted |
| User sets `baz: ~`, chart has empty map `{}` | Nil preserved |
| User sets `baz: ~`, chart has `baz: ~` | Nil preserved |

Fixes #31643

Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-12-12 16:32:32 +00:00
Terry Howe
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
Some checks are pending
build-test / build (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
golangci-lint / golangci-lint (push) Waiting to run
govulncheck / govulncheck (push) Waiting to run
release / release (push) Waiting to run
release / canary-release (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
Enable the `sloglint` linter
2025-12-12 08:04:45 -07:00
wangjingcun
858cf31583 chore: fix some comments to improve readability
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2025-12-12 12:01:35 +08:00