upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-06-05 14:54:24 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
certbot/AUTHORS.md
Lorenzo Fundaró d714ccec05
Fix fetch of existing records from Google DNS (#8521) 
* Fix fetch of existing records from Google DNS

There has been many complaints regarding `certbot_dns_google` plugin
failing with:
   * HTTP 412 - Precondition not met
   * HTTP 409 - Conflict
See #6036. This PR fixes that situation. The bug lies on how we
fetch the TXT records from google. For large amount of records
the Google API paginates the result but we ignore the subsequent
pages and assume that if the record is not in the first response then
it doesn't exist. This leads to either HTTP 409, or HTTP 412 or both.
In this PR we leverage the use of filters on the API to get exactly
the records we are looking for. Apart from fixing the problem stated
above, it has the extra benefit of making the process faster by
reducing the amount of API calls and it doesn't require us to handle
any pagination logic

* Explain changes on CHANGELOG

* Edit AUTHORS.md

* make execute static

* Update certbot/CHANGELOG.md

Being more specific for which plugin this fix bug is meant for.

Co-authored-by: alexzorin <alex@zor.io>

* Fix if expression to be more python-idiomatic

Co-authored-by: alexzorin <alex@zor.io>

* Sort AUTHORS.md

* Simplify tests

Make rrs_mock modeling simpler and refactor

* Revert "Simplify tests"

This reverts commit 9de9623ba7.

* Reimplement conditional mock

We still want to use a conditional mock by make it more
simple to understand by using MagicMock.

* Revert "Sort AUTHORS.md"

This reverts commit b3aa35bcf1.

* Add name in AUTHORS.md

Co-authored-by: alexzorin <alex@zor.io>
2020-12-17 21:22:12 +11:00

282 lines
13 KiB
Markdown
Raw Permalink Blame History

Authors
=======
* [Aaron Zirbes](https://github.com/aaronzirbes)
* Aaron Zuehlke
* Ada Lovelace
* [Adam Woodbeck](https://github.com/awoodbeck)
* [Adrien Ferrand](https://github.com/adferrand)
* [Aidin Gharibnavaz](https://github.com/aidin36)
* [AJ ONeal](https://github.com/coolaj86)
* [Alcaro](https://github.com/Alcaro)
* [Alexander Mankuta](https://github.com/pointlessone)
* [Alex Bowers](https://github.com/alexbowers)
* [Alex Conlin](https://github.com/alexconlin)
* [Alex Gaynor](https://github.com/alex)
* [Alex Halderman](https://github.com/jhalderm)
* [Alex Jordan](https://github.com/strugee)
* [Alex Zorin](https://github.com/alexzorin)
* [Amjad Mashaal](https://github.com/TheNavigat)
* [Andrew Murray](https://github.com/radarhere)
* [Andrzej Górski](https://github.com/andrzej3393)
* [Anselm Levskaya](https://github.com/levskaya)
* [Antoine Jacoutot](https://github.com/ajacoutot)
* [April King](https://github.com/april)
* [asaph](https://github.com/asaph)
* [Axel Beckert](https://github.com/xtaran)
* [Bas](https://github.com/Mechazawa)
* [benbankes](https://github.com/benbankes)
* [Ben Irving](https://github.com/benileo)
* [Benjamin Kerensa](https://github.com/bkerensa)
* [Benjamin Neff](https://github.com/SuperTux88)
* [Benjamin Piouffle](https://github.com/Betree)
* [Ben Ubois](https://github.com/benubois)
* [Ben Wolfe](https://github.com/bwolfe)
* [Bigfish](https://github.com/bwolfe)
* [Blake Griffith](https://github.com/cowlicks)
* [Brad Warren](https://github.com/bmw)
* [Brandon Kraft](https://github.com/kraftbj)
* [Brandon Kreisel](https://github.com/BKreisel)
* [Brian Heim](https://github.com/brianlheim)
* [Cameron Steel](https://github.com/Tugzrida)
* [Ceesjan Luiten](https://github.com/quinox)
* [Chad Whitacre](https://github.com/whit537)
* [Chhatoi Pritam Baral](https://github.com/pritambaral)
* [Chris Johns](https://github.com/ter0)
* [Chris Lamb](https://github.com/lamby)
* [chrismarget](https://github.com/chrismarget)
* [Christian Gärtner](https://github.com/ChristianGaertner)
* [Christian Rosentreter](https://github.com/the-real-tokai)
* [Christopher Brown](https://github.com/chbrown)
* [Christopher Manning](https://github.com/christophermanning)
* [Christoph Kisfeld](https://github.com/chk1)
* [Clif Houck](https://github.com/ClifHouck)
* [Cooper Quintin](https://github.com/cooperq)
* [Corey Farwell](https://github.com/frewsxcv)
* [Craig Smith](https://github.com/dashaxiong)
* [Damian Poddebniak](https://github.com/duesee)
* [Damien Nozay](https://github.com/dnozay)
* [Damien Tournoud](https://github.com/damz)
* [DanCld](https://github.com/DanCld)
* [Daniel Albers](https://github.com/AID)
* [Daniel Aleksandersen](https://github.com/da2x)
* [Daniel Convissor](https://github.com/convissor)
* [Daniel "Drex" Drexler](https://github.com/aeturnum)
* [Daniel Huang](https://github.com/dhuang)
* [Dave Guarino](https://github.com/daguar)
* [David cz](https://github.com/dave-cz)
* [David Dworken](https://github.com/ddworken)
* [David Kreitschmann](https://kreitschmann.de)
* [David Xia](https://github.com/davidxia)
* [Devin Howard](https://github.com/devvmh)
* [dokazaki](https://github.com/dokazaki)
* [Dominic Cleal](https://github.com/domcleal)
* [Dominic Lüchinger](https://github.com/dol)
* [Douglas José](https://github.com/douglasjose)
* [Erica Portnoy](https://github.com/ohemorange)
* [Eric Engestrom](https://github.com/1ace)
* [Eric Rescorla](https://github.com/ekr)
* [Eric Wustrow](https://github.com/ewust)
* [Erik Rose](https://github.com/erikrose)
* [Eugene Kazakov](https://github.com/xgin)
* [Fabian](https://github.com/faerbit)
* [Faidon Liambotis](https://github.com/paravoid)
* [Fan Jiang](https://github.com/tcz001)
* [Felix Lechner](https://github.com/lechner)
* [Felix Schwarz](https://github.com/FelixSchwarz)
* [Felix Yan](https://github.com/felixonmars)
* [Filip Ochnik](https://github.com/filipochnik)
* [Florian Klink](https://github.com/flokli)
* [Francois Marier](https://github.com/fmarier)
* [Frank](https://github.com/Frankkkkk)
* [Frederic BLANC](https://github.com/fblanc)
* [Garrett Robinson](https://github.com/garrettr)
* [Gene Wood](https://github.com/gene1wood)
* [Geoffroy Doucet](https://www.geoffroydoucet.com)
* [Gian Carlo Pace](https://github.com/gicappa)
* [Gilles Pietri](https://github.com/gilou)
* [Giovanni Pellerano](https://github.com/evilaliv3)
* [Giovanni Toraldo](https://github.com/gionn)
* [Gordin](https://github.com/Gordin)
* [Gregor Dschung](https://github.com/chkpnt)
* [Gregory L. Dietsche](https://github.com/farmergreg)
* [Greg Osuri](https://github.com/gosuri)
* [Guillaume Boudreau](https://github.com/gboudreau)
* [Harlan Lieberman-Berg](https://github.com/hlieberman)
* [Henri Salo](https://github.com/fgeek)
* [Henry Chen](https://github.com/henrychen95)
* [Hugo van Kemenade](https://github.com/hugovk)
* [Ingolf Becker](https://github.com/watercrossing)
* [Ivan Nejgebauer](https://github.com/inejge)
* [Jaap Eldering](https://github.com/eldering)
* [Jacob Hoffman-Andrews](https://github.com/jsha)
* [Jacob Sachs](https://github.com/jsachs)
* [Jairo Llopis](https://github.com/Yajo)
* [Jakub Warmuz](https://github.com/kuba)
* [James Kasten](https://github.com/jdkasten)
* [Jason Grinblat](https://github.com/ptychomancer)
* [Jay Faulkner](https://github.com/jayofdoom)
* [J.C. Jones](https://github.com/jcjones)
* [Jeff Hodges](https://github.com/jmhodges)
* [Jeremy Gillula](https://github.com/jgillula)
* [Jeroen Ketelaar](https://github.com/JKetelaar)
* [Jeroen Pluimers](https://github.com/jpluimers)
* [j](https://github.com/bit)
* [Jim Tittsler](https://github.com/jimt)
* [Joe Ranweiler](https://github.com/ranweiler)
* [Joerg Sonnenberger](https://github.com/jsonn)
* [John Leach](https://github.com/johnl)
* [John Reed](https://github.com/leerspace)
* [Jonas Berlin](https://github.com/xkr47)
* [Jonathan Herlin](https://github.com/Jonher937)
* [Jon Walsh](https://github.com/code-tree)
* [Joona Hoikkala](https://github.com/joohoi)
* [Josh McCullough](https://github.com/JoshMcCullough)
* [Josh Soref](https://github.com/jsoref)
* [Joubin Jabbari](https://github.com/joubin)
* [Juho Juopperi](https://github.com/jkjuopperi)
* [Kane York](https://github.com/riking)
* [Kenichi Maehashi](https://github.com/kmaehashi)
* [Kenneth Skovhede](https://github.com/kenkendk)
* [Kevin Burke](https://github.com/kevinburke)
* [Kevin London](https://github.com/kevinlondon)
* [Kubilay Kocak](https://github.com/koobs)
* [LeCoyote](https://github.com/LeCoyote)
* [Lee Watson](https://github.com/TheReverend403)
* [Leo Famulari](https://github.com/lfam)
* [lf](https://github.com/lf-)
* [Liam Marshall](https://github.com/liamim)
* [Lior Sabag](https://github.com/liorsbg)
* [Lipis](https://github.com/lipis)
* [lord63](https://github.com/lord63)
* [Lorenzo Fundaró](https://github.com/lfundaro)
* [Luca Beltrame](https://github.com/lbeltrame)
* [Luca Ebach](https://github.com/lucebac)
* [Luca Olivetti](https://github.com/olivluca)
* [Luke Rogers](https://github.com/lukeroge)
* [Maarten](https://github.com/mrtndwrd)
* [Mads Jensen](https://github.com/atombrella)
* [Maikel Martens](https://github.com/krukas)
* [Malte Janduda](https://github.com/MalteJ)
* [Mantas Mikulėnas](https://github.com/grawity)
* [Marcel Krüger](https://github.com/zauguin)
* [Marcos Caceres](https://github.com/marcoscaceres)
* [Marek Viger](https://github.com/freezy-sk)
* [Mario Villaplana](https://github.com/supermari0)
* [Marius Gedminas](https://github.com/mgedmin)
* [Martey Dodoo](https://github.com/martey)
* [Martijn Bastiaan](https://github.com/martijnbastiaan)
* [Martijn Braam](https://github.com/MartijnBraam)
* [Martin Brugger](https://github.com/mbrugger)
* [Mathieu Leduc-Hamel](https://github.com/mlhamel)
* [Matt Bostock](https://github.com/mattbostock)
* [Matthew Ames](https://github.com/SuperMatt)
* [Michael Schumacher](https://github.com/schumaml)
* [Michael Strache](https://github.com/Jarodiv)
* [Michael Sverdlin](https://github.com/sveder)
* [Michael Watters](https://github.com/blackknight36)
* [Michal Moravec](https://github.com/https://github.com/Majkl578)
* [Michal Papis](https://github.com/mpapis)
* [Mickaël Schoentgen](https://github.com/BoboTiG)
* [Minn Soe](https://github.com/MinnSoe)
* [Min RK](https://github.com/minrk)
* [Miquel Ruiz](https://github.com/miquelruiz)
* [Môshe van der Sterre](https://github.com/moshevds)
* [mrstanwell](https://github.com/mrstanwell)
* [Nav Aulakh](https://github.com/Nav)
* [Nelson Elhage](https://github.com/nelhage)
* [Nick Fong](https://github.com/nickfong)
* [Nick Le Mouton](https://github.com/NoodlesNZ)
* [Nikos Roussos](https://github.com/comzeradd)
* [Noah Swartz](https://github.com/swartzcr)
* [Ola Bini](https://github.com/olabini)
* [Ondřej Súkup](https://github.com/mimi1vx)
* [Ondřej Surý](https://github.com/oerdnj)
* [osirisinferi](https://github.com/osirisinferi)
* Patrick Figel
* [Patrick Heppler](https://github.com/PatrickHeppler)
* [Paul Feitzinger](https://github.com/pfeyz)
* [Pavan Gupta](https://github.com/pavgup)
* [Pavel Pavlov](https://github.com/ghost355)
* [Peter Conrad](https://github.com/pconrad-fb)
* [Peter Eckersley](https://github.com/pde)
* [Peter Mosmans](https://github.com/PeterMosmans)
* [Philippe Langlois](https://github.com/langloisjp)
* [Philipp Spitzer](https://github.com/spitza)
* [Piero Steinger](https://github.com/Jadaw1n)
* [Pierre Jaury](https://github.com/kaiyou)
* [Piotr Kasprzyk](https://github.com/kwadrat)
* [Prayag Verma](https://github.com/pra85)
* [Rasesh Patel](https://github.com/raspat1)
* [Reinaldo de Souza Jr](https://github.com/juniorz)
* [Remi Rampin](https://github.com/remram44)
* [Rémy HUBSCHER](https://github.com/Natim)
* [Rémy Léone](https://github.com/sieben)
* [Richard Barnes](https://github.com/r-barnes)
* [Richard Panek](https://github.com/kernelpanek)
* [Robert Buchholz](https://github.com/rbu)
* [Robert Dailey](https://github.com/pahrohfit)
* [Robert Habermann](https://github.com/frennkie)
* [Robert Xiao](https://github.com/nneonneo)
* [Roland Shoemaker](https://github.com/rolandshoemaker)
* [Roy Wellington Ⅳ](https://github.com/thanatos)
* [rugk](https://github.com/rugk)
* [Sachi King](https://github.com/nakato)
* [Sagi Kedmi](https://github.com/sagi)
* [Sam Lanning](https://github.com/samlanning)
* [sapics](https://github.com/sapics)
* [Scott Barr](https://github.com/scottjbarr)
* [Scott Merrill](https://github.com/skpy)
* [Sebastian Bögl](https://github.com/TheBoegl)
* [Sebastian Wagner](https://github.com/sebix)
* [sedrubal](https://github.com/sedrubal)
* [Seppe Stas](https://github.com/seppestas)
* [Sergey Nuzdhin](https://github.com/lwolf)
* [Seth Schoen](https://github.com/schoen)
* [Sharif Nassar](https://github.com/mrwacky42)
* [Shaun Cummiskey](https://github.com/ampersign)
* [Shiloh Heurich](https://github.com/sheurich)
* [silverwind](https://github.com/silverwind)
* [Sorvani](https://github.com/sorvani)
* [Spencer Bliven](https://github.com/sbliven)
* [Stacey Sheldon](https://github.com/solidgoldbomb)
* [Stavros Korokithakis](https://github.com/skorokithakis)
* [Ștefan Talpalaru](https://github.com/stefantalpalaru)
* [Stefan Weil](https://github.com/stweil)
* [Steve Desmond](https://github.com/stevedesmond-ca)
* [sydneyli](https://github.com/sydneyli)
* [taixx046](https://github.com/taixx046)
* [Tan Jay Jun](https://github.com/jayjun)
* [Tapple Gao](https://github.com/tapple)
* [Telepenin Nikolay](https://github.com/telepenin)
* [Thomas Cottier](https://github.com/tcottier-enalean)
* [Thomas Mayer](https://github.com/thomaszbz)
* [Thomas Waldmann](https://github.com/ThomasWaldmann)
* [Thom Wiggers](https://github.com/thomwiggers)
* [Till Maas](https://github.com/tyll)
* [Timothy Guan-tin Chien](https://github.com/timdream)
* [Torsten Bögershausen](https://github.com/tboegi)
* [Travis Raines](https://github.com/rainest)
* [Trung Ngo](https://github.com/Ngo-The-Trung)
* [Valentin](https://github.com/e00E)
* [venyii](https://github.com/venyii)
* [Viktor Szakats](https://github.com/vszakats)
* [Ville Skyttä](https://github.com/scop)
* [Vinney Cavallo](https://github.com/vcavallo)
* [Vladimir Rutsky](https://github.com/rutsky)
* [Wang Yu](https://github.com/wyhitcs)
* [Ward Vandewege](https://github.com/cure)
* [Whyfoo](https://github.com/whyfoo)
* [Wilfried Teiken](https://github.com/wteiken)
* [Willem Fibbe](https://github.com/fibbers)
* [William Budington](https://github.com/Hainish)
* [Will Newby](https://github.com/willnewby)
* [Will Oller](https://github.com/willoller)
* [Yan](https://github.com/diracdeltas)
* [Yen Chi Hsuan](https://github.com/yan12125)
* [Yomna](https://github.com/ynasser)
* [Yoni Jah](https://github.com/yonjah)
* [YourDaddyIsHere](https://github.com/YourDaddyIsHere)
* [Yuseong Cho](https://github.com/g6123)
* [Zach Shepherd](https://github.com/zjs)
* [陈三](https://github.com/chenxsan)
Reference in a new issue View git blame Copy permalink