upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-06-06 15:22:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
certbot/certbot-dns-digitalocean
History
Brad Warren e066766cc9
Revert "Disable build isolation during snap dns plugins build (#8319)" (#8323) 
This reverts commit feca125437.

Since this change landed, ARM builds for many of the DNS plugins have failed every night. See https://dev.azure.com/certbot/certbot/_build?definitionId=5 or our public Mattermost channel.

I quickly tried to fix this myself and wasn't trivially able to do so. I tried setting `SNAPCRAFT_PYTHON_VENV_ARGS: --system-site-packages` and adding `python3-wheel` as a build dependency, but it didn't work for some reason. The `python3-wheel` package didn't seem to be installed.

I still suspect something like this is the approach we should take, however, I want to fix the failing tests now so things are no longer broken in `master` and those of us on the Certbot team at EFF stop getting spammed with 54 (!!) emails about failed builds from launchpad every night.

Unfortunately, while I was working on this the queue for ARM machines on Launchpad jumped up to an estimated ~20 hour wait, but I confirmed that this fixes the problem by building on an ARM AMI using the instructions at https://github.com/certbot/certbot/blob/master/tools/snap/README.md#use-testing-and-development. If whoever reviews this would like an ARM machine to test on themselves, please let me know.
2020-09-28 14:27:29 -07:00
..
certbot_dns_digitalocean Remove useless pylint error suppression directives (#7657) 2020-02-13 13:56:16 -08:00
docs Convert http links to https (#8287) 2020-09-23 19:36:55 +02:00
snap Revert "Disable build isolation during snap dns plugins build (#8319)" (#8323) 2020-09-28 14:27:29 -07:00
tests Do not require mock in Python 3 in certbot-dns modules (#7900) 2020-04-15 11:54:44 -07:00
LICENSE.txt DigitalOcean DNS Authenticator 2017-05-11 17:26:02 -07:00
local-oldest-requirements.txt Release 1.1.0 2020-01-14 10:52:03 -08:00
MANIFEST.in Refactor tests out of packaged module for dns plugins (#7599) 2019-11-26 15:25:28 -08:00
README.rst DigitalOcean DNS Authenticator 2017-05-11 17:26:02 -07:00
readthedocs.org.requirements.txt Refactor certbot/ and certbot/tests/ to use the same structure as the other packages (#7544) 2019-11-25 14:28:05 -08:00
setup.cfg DigitalOcean DNS Authenticator 2017-05-11 17:26:02 -07:00
setup.py Remove deprecated python setup.py test call and update packager guide (#8262) 2020-09-10 15:57:59 -07:00

README.rst 

DigitalOcean DNS Authenticator plugin for Certbot