upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-06-09 08:42:57 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Revert "Disable build isolation during snap dns plugins build (#8319)" (#8323)

Browse source 
This reverts commit feca125437.

Since this change landed, ARM builds for many of the DNS plugins have failed every night. See https://dev.azure.com/certbot/certbot/_build?definitionId=5 or our public Mattermost channel.

I quickly tried to fix this myself and wasn't trivially able to do so. I tried setting `SNAPCRAFT_PYTHON_VENV_ARGS: --system-site-packages` and adding `python3-wheel` as a build dependency, but it didn't work for some reason. The `python3-wheel` package didn't seem to be installed.

I still suspect something like this is the approach we should take, however, I want to fix the failing tests now so things are no longer broken in `master` and those of us on the Certbot team at EFF stop getting spammed with 54 (!!) emails about failed builds from launchpad every night.

Unfortunately, while I was working on this the queue for ARM machines on Launchpad jumped up to an estimated ~20 hour wait, but I confirmed that this fixes the problem by building on an ARM AMI using the instructions at https://github.com/certbot/certbot/blob/master/tools/snap/README.md#use-testing-and-development. If whoever reviews this would like an ARM machine to test on themselves, please let me know.
This commit is contained in:
Brad Warren 2020-09-28 14:27:29 -07:00 committed by GitHub
parent be6c890874
commit e066766cc9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
certbot-dns-cloudflare/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-cloudxns/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-digitalocean/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-dnsimple/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-dnsmadeeasy/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-gehirn/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-google/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-linode/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-luadns/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-nsone/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-ovh/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-rfc2136/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-route53/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
certbot-dns-sakuracloud/snap/snapcraft.yaml
View file

@ -17,7 +17,6 @@ parts:
snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata:

1
tools/snap/generate_dnsplugins_snapcraft.sh
View file

@ -29,7 +29,6 @@ parts:
snapcraftctl set-version \`grep ^version \$SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"\`
build-environment:
- SNAP_BUILD: "True"
- PIP_NO_BUILD_ISOLATION: "no"
# To build cryptography and cffi if needed
build-packages: [gcc, libffi-dev, libssl-dev, python3-dev]
certbot-metadata: