Commit graph

7618 commits

Author SHA1 Message Date
Brad Warren
372d201111 use say now that if QUIET statement was moved (#4530) 2017-04-19 14:11:18 -07:00
Josh Soref
c13b2eae9b Make it easier to honor --quiet (#4292)
* say -- echo which honors quiet

* error -- echo which does not honor quiet

* switch non error echos to say

* switch error echos to error

* run letsencrypt-auto-source/build.py
2017-04-19 09:11:38 -07:00
Jacob Hoffman-Andrews
d54cb3c59d Improve Account.repr() (#4325)
* Include more detail in Account's repr.

In particular, regr and meta.

* Fix test.

* Review feedback.

* Lint

* Test prefix only.
2017-04-18 17:09:22 -07:00
Arthur Gautier
b0600483fd interface: IConfig is missing fields used in client.py (#4453)
Signed-off-by: Arthur Gautier <baloo@gandi.net>
2017-04-18 11:18:56 -07:00
Brad Warren
36891033dd Set HOME if it's not defined in certbot-auto (#4503)
* set HOME if it's not defined

* use ~root rather than /root
2017-04-17 14:39:08 -07:00
Noah Swartz
2bdf8cf505 Merge pull request #4492 from certbot/changelog_cleanup
fixed up the changelog
2017-04-17 13:38:55 -07:00
Noah Swartz
4c0e82f426 fix typo 2017-04-17 13:12:46 -07:00
Peter Eckersley
1ed50497eb [certbot-auto]: "renew" implies --non-interactive (#4500) 2017-04-17 11:41:24 -07:00
Erica Portnoy
ba0ac03205 Merge pull request #4374 from yan12125/py3-enable-boulder
This enables boulder integration tests for all Python 3 versions on Travis CI as well as fixes bugs identified by integration tests.
2017-04-14 12:58:29 -07:00
Noah Swartz
227743b7e4 Merge pull request #4459 from St-Ranger/patch-1
Improved info for FreeBSD
2017-04-14 11:46:08 -07:00
Yen Chi Hsuan
031a8dd837 Fix nginx integration tests on Python 3 2017-04-15 02:34:06 +08:00
Yen Chi Hsuan
29d25f0915 Enable boulder tests on Python 3 2017-04-15 02:32:18 +08:00
Carl Michael Skog
f54280d9b9 Use binary flag when writing cert and key files (#4462)
* Use binary flag when writing cert and key files

Add binary flag to mode argument when opening files for writing key and
certificate files.
On Python 3 the data buffers use for writing are bytes objects not
strings, and the write fails accordingly.
As far as I understand, it the "b" flag will not hurt things in Python 2
either.

* Update the tests for RenewableCert::save_successor

Update the tests for RenewableCert::save_successor after changing
three  parameters to be called with bytes objects instead of strings.

Also, update the doc comment of the function.
2017-04-13 19:10:12 -07:00
St-Ranger
d11443ac05 Missing word is inserted. 2017-04-13 20:36:32 -05:00
Noah Swartz
8fea513dec Merge pull request #4455 from zjs/topic/zjs/developer-guide
Documentation improvements for plugin developers
2017-04-13 16:54:51 -07:00
Noah Swartz
1ff117e2ec Merge pull request #4458 from truist/patch-1
Sort OS-with-packages list and add NetBSD
2017-04-13 16:31:03 -07:00
Noah Swartz
6d0591f0db Merge pull request #4457 from Robotic-Brain/patch-2
Fixing Typo in README.rst (issues -> issued)
2017-04-13 15:25:22 -07:00
Noah Swartz
71decfb773 Merge pull request #4456 from Robotic-Brain/patch-1
Fixing Typo in Readme.rst (identify -> identity)
2017-04-13 15:24:55 -07:00
Brad Warren
bd8c31021a Logging setup before argument parsing (#4446)
Second part of #4443. Built on #4444. Fixes #3148.

This fixes an old problem with code logging messages before logging has been set up. How this works is explained in the docstring of certbot.log.pre_arg_setup.

* add memory handler

* Add exit_with_log_path

* add new_except_hook

* pre_arg_parse_setup++ and remove old except_hook

* Rewrite post_arg_setup

* test restricted permissions

* move changes to main

* Use .name of NamedTemporaryFile

* use better assertions

* set exc_info in except_hook

* Make post_arg_setup more robust

* final cleanup

* Add TempHandler

* undo main_test changes

* improve documentation

* use decorators instead of with for mock.patch

* add inline comment about logging.shutdown
2017-04-13 13:42:01 -07:00
Noah Swartz
c952af5c6a Merge pull request #4472 from l2dy/patch-1
Fix link in README.rst
2017-04-13 12:16:08 -07:00
Noah Swartz
3381cc10ec fix 3664 (#4495) 2017-04-13 11:57:14 -07:00
Noah Swartz
9f3e9e56a9 Merge pull request #4497 from certbot/star-link
Make sphinx happy
2017-04-13 09:48:18 -07:00
Noah Swartz
fa5ce60652 Merge pull request #4028 from jwm/jwm/3502_renew_hook_examples
add example of --renew-hook envvar values and hook script (#3502)
2017-04-13 09:40:58 -07:00
John Morrissey
fef3262759 add example of --renew-hook envvar values and hook script (#3502) 2017-04-13 11:00:32 -04:00
Brad Warren
42d732d3c2 make sphinx happy 2017-04-12 18:38:45 -07:00
Peter Eckersley
fbaf145c29 "Renew" now ignores domains in cli.ini (#4479)
* "Renew" now ignores domains in cli.ini

* Document things slightly better

* fix variable names

* py3fix
2017-04-12 15:48:58 -07:00
Noah Swartz
28495b1336 fixed up the changelog 2017-04-11 16:57:42 -07:00
Noah Swartz
07273e5d7e Merge pull request #4432 from certbot/contributing-common
Document tests/integration/_common.sh.
2017-04-10 19:15:18 -07:00
Alex Jordan
dfd4d0c10e Document hook error handling (#4418)
* Document hook error handling

* Clarify wording around hook failure exit codes
2017-04-07 10:16:59 -07:00
Jacob Hoffman-Andrews
a08e9599f5 Review feedback. 2017-04-07 10:15:52 -07:00
Yen Chi Hsuan
4b91f7fbbc Replace e.message with str(e) for Python 3 compatibility (#4416) 2017-04-07 09:58:19 -07:00
Jacob Hoffman-Andrews
d557c39c99 Remove obsolete fields from Registration. (#4339)
Authorizations and certificates were in the original spec but have since been
deleted.
2017-04-07 09:52:12 -07:00
Ngo The Trung
315b6d0cf1 Fix unorderable types error (#4409)
If the updated datetime collides, the comparator of heapq will move
onto the AuthorizationResource value and throws an "unorderable type"
error.

This adds an index value to the element tuple to ensure that they are
always strictly ordered.
2017-04-07 09:46:27 -07:00
Jacob Hoffman-Andrews
cacee80c51 Move make_csr into acme.crypto_util (#4165)
It's relatively finicky to make a CSR appropriate to pass to poll_and_request_issuance. I think most users want to be able to give a list of domains and a private key, and get back a CSR. This branch adds that functionality to crypto_util.

Note that the two new functions take arguments, and return values, as PEM-encoded buffers. This is a departure from some existing ACME interfaces that take PyOpenSSL types. I've discussed with the Certbot team, and we agree that this is broadly the direction the ACME API should take, so that users of the module don't need to import PyOpenSSL themselves, or use its primitives.

* Add make_csr.

* accept privkey

* Tweak API.

* Remove make_csr from certbot package.

* Skip test in older Pythons.

* Move get_Extensions call under protection.

* Remove assertIn because not backwards-compatible.

* Fix encoding, and use PEM.

* Fix test

* Fix tests on py35.

* Fix error in test.

* Make import_csr_file always return PEM.

Also delete get_sans_from_csr (unused) and get_names_from_csr (newly unused).

* Fix function doc.

* Fix indent

* Fix call of obtain_certificate_from_Csr

* lint

* Handle review feedback.

* Fix test.
2017-04-07 09:43:33 -07:00
Brad Warren
2e8a5ef477 Call certbot client cb_client rather than acme_client (#4357)
In some sense, certbot.client.Client is an ACME client, but it's the not the client in the ACME library and this leads to confusion. Let's make what this is clear.

* call certbot client cb_client rather than acme_client

* update tests
2017-04-06 16:05:54 -07:00
Erica Portnoy
da1cfa85fc Update changelog for 0.13.0 release (#4476) 2017-04-06 12:07:17 -07:00
Erica Portnoy
82f3f7523e Candidate 0.13.0 (#4475)
* Release 0.13.0

* Bump version to 0.14.0
2017-04-06 11:33:32 -07:00
Zero King
5259901d04 Fix link in README.rst 2017-04-06 11:02:00 +00:00
Erica Portnoy
18486d6ea0 Revert "More thoroughly rename during certbot rename. (#4320)" (#4467)
This reverts commit 43dccfc671.
2017-04-05 12:45:03 -07:00
Noah Swartz
664c9aaae5 Merge pull request #4419 from strugee/improve-changelog
Start organizing the change log
2017-04-05 12:31:46 -07:00
Peter Eckersley
2bdfffb23a Support "certbot-auto --no-bootstrap" (#3955)
* Support "certbot-auto --no-bootstrap"

* Tell people about --no-bootstrap?

* Document new certbot-auto flag in its cli help

* Rebuild

* Less variables is less variability

* Alphabetize help

* Make it extra clear we only take one branch

* Add --no-bootstrap message to experimentalbootstrap exit
2017-04-04 16:12:31 -07:00
Alex Jordan
2887b888f7
Start organizing the change log
This style is based on http://keepachangelog.com/en/0.3.0/.
2017-04-04 15:54:39 -04:00
Erica Portnoy
43dccfc671 More thoroughly rename during certbot rename. (#4320)
* rename more files in rename command

* Revert "Hide rename command (#4007)"

This reverts commit 8c14de13a5.

* Rename files in configuration files

* Delete new files if we fail during the renaming process

* update tests and error catching

* More expressive error message
2017-04-04 11:20:58 -07:00
St-Ranger
035e5b93ea Futher improvement re: FreeBSD packages
Further improved the previous change to make it more clear.
2017-04-04 00:41:55 -05:00
Nathan Arthur
2b03833752 Add NetBSD to list of OSes with packages 2017-04-04 00:55:25 -04:00
Nathan Arthur
971439a518 Sort list of OSes with packages 2017-04-04 00:48:33 -04:00
St-Ranger
4c36d8081e Correct info fro FreeBSD
1. Replace the outdated reference to "vritualenv", "see below" -> "see above".
2. Replace the awkward sentence (partially incorrect) about installing on FreeBSD. 
It can be installed via different ways: "pkg" is not exclusive. I am not aware of any reason why it canNOT be installed from ports. Some people prefer build and install everything from ports. (The previous version of the description implies that ports cannot be used.)
2017-04-03 23:45:48 -05:00
Robotic-Brain
345e77efcf Fixing Typo in README.rst (issues -> issued) 2017-04-04 00:42:33 +02:00
Robotic-Brain
b92b37d9fe Fixing Typo in Readme.rst 2017-04-04 00:35:11 +02:00
Zach Shepherd
22248c1393 docs: fix syntax error in plugin installation example
Partially addresses issue #4368.
2017-04-03 14:58:25 -07:00