Commit graph

9265 commits

Author SHA1 Message Date
Brad Warren
64a1f74df5 use real chmod 2019-06-04 16:59:40 -07:00
Adrien Ferrand
c9198b813f Remove string conversion of the ACL, fix setup 2019-06-04 23:39:29 +02:00
Adrien Ferrand
59a66a401c Fix operators and variables 2019-06-04 23:37:29 +02:00
Adrien Ferrand
9f42ec9956 Add constants. Add setUp 2019-06-04 23:35:45 +02:00
Adrien Ferrand
a600a3d254 Fix comment, and trigger 2019-06-04 23:29:51 +02:00
Adrien Ferrand
cf62930402 Move imports to the top of the file 2019-06-04 23:23:07 +02:00
Adrien Ferrand
5368ea73de Resolve recursively the link, add doc 2019-06-04 23:18:03 +02:00
Adrien Ferrand
0a8005ec10
Update certbot/tests/compat/filesystem_test.py
Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
2019-05-30 14:00:18 +02:00
Adrien Ferrand
be0c3e1faf
Update certbot/compat/filesystem.py
Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
2019-05-30 13:57:45 +02:00
Adrien Ferrand
869ece540c
Update filesystem_test.py 2019-05-24 19:43:24 +02:00
Adrien Ferrand
d977472d82
Fix lint 2019-05-24 19:35:52 +02:00
Adrien Ferrand
901536d545 Fix lint 2019-05-24 18:12:00 +02:00
Adrien Ferrand
998ba1ca9f Calibrate system tests coverage 2019-05-24 18:10:14 +02:00
Adrien Ferrand
43b618fe20 Add unit tests to filesystem 2019-05-24 18:07:52 +02:00
Adrien Ferrand
172a20776a Add entrypoint 2019-05-24 16:25:52 +02:00
Adrien Ferrand
36c421926c Update tests 2019-05-24 16:22:13 +02:00
Adrien Ferrand
eceecba599 Remove unused flag 2019-05-24 16:21:23 +02:00
Adrien Ferrand
b16aca1527 Remove a specific flag 2019-05-24 15:54:42 +02:00
Adrien Ferrand
c1040e3629 Sometimes, double-quote is the solution 2019-05-24 15:29:48 +02:00
Adrien Ferrand
6a8fcfd8ba Enable coverage 2019-05-24 15:21:33 +02:00
Adrien Ferrand
842b371f22 Merge branch 'master' into windows-files-permissions-step3a 2019-05-24 15:14:35 +02:00
Adrien Ferrand
aa452abc11 Simplify sid comparison 2019-05-22 10:42:56 +02:00
Brad Warren
8b684e9b95
Enable test farm tests in Travis (#7072)
You can see the full test suite running at https://travis-ci.com/certbot/certbot/builds/112291892.

A few noteworthy things:

--fast is included because without, the tests would sometimes reach Travis' 50 minute timeout even with 1 test script per Travis build.
The only script that is run at release time which is not being run here is https://github.com/certbot/certbot/blob/master/tests/letstest/scripts/test_tests.sh because that script runs tests on the packages installed by certbot-auto which won't be updated until midway through a release.
We check TRAVIS_PULL_REQUEST and error out if it is not false for simplicity which should be fine because these tests are never run on PRs. The reason it's more complex to run test farm tests on PRs is the test farm tests need a named branch to pull from and Travis effectively merges the PR into the target branch before running tests complicating this.
I don't think this should block this PRs, but the one final change we may want to make to the current setup is #7071.

* Add encrypted private key.

* Add test farm tests to tox and travis.

* Change magic profile name.

* Further split test farm tests.

* Build local branch.

* more depth
2019-05-17 16:30:20 -07:00
Adrien Ferrand
51a7e7cd19 Fix unpinned dependencies tests towards botocore and urllib3 (#7081)
* Limit transitive dependency on urllib3 to <1.25 to fulfill requirements in certbot-dns-route53 throught botocore dependency.
2019-05-17 14:50:29 -07:00
Brad Warren
d1753e46f9 Allow magic profile name none for configuring test farm tests. (#7069)
* Allow magic profile name none.

* Naming is hard.
2019-05-17 20:40:20 +02:00
Brad Warren
16834a0d78 Stop sharing state between processes in test farm tests (#7057)
* Set LOGDIR at top of script.

* Set sentinel at top of script.

* Don't use EC2 global to block on instance start.

* Remove global boto3 state.

* Pass in boulder_url.

* Create main function.

* Add link to reload docs.
2019-05-17 20:36:58 +02:00
Brad Warren
11c3e7107c Exit with a nonzero status when tests fail. (#7065) 2019-05-17 19:44:51 +02:00
Brad Warren
6bcd0415e0 Fix race condition adding tags to instance. (#7080) 2019-05-17 11:27:40 +02:00
Brad Warren
7a6545b747 Regularly print output in the test farm tests (#7079)
* Occasionally print output in test farm tests.

* Flush output.
2019-05-17 11:21:57 +02:00
Brad Warren
f4bbaadd18 Fix cleanup on failure. (#7070)
* Fix cleanup on failure.

* Incrementally build instances list.
2019-05-17 11:17:27 +02:00
Brad Warren
f8614e7c04 Fix centos6 test_sdists (#7068)
* Use Python 3 when appropriate.

* fix venv path
2019-05-17 11:03:00 +02:00
Brad Warren
def9af9f5e Update known good apache2 targets. (#7067) 2019-05-17 10:49:06 +02:00
Brad Warren
26d01537cb Add test farm tests requirements file (#7061)
* Add requirements.txt.

* update readme
2019-05-17 10:41:11 +02:00
Andreas Vogler
7cfbeaeac8 Added certbot-dns-rfc2136 to list of changed modules in CHANGELOG (#7074)
* Add an option to dns_rfc2136 plugin to explicitly specify an authorative base domain.

* Updated CHANGELOG mentioning added base domain option

* Made the comment on the new option more clear on auto-detection

* Updated comment on how the authorative base domain is determined

* Added certbot-dns-rfc2136 to list of changed modules in CHANGELOG
2019-05-16 13:06:29 +02:00
Andreas Vogler
5ab6a597b0 Add an option to dns_rfc2136 plugin to specify an authorative base domain. (#7029)
* Add an option to dns_rfc2136 plugin to explicitly specify an authorative base domain.

* Updated CHANGELOG mentioning added base domain option

* Made the comment on the new option more clear on auto-detection

* Updated comment on how the authorative base domain is determined
2019-05-16 10:40:17 +02:00
Adrien Ferrand
9f40826fb5 Added a link to list of NTFS rights 2019-05-16 00:13:05 +02:00
Adrien Ferrand
7d1ced2aa0 Ensure we are not building wheels using an old version of setuptools 2019-05-16 00:09:02 +02:00
Adrien Ferrand
d43d293fb6 Improve comment 2019-05-15 23:54:57 +02:00
Adrien Ferrand
9c714b3453 Improve a comment 2019-05-15 23:45:06 +02:00
Adrien Ferrand
9a32631191 Update environment marker 2019-05-15 23:40:22 +02:00
Adrien Ferrand
2e1c79ed2a Add test for os module 2019-05-15 23:24:38 +02:00
Adrien Ferrand
57a3e9450a Call filesystem.chmod in tests, remove one test 2019-05-15 23:20:13 +02:00
Adrien Ferrand
d0ce83453a Add main command 2019-05-15 18:05:19 +02:00
Adrien Ferrand
8e01f7f561 Add comments about well-known SIDs 2019-05-15 17:55:43 +02:00
Adrien Ferrand
7e1f284d36 Use a try/except import approach similar to lock 2019-05-15 17:45:29 +02:00
Adrien Ferrand
9a7f774706 [Unix] Create a framework for certbot integration tests: PART 5-FINAL (#6989)
* Connect certbot-ci to travis. Remove old bash files.

* Configure test-everything

* Protect against import error

* Remove unused ignore

* Better handling of urllib3

* Correct path

* Remove a warning

* Correct call

* Protect atexit register execution

* Update docs/contributing.rst

Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>

* Update docs/contributing.rst

Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>

* Add again some bash scripts to avoid breaking to much retro-compatiblity on third party scripts

* Move boulder-v1 and boulder-v2 in nightly tests

* Separate oldest unit tests and oldest integration tests

* Remove try/except

* Test integration included in toxenv

* Add a wait to avoid a transient issue on OCSP status in oldest tests

* Clean travis.yml, split other tests

* Remove useless config

* Update .travis.yml

Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>

* Update tox.ini

* Update tox.ini

* Remove pytest-sugar

* Remove empty pytest.ini, tests are working without it
2019-05-14 13:56:32 -07:00
Brad Warren
2abe39d8a2
Add legalese around MM instance. (#7064) 2019-05-14 13:28:23 -07:00
Adrien Ferrand
3888bc8f2a Revert " Add FreeBSD specific paths (#6702)" (#7056)
Revert #6702

After some discussions, we realized that changing the path for FreeBSD users, if it corresponds to the path used when Certbot is installed using ports, will break for users that installed it through certbot-auto.

Indeed in this case, the path used was the one for Linux. After #6702, Certbot would not find anymore the existing config path by default.

It would require, to be integrated, a proper documentation and a migration path. For now, it is preferable to revert it.

This reverts commit 7fe82cf1ac.
2019-05-13 13:55:22 -07:00
Po-Chuan Hsieh
7fe82cf1ac Add FreeBSD specific paths (#6702)
* Add support for FreeBSD specific paths

Reference:	https://svnweb.freebsd.org/ports/head/security/py-certbot/files/patch-certbot_compat.py

* Add CHANGELOG.md entry

* Fix linting error

Pointed out by:	@adferrand
2019-05-11 08:13:37 +02:00
Brad Warren
d391fb8876
Merge pull request #7044 from certbot/candidate-0.34.2
Candidate 0.34.2
2019-05-07 15:03:03 -07:00