Commit graph

8154 commits

Author SHA1 Message Date
Erica Portnoy
b4401d8086 match test conf port with command line flag 2018-01-11 15:13:57 -08:00
Brad Warren
cfe5854aa3 Merge branch 'http01-nginx' of github.com:certbot/certbot into test-http01-nginx2 2018-01-11 14:45:45 -08:00
Erica Portnoy
b1df26a4dc continue to return None from choose_redirect_vhost when create_if_no_match is False 2018-01-11 14:44:39 -08:00
Brad Warren
d7c03e136b Merge branch 'http01-nginx' into test-http01-nginx2 2018-01-11 14:37:06 -08:00
Erica Portnoy
265afaf7a0 remove access_log and error_log cruft that wasn't being executed 2018-01-11 14:27:43 -08:00
Erica Portnoy
cd2188a681 remove debugger 2018-01-11 14:23:00 -08:00
Erica Portnoy
ffe8870b9b use domains that have matching addresses 2018-01-11 14:20:36 -08:00
Brad Warren
0cc1e3d4bf Merge branch 'http01-nginx' into test-http01-nginx2 2018-01-11 14:18:56 -08:00
Erica Portnoy
77493d6e1a properly test for port number 2018-01-11 14:09:08 -08:00
Brad Warren
3100dca880 faster tests 2018-01-11 14:05:09 -08:00
Brad Warren
b0fa063ef3 no auth reuse plz 2018-01-11 13:37:13 -08:00
Erica Portnoy
874a4c6773 select an http block instead of https 2018-01-11 13:35:16 -08:00
Brad Warren
9741f78afe try better cli 2018-01-11 13:22:00 -08:00
Erica Portnoy
5210588a29 fix configurator test 2018-01-11 13:20:14 -08:00
Erica Portnoy
7fa4a7a5b9 lint 2018-01-11 13:07:46 -08:00
Brad Warren
9ada7711f6 test it 2018-01-11 13:04:26 -08:00
Erica Portnoy
c36bca765d rename sni --> http01 in unit tests 2018-01-11 12:21:29 -08:00
Erica Portnoy
dc60852355 pass existing unit tests 2018-01-11 12:17:55 -08:00
Erica Portnoy
b11c685339 Change Nginx http01 to modify server block so the site doesn't stop serving while getting a cert 2018-01-11 12:01:31 -08:00
Joona Hoikkala
88d4a7da55
Initialize addrs_to_add 2018-01-11 16:57:04 +02:00
Erica Portnoy
34217cf36e only remove ssl from addresses during http01 2018-01-11 00:59:04 -08:00
Erica Portnoy
91d18d1234 test that http01 perform is called 2018-01-11 00:02:54 -08:00
Erica Portnoy
f3395d487c python3 compatibility 2018-01-10 23:36:39 -08:00
Erica Portnoy
787b0c358f no need to cover raise NotImplementedError() lines 2018-01-10 23:19:09 -08:00
Erica Portnoy
6575ed955c add pylint disables to the tests to make pylint happier about the inheritance and abstraction situation 2018-01-10 23:10:32 -08:00
Erica Portnoy
b574bdf145 Make challenges.py more abstract to make lint happier 2018-01-10 23:01:17 -08:00
Erica Portnoy
4c1bcd1bcd challenges_test tests with both tlssni01 and http01 2018-01-10 22:38:23 -08:00
Erica Portnoy
5d517a1f0d remove TODO 2018-01-10 22:07:23 -08:00
Erica Portnoy
1afec8a8fd refactor NginxHttp01 and NginxTlsSni01 to both now inherit from NginxChallengePerformer 2018-01-10 22:06:42 -08:00
Erica Portnoy
c9759bd1b6 lint 2018-01-10 19:12:39 -08:00
Erica Portnoy
557815bf94 update existing nginx tests 2018-01-10 19:09:53 -08:00
Erica Portnoy
9209d1eeca support multiple challenge types in configurator.py 2018-01-10 18:59:57 -08:00
Erica Portnoy
9c02b83773 get http01 challenge working 2018-01-10 18:42:05 -08:00
Brad Warren
9e95208101
Factor out common challengeperformer logic (#5413) 2018-01-10 18:34:45 -08:00
Brad Warren
39472f88de
reduce ipdb version (#5408) 2018-01-10 13:26:31 -08:00
Brad Warren
3acf5d1ef9
Fix rebootstraping with old venvs (#5392)
* Fix rebootstrapping before venv move

* add regression test

* dedupe test

* Cleanup case when two venvs exist.

* Add clarifying comment

* Add double venv test to leauto_upgrades

* Fix logic with the help of coffee

* redirect stderr

* pass VENV_PATH through sudo

* redirect stderr
2018-01-10 12:10:21 -08:00
Brad Warren
00634394f2
Only respect LE_PYTHON inside USE_PYTHON_3 if we know a user must have set it version 2 (#5402)
* stop exporting LE_PYTHON

* unset LE_PYTHON sometimes
2018-01-09 21:16:44 -08:00
ohemorange
6eb459354f Address erikrose's comments on #5329 (#5400) 2018-01-09 16:48:16 -08:00
ohemorange
f5a02714cd Add deprecation warning for Python 2.6 (#5391)
* Add deprecation warning for Python 2.6

* Allow disabling Python 2.6 warning
2018-01-09 16:11:04 -08:00
Brad Warren
887a6bcfce Handle need to rebootstrap before fetch.py (#5389)
* Fix #5387

* Add test for #5387

* remove LE_PYTHON

* Use environment variable to reduce line length
2018-01-09 15:40:26 -08:00
Joona Hoikkala
288c4d956c Automatically install updates in test script (#5394) 2018-01-09 08:28:52 -08:00
Joona Hoikkala
62ffcf5373 Fix macOS builds for Python2.7 in Travis (#5378)
* Add OSX Python2 tests

* Make sure python2 is originating from homebrew on macOS

* Upgrade the already installed python2 instead of trying to reinstall
2018-01-09 07:48:05 -08:00
Brad Warren
d557475bb6
update Apache ciphersuites (#5383) 2018-01-09 07:46:21 -08:00
Brad Warren
e02adec26b Have letsencrypt-auto do a real upgrade in leauto-upgrades option 2 (#5390)
* Make leauto_upgrades do a real upgrade

* Cleanup vars and output

* Sleep until the server is ready

* add simple_http_server.py

* Use a randomly assigned port

* s/realpath/readlink

* wait for server before getting port

* s/localhost/all interfaces
2018-01-08 17:38:03 -08:00
Brad Warren
24ddc65cd4
Allow non-interactive revocation without deleting certificates (#5386)
* Add --delete-after-revoke flags

* Use delete_after_revoke value

* Add delete_after_revoke unit tests

* Add integration tests for delete-after-revoke.
2018-01-08 17:02:20 -08:00
ohemorange
8585cdd861 Deprecate Python2.6 by using Python3 on CentOS/RHEL 6 (#5329)
* If there's no python or there's only python2.6 on red hat systems, install python3

* Always check for python2.6

* address style, documentation, nits

* factor out all initialization code

* fix up python version return value when no python installed

* add no python error and exit

* document DeterminePythonVersion parameters

* build letsencrypt-auto

* close brace

* build leauto

* fix syntax errors

* set USE_PYTHON_3 for all cases

* rip out NOCRASH

* replace NOCRASH, update LE_PYTHON set logic

* use built-in venv for py3

* switch to LE_PYTHON not affecting bootstrap selection and not overwriting LE_PYTHON

* python3ify fetch.py

* get fetch.py working with python2 and 3

* don't verify server certificates in fetch.py HttpsGetter

* Use SSLContext and an environment variable so that our tests continue to never verify server certificates.

* typo

* build

* remove commented out code

* address review comments

* add documentation for YES_FLAG and QUIET_FLAG

* Add tests to centos6 Dockerfile to make sure we install python3 if and only if appropriate to do so.
2018-01-08 13:57:04 -08:00
Brad Warren
18f6deada8 Fix letsencrypt-auto name and long forms of -n (#5375) 2018-01-05 19:27:00 -08:00
Joona Hoikkala
a1713c0b79 Broader git ignore for pytest cache files (#5361)
Make gitignore take pytest cache directories in to account, even if
they reside in subdirectories.

If pytest is run for a certain module, ie. `pytest certbot-apache` the
cache directory is created under `certbot-apache` directory.
2018-01-05 11:08:38 -08:00
Joona Hoikkala
a3a66cd25d Use apache2ctl modules for Gentoo systems. (#5349)
* Do not call Apache binary for module reset in cleanup()

* Use apache2ctl modules for Gentoo
2018-01-04 14:36:16 -08:00
Noah Swartz
a7d00ee21b print as a string (#5359) 2018-01-04 13:59:29 -08:00