Commit graph

536 commits

Author SHA1 Message Date
Wilfried Teiken
b2505b996f Switch to always using dnspython (requires dnspthon>=1.12).
Also, address some documentation nits.
2016-07-31 20:36:00 -04:00
Wilfried Teiken
827c93510c Merge branch 'add_dns01_challenge' of github.com:wteiken/letsencrypt into add_dns01_challenge 2016-07-31 20:13:36 -04:00
Ville Skyttä
c7b89c334b Use logger.warning instead of deprecated warn 2016-07-22 09:54:28 +03:00
Peter Eckersley
24cc6b208a Avoid newline 2016-06-22 15:24:33 -07:00
Peter Eckersley
56488b1899 Explain the most likely cause of a missing replay nonce error 2016-06-20 18:18:25 -07:00
Peter Eckersley
b53b47c5d7 Merge pull request #3125 from certbot/lint-lint
Improve user experience for linting.
2016-06-13 14:22:11 -07:00
Jacob Hoffman-Andrews
4f2a8f86d8 Remove unnecessary check on registration returned.
Right now the ACME client checks that the returned registration matches the
registation posted, but there's no guarantee this will always be the case, and
this only introduces unnecessary fragility.
2016-06-13 11:52:36 -07:00
Jacob Hoffman-Andrews
91cd19158e Improve user experience for linting.
Don't run pep8 for directories that we don't actually enforce pep8 on.
Install dependencies with -q.
Don't print reports, they make it hard to find the actual errors.
Remove deprecated fields from acme .pylintrc, they cause unnecessary messages
about deprecation.
2016-06-04 22:53:51 -07:00
Brad Warren
36e63a7372 Bump version to 0.9.0 2016-06-02 13:50:37 -07:00
Brad Warren
dcadcf8d42
Release 0.8.0 2016-06-02 13:50:30 -07:00
bmw
590d816fa9 s/assert_called_once/assert_called_once_with (#3100) 2016-05-31 16:03:42 -07:00
Brad Warren
7153220b41 Bump version to 0.8.0 2016-05-27 13:30:54 -07:00
Brad Warren
46d8f6e18c
Release 0.7.0 2016-05-27 13:30:46 -07:00
bmw
e01878a813 Merge pull request #3034 from chbrown/patch-1
Typo: too many self's
2016-05-26 14:27:56 -07:00
schoen
9a640e01fd Merge pull request #2962 from chrismarget/master
Randomize serial numbers of DVSNI challenge certificates.
2016-05-20 16:39:24 -07:00
Christopher Brown
3aed4fc59d Typo: too many self's
The extra self will push along the arguments, resulting in the accurate but not very helpful error message: "AttributeError: 'JWKRSA' object has no attribute 'kty'"
2016-05-19 14:19:13 -05:00
chrismarget
6dd9991371 Fix invalid attribute for pylint 2016-05-17 20:10:20 +00:00
chrismarget
85e9624555 Added test for random certificate serial numbers from gen_ss_cert. 2016-05-17 19:50:57 +00:00
Jacob Hoffman-Andrews
8f696b3ad7 Reuse HTTP connections. (#2855)
Fixes #2778
2016-05-15 13:48:51 -07:00
Brad Warren
c8cf0b4600 Bump version to 0.7.0 2016-05-11 18:04:27 -07:00
Brad Warren
8e742fa3c6
Release 0.6.0 2016-05-11 18:04:15 -07:00
chrismarget
f7b10bb83e Serial number randomization with improved portability.
No exception handling required this time.
2016-05-11 17:06:29 -04:00
chrismarget
4759bc9034 Trying to make pylint happy. 2016-05-11 16:41:19 -04:00
bmw
255e205c1a Merge pull request #2963 from certbot/ok-directory
Allow unrecognized fields in Directory object
2016-05-11 13:38:09 -07:00
chrismarget
6fbd5fa811 Added missing whitespace. 2016-05-11 16:04:08 -04:00
chrismarget
7f70c09c53 Randomize serial numbers of DVSNI challenge certs.
Should now work on python 2.7 and 3.3+
2016-05-11 15:19:39 -04:00
Jacob Hoffman-Andrews
6f9e28fcca Allow unrecognized fields in directory. 2016-05-11 11:11:52 -07:00
chrismarget
a7ef4940b6 Randomize DVSNI challenge certificate serial number, now for python 3.3. 2016-05-11 13:57:18 -04:00
Jacob Hoffman-Andrews
88499238ed Merge pull request #2797 from kuba/omitempty-error-type-detail
ACME: omitempty Error.detail, Error.type (fixes #2289)
2016-05-11 09:50:09 -07:00
chrismarget
639efaeb7b Randomize serial numbers of DVSNI challenge certificates. 2016-05-11 12:01:53 -04:00
Wilfried Teiken
9396e92a96 Fix lint issues. 2016-04-25 00:46:45 -04:00
Wilfried Teiken
6196cf0aa7 Merge branch 'master' into add_dns01_challenge 2016-04-25 00:40:27 -04:00
Brad Warren
b956a968c6 this commit was authored by the Certbot Project 2016-04-14 16:56:02 -07:00
Brad Warren
ae6f1c62f1 Rename misc files 2016-04-14 10:20:23 -07:00
Jakub Warmuz
0839168de7
Fake deserialization error in test_check_response_not_ok_jobj_no_error 2016-04-10 07:50:39 +00:00
Jakub Warmuz
8145b7c11b
ACME: omitempty Error.detail, Error.type (fixes #2289) 2016-04-09 08:17:26 +00:00
bmw
b347e9fba1 Merge pull request #2775 from kuba/directory-meta
Add Directory.meta (fixes #2768)
2016-04-07 18:37:03 -07:00
Jakub Warmuz
e4076633c8
Add Directory.meta (fixes #2768) 2016-04-06 06:14:31 +00:00
Brad Warren
37817130b0 Bump version to 0.6.0 2016-04-05 17:55:29 -07:00
Brad Warren
4d4cfb414f
Release 0.5.0 2016-04-05 17:55:18 -07:00
Brad Warren
1fe1ac3102 Merge branch 'master' into acme-continuity-cruft 2016-03-07 18:48:30 -08:00
Brad Warren
ec1b14e388 Whatsa DV challenge 2016-03-07 18:47:23 -08:00
Brad Warren
22a9c7e3c2 Remove unused 'other' module 2016-03-07 18:44:30 -08:00
Brad Warren
a941b6830d remove crufty continuity challenges 2016-03-07 18:42:44 -08:00
Erik Rose
55b63fca0d Require setuptools>=1.0 in all packages that use the cryptography lib.
When pip-installing any of these packages, pip hit our permissive, any-version "setuptools" dependency first and then ignored all subsequent, more constrained ones, like cryptography's "setuptools>=1.0". See https://github.com/pypa/pip/issues/988. It thus, on a box with setuptools 0.9.8, stuck with that version. Then, at runtime, letsencrypt crashed because pkg_resources couldn't satisfy cryptography's setuptools>=1.0 requirement.

This change lets us pip-install our packages and have it work. We'll need to make sure our direct requirements (all of them) satisfy the more constrained requirements of our dependencies. Yes, it is disgusting.
2016-03-03 18:02:38 -05:00
Brad Warren
b3166497f0 Merge branch 'master' into keinwerkzeug 2016-02-25 17:16:12 -08:00
Peter Eckersley
593cb3a038 alphabetanit 2016-02-25 16:58:54 -08:00
Peter Eckersley
9a36439e1b Tweaks per review 2016-02-22 17:26:55 -08:00
bmw
356cf890e6 Merge pull request #2482 from pfeyz/acme-example-client-fix
wrap csr in ComparableX509
2016-02-22 09:55:08 -08:00
Jakub Warmuz
29d16b027e
Separate pep8 config for acme. 2016-02-20 11:01:25 +00:00
Peter Eckersley
8d61c86c8c Well actually
We don't need stripping after all.
2016-02-17 16:11:50 -08:00
Peter Eckersley
9fc723f316 Exceptional coverage 2016-02-16 11:52:48 -08:00
Peter Eckersley
a9780c2ddc Test trailing whitespace in headers 2016-02-16 11:15:35 -08:00
Peter Eckersley
7f2ca5d065 Document use of email.utils parser 2016-02-16 11:15:35 -08:00
Peter Eckersley
7c8638f108 Life is simpler if we don't support HTTP/1.0 ACME servers
(Though in practice with py27+ we still support them)
2016-02-16 11:05:11 -08:00
Paul Feitzinger
d6b213d1e3 wrap csr in ComparableX509 2016-02-16 12:00:11 -05:00
Peter Eckersley
49aeffdebb Address some review comments 2016-02-15 12:53:10 -08:00
Wilfried Teiken
7c3271545f Do not log an error when getting NXDOMAIN. 2016-02-13 01:05:35 -05:00
Wilfried Teiken
e8d09ea994 Merge remote-tracking branch 'upstream/master' into add_dns01_challenge 2016-02-12 23:32:34 -05:00
Brad Warren
45ee1eb889 Merge branch 'testing-dev-extras' 2016-02-12 16:19:57 -08:00
Brad Warren
e493a0deff Merge branch 'acme-new-authz-directory' 2016-02-12 16:11:56 -08:00
Peter Eckersley
6fd3dba737 Two digit years are used/tested in py26 only 2016-02-12 15:08:32 -08:00
Peter Eckersley
c3ddb47cfa All this import voodoo is not required for py2.6+ 2016-02-12 12:59:53 -08:00
Peter Eckersley
f1faedaa72 This two digit year case is hard to trigger 2016-02-12 12:48:20 -08:00
Peter Eckersley
0afb424173 py26 doesn't like adding lists & tuples 2016-02-12 12:29:13 -08:00
Peter Eckersley
ae69a74465 Tidy 2016-02-12 11:38:26 -08:00
Peter Eckersley
ca7f190efc lint & cover 2016-02-12 11:29:36 -08:00
Peter Eckersley
6f99d9f3d9 fixen 2016-02-11 18:22:41 -08:00
Peter Eckersley
a34dc94b1c bugfixes & minimalism 2016-02-11 17:28:07 -08:00
Peter Eckersley
ef404d4985 slightly simpler / more compact 2016-02-11 16:12:42 -08:00
Peter Eckersley
0ecaa8abca rm unused var 2016-02-11 15:45:51 -08:00
Peter Eckersley
df383ee6e4 Remove werkzeug dependency by parsing Retry-After ourselves
Fixes #2409
Progress on #1301
2016-02-11 15:44:23 -08:00
Peter Eckersley
563c115044 Bump version to 0.5.0 2016-02-10 18:49:27 -08:00
Peter Eckersley
74063851e3
Release 0.4.0 2016-02-10 18:48:40 -08:00
Peter Eckersley
b6d0632a10 Bump version to 0.4.0 2016-01-27 17:05:25 -08:00
Peter Eckersley
cf218dd7f1
Release 0.3.0 2016-01-27 15:12:30 -08:00
Rémy HUBSCHER
b8690cd471 Make wheel universal 2016-01-21 10:11:23 +01:00
bmw
30d8394535 Merge pull request #2199 from letsencrypt/0.2.0
Include 0.2.0 release in master's history, and bump version
2016-01-19 17:56:44 -08:00
bmw
8301f2f57b Merge pull request #1665 from erikrose/letsencrypt-auto-release
Make letsencrypt-auto release-suitable, self-upgrading, and self-contained.
2016-01-19 15:16:49 -08:00
Jakub Warmuz
3a90b4c7c5
acme: fix empty set repr py3 compat 2016-01-18 21:39:25 +00:00
Peter Eckersley
5535c0675b Revert "Revert "Fix "global" max_attempt bug (#1719)"" 2016-01-18 12:46:10 -08:00
Peter Eckersley
e87de72662 Revert "Fix "global" max_attempt bug (#1719)" 2016-01-18 12:13:51 -08:00
Peter Eckersley
e93c16a11b Merge pull request #2111 from kuba/bugs/1719
Fix "global" max_attempt bug (#1719)
2016-01-18 11:39:59 -08:00
Erik Rose
e1bd1645b6 Revert moving mock to test_requires.
We'll take this up later, but I don't want to hold up the new le-auto on this debate.
2016-01-15 18:25:26 -05:00
Peter Eckersley
91d958aa59 Bump version to 0.2.1.dev0 2016-01-15 15:03:53 -08:00
Erik Rose
ecbe2a5c69 Merge master in to get the unconditionalization of dependencies. 2016-01-15 13:43:36 -05:00
Wilfried Teiken
c15581bcfd Fix lint problems. 2016-01-14 23:37:05 -05:00
Wilfried Teiken
b65da1da76 Merge branch 'add_dns01_challenge' into test-add_dns01_challenge 2016-01-14 23:05:49 -05:00
Wilfried Teiken
b9dafc203f Merge branch 'master' into add_dns01_challenge 2016-01-14 23:01:06 -05:00
Brad Warren
e59fcf7ddd
Release 0.2.0 2016-01-14 17:39:18 -08:00
Brad Warren
2e034e6c6c Revert changes to acme's setup.py 2016-01-14 11:42:10 -08:00
Erik Rose
2771249522 Merge master in before computing a known-good set for 0.2.0.
This also serves as a suitable base to build sdists for isnot.org, so we can try the old le-auto script against mockless versions of the LE packages.
2016-01-13 18:23:51 -05:00
Erik Rose
c3ea4bdc9b Roll back change to acme's pylintrc, which was needed to get lint to pass on Travis's Trusty beta (sudo) infra.
We're stepping off that infra briefly, to keep it the same as boulder's. When we retire the old le-auto, we'll step back on and change boulder to use it as well.
2016-01-13 17:22:59 -05:00
Peter Eckersley
9500f2b3c3 Merge pull request #2139 from kuba/acme-pylint-80
ACME: pylint to 80 chars
2016-01-13 00:31:02 -08:00
bmw
de89eb89e2 Merge pull request #2135 from kuba/acme-client-dead-error
Remove dead code (error in except)
2016-01-12 14:50:15 -08:00
bmw
9167871a82 Merge pull request #2132 from kuba/acme-account-key-none-docs
Fix wrong doc comment: account_public_key is None
2016-01-12 14:49:43 -08:00
bmw
591f0376e8 Merge pull request #2089 from wteiken/fix_regr_from_resource
Update new_authzr_uri when querying or updating a registration
2016-01-12 14:45:54 -08:00
Erik Rose
a3288a92b9 Disable too-many-instance-attributes for the acme linter.
This should make the linter pass and allow us to merge the letsencrypt-auto-release branch when it's ready. IHNI why it passes on master without this disabled.
2016-01-12 14:25:36 -05:00
Erik Rose
ed562645e0 Master master into letsencrypt-auto-release so Travis will build it. 2016-01-11 21:45:16 -05:00
Erik Rose
6c05197a43 Remove mock as an install requirement.
The motivation is to free us of a reliance on a rather modern version of setuptools, which caused le-auto failures for people on Wheezy and other older distros. (The alternative would have been to forcibly upgrade setuptools as the old le-auto did, but less is more.)

Mock is used only in tests, so we move it to tests_require. It will still be installed automatically when setup.py test is run. Give all packages a test_suite so this works.

The "testing" extra remains for optional packages not required for the nose tests but used in tox. However, the extra is much less useful now and is a candidate for deletion. We could roll the list of packages therein into the tox config so as not to favor any particular package.

Remove tests_require=install_requires, which I don't think does anything useful, since install requirements are implicitly installed when running setup.py test.

Fix tests to pass with mock removed. We had to stop them pulling down LE from PyPI, since the current version there (0.1.1) requires mock and explodes when `letsencrypt` is run.
2016-01-11 21:26:41 -05:00
Wilfried Teiken
05a61c181b Lint fixes. 2016-01-10 21:42:20 -05:00
Wilfried Teiken
9179276cb9 Modify dns_resolver_test to skip tests if dnspython is not available. 2016-01-10 20:59:11 -05:00
Wilfried Teiken
1ff121b616 pcoverage fix 2016-01-10 18:08:16 -05:00
Wilfried Teiken
2d8de74f4a pcoverage fix 2016-01-10 17:13:25 -05:00
Wilfried Teiken
0010610a4a py3X fix 2016-01-10 17:06:03 -05:00
Wilfried Teiken
cfe56cbd92 2.6 compatible skipping of tests. 2016-01-10 17:00:14 -05:00
Jakub Warmuz
bdd9fa4485
Quickfix too-many-instance-attributes.
https://github.com/letsencrypt/letsencrypt/pull/2135#issuecomment-170381179
2016-01-10 18:47:04 +00:00
Jakub Warmuz
86d6d27045
Clean up dev/testing extras messup (fixes #2140). 2016-01-10 18:37:41 +00:00
Jakub Warmuz
fac2ed41d8
ACME: pylint to 80 chars 2016-01-10 18:17:35 +00:00
Jakub Warmuz
31a64a0e9f
ACME: default to new_authzr_uri form Directory 2016-01-10 18:01:58 +00:00
Wilfried Teiken
49c40e7a58 Skip dns_resolver tests if dnspython is not available. 2016-01-10 13:00:38 -05:00
Wilfried Teiken
f2b52bd830 Fix dcumentation 2016-01-10 12:58:29 -05:00
Jakub Warmuz
0a536d50be
Remove dead code (error in except) 2016-01-10 17:31:50 +00:00
Jakub Warmuz
c10bfd6efc
Fix wrong doc comment: account_public_key is None 2016-01-10 14:01:34 +00:00
Jakub Warmuz
3cddb15023
Merge remote-tracking branch 'github/letsencrypt/master' into pyopenssl 2016-01-10 11:25:12 +00:00
Jakub Warmuz
1182dcf0c2
Merge remote-tracking branch 'github/letsencrypt/master' into acme-pylint 2016-01-10 11:17:03 +00:00
Peter Eckersley
bf4793039a Merge remote-tracking branch 'origin/master' into pyopenssl 2016-01-10 02:39:54 -08:00
Wilfried Teiken
d842f268e5 - Use dnspython3 fir py3X environments.
- Fix encoding for simple_verify.
2016-01-09 17:07:20 -05:00
Wilfried Teiken
e7ce5e9f53 Merge branch 'master' into add_dns01_challenge 2016-01-09 15:19:47 -05:00
Wilfried Teiken
446994e8ef Limit length of try block. 2016-01-09 14:58:19 -05:00
Jakub Warmuz
b26dda3afe
Add Python 3.5 trove classifier to acme 2016-01-09 13:38:12 +00:00
Jakub Warmuz
a367c98409
Merge remote-tracking branch 'github/letsencrypt/master' into acme-pylint 2016-01-09 12:50:13 +00:00
Erik Rose
f2586fbc11 Merge master in so Travis will test this PR. 2016-01-08 17:08:30 -05:00
bmw
96b55c8f34 Revert "Don't use cryptography version 1.2" 2016-01-08 17:02:35 -05:00
Erik Rose
1d719bd89c Teach le-auto about dependencies that are conditional on the Python version. 2016-01-08 15:31:22 -05:00
Brad Warren
b1e67f241e Fix merge conflicts properly 2016-01-08 14:31:30 -05:00
Brad Warren
36679c2daa Merge branch 'master' into pyopenssl 2016-01-08 14:27:07 -05:00
Brad Warren
a7a7380110 Merge branch 'master' into pyopenssl 2016-01-08 14:26:13 -05:00
Brad Warren
b039c884d8 Don't use cryptography version 1.2 2016-01-08 14:09:44 -05:00
Brad Warren
639cbeb7d0 sans_text_dump_comment += 1 2016-01-07 21:11:09 -05:00
Jakub Warmuz
dba69d079f
Separate pylintrc for acme 2016-01-07 22:20:46 +00:00
Jakub Warmuz
cc168c8ef1
Generate fresh pylintrc
pylint 1.4.2, -generate-rcfile
2016-01-07 22:17:42 +00:00
Brad Warren
946f4474da Add warning about multiple SANs extensions 2016-01-07 16:45:46 -05:00
Brad Warren
32957cc5ec Comment _pyopenssl_cert_or_req_san method 2016-01-07 16:25:23 -05:00
Jakub Warmuz
6548f343bf
Add invalidEmail error type to acme
Related to:
- #1923
- https://github.com/ietf-wg-acme/acme/pull/65
2016-01-07 21:20:25 +00:00
Brad Warren
710eb59f41 Fix IDN CSR test name 2016-01-07 16:19:21 -05:00
Jakub Warmuz
a36a59ba6c
Fix waiting->exhausted in PollError tests 2016-01-07 20:31:40 +00:00
Jakub Warmuz
4d04d14b20
Fix "global" max_attempt bug (#1719) 2016-01-07 20:25:07 +00:00
Jakub Warmuz
fea4b24fb8
Add test to discover "global" max_attempt bug (#1719) 2016-01-07 20:20:57 +00:00
Brad Warren
0f239e0029 Add comment about dependency version 2016-01-07 13:04:29 -05:00
Brad Warren
caf9b1f261 Clarify _get_idn_sans method 2016-01-07 13:00:29 -05:00
Wilfried Teiken
02a493011e Remove superfluous except: and change Exception returned if dnspython is not
available.
2016-01-06 22:56:59 -05:00
Brad Warren
0b1e1d0937 Use test_util.load_cert 2016-01-06 22:07:45 -05:00
Brad Warren
51bc1311a2 Fixed rogue quotes 2016-01-06 15:34:42 -05:00
Brad Warren
1cdff156c9 Add IDN test 2016-01-06 15:33:36 -05:00
Brad Warren
96114ba84e Add IDN SANs CSR and cert 2016-01-06 15:10:08 -05:00
Brad Warren
ba93c57697 Added large sans cert and csr test 2016-01-06 14:22:13 -05:00
Brad Warren
32650a6d08 Added 100 SANs cert and csr 2016-01-06 14:10:57 -05:00
Brad Warren
1af997158d Fix repr differences between PyOpenSSL versions 2016-01-06 13:39:14 -05:00
Brad Warren
6f7299f9ed Merge branch 'master' into pyopenssl 2016-01-06 12:40:56 -05:00