upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-05-28 04:34:11 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Do not log an error when getting NXDOMAIN.

Browse source
This commit is contained in:
Wilfried Teiken 2016-02-13 01:05:35 -05:00
parent e8d09ea994
commit 7c3271545f
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
acme/acme/dns_resolver.py
View file

@ -19,7 +19,9 @@ def txt_records_for_name(name):
"""
try:
dns_response = dns.resolver.query(name, 'TXT')
except dns.resolver.NXDOMAIN as error:
return []
except dns.exception.DNSException as error:
logger.error("Unable to resolve %s: %s", name, str(error))
logger.error("Error resolving %s: %s", name, str(error))
return []
return [txt_rec for rdata in dns_response for txt_rec in rdata.strings]

5
acme/acme/dns_resolver_test.py
View file

@ -38,6 +38,11 @@ class TxtRecordsForNameTest(unittest.TestCase):
@mock.patch("acme.dns_resolver.dns.resolver.query")
def test_txt_records_for_name_domain_not_found(self, mock_dns):
mock_dns.side_effect = dns.resolver.NXDOMAIN
self.assertEquals([], dns_resolver.txt_records_for_name('name'))
@mock.patch("acme.dns_resolver.dns.resolver.query")
def test_txt_records_for_name_domain_other_error(self, mock_dns):
mock_dns.side_effect = dns.exception.DNSException
self.assertEquals([], dns_resolver.txt_records_for_name('name'))