upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-05-28 04:34:11 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

update acmev1 url comment (#10343)

Browse source 
this was the wrong/misleading comment i remember erica mentioning in our
discussions yesterday. the problem here is modern versions of certbot
also always save the server url. see
31599bad83/certbot/src/certbot/_internal/storage.py (L288-L291)

i personally don't think this requires two reviews and if whoever gets
to this first agrees, i think you should feel free to merge this
This commit is contained in:
Brad Warren 2025-06-13 10:31:49 -07:00 committed by GitHub
parent 779ebe9085
commit a7e4ffb13b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
certbot/src/certbot/_internal/renewal.py
View file

@ -298,13 +298,9 @@ def _restore_str(name: str, value: str) -> Optional[str]:
:rtype: str or None
"""
# Previous to v0.5.0, Certbot always stored the `server` URL in the renewal config,
# resulting in configs which explicitly use the deprecated ACMEv1 URL, today
# preventing an automatic transition to the default modern ACME URL.
# (https://github.com/certbot/certbot/issues/7978#issuecomment-625442870)
# As a mitigation, this function reinterprets the value of the `server` parameter if
# necessary, replacing the ACMEv1 URL with the default ACME URL. It is still possible
# to override this choice with the explicit `--server` CLI flag.
# To automatically migrate users from Let's Encrypt's old ACMEv1 URL, we replace the it here
# with the default ACME URL. It is still possible to override this choice with the explicit
# `--server` CLI flag.
if name == "server" and value == constants.V1_URI:
logger.info("Using server %s instead of legacy %s",
constants.CLI_DEFAULTS["server"], value)