From a7e4ffb13bb458e3a18e05b73371f634214f892c Mon Sep 17 00:00:00 2001 From: Brad Warren Date: Fri, 13 Jun 2025 10:31:49 -0700 Subject: [PATCH] update acmev1 url comment (#10343) this was the wrong/misleading comment i remember erica mentioning in our discussions yesterday. the problem here is modern versions of certbot also always save the server url. see https://github.com/certbot/certbot/blob/31599bad83eef82a3ff365b700c05760a84acdb2/certbot/src/certbot/_internal/storage.py#L288-L291 i personally don't think this requires two reviews and if whoever gets to this first agrees, i think you should feel free to merge this --- certbot/src/certbot/_internal/renewal.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/certbot/src/certbot/_internal/renewal.py b/certbot/src/certbot/_internal/renewal.py index 661c7a2fa..19976e881 100644 --- a/certbot/src/certbot/_internal/renewal.py +++ b/certbot/src/certbot/_internal/renewal.py @@ -298,13 +298,9 @@ def _restore_str(name: str, value: str) -> Optional[str]: :rtype: str or None """ - # Previous to v0.5.0, Certbot always stored the `server` URL in the renewal config, - # resulting in configs which explicitly use the deprecated ACMEv1 URL, today - # preventing an automatic transition to the default modern ACME URL. - # (https://github.com/certbot/certbot/issues/7978#issuecomment-625442870) - # As a mitigation, this function reinterprets the value of the `server` parameter if - # necessary, replacing the ACMEv1 URL with the default ACME URL. It is still possible - # to override this choice with the explicit `--server` CLI flag. + # To automatically migrate users from Let's Encrypt's old ACMEv1 URL, we replace the it here + # with the default ACME URL. It is still possible to override this choice with the explicit + # `--server` CLI flag. if name == "server" and value == constants.V1_URI: logger.info("Using server %s instead of legacy %s", constants.CLI_DEFAULTS["server"], value)