The message code was checking to see if an rdata type could appear in the

question section, and returning a formerr if it was invalid.  This isn't
exactly right, since it should be the caller's responsibility to check, not
message_parse.  It definitely caused weirdness when parsing responses, and
the only places where queries were parsed already does the right thing.
This commit is contained in:
Brian Wellington 2000-08-21 22:41:13 +00:00
parent 2c187cbe49
commit 67d3660cd6

View file

@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: message.c,v 1.140 2000/08/14 18:13:10 bwelling Exp $ */
/* $Id: message.c,v 1.141 2000/08/21 22:41:13 bwelling Exp $ */
/***
*** Imports
@ -986,15 +986,6 @@ getquestions(isc_buffer_t *source, dns_message_t *msg, dns_decompress_t *dctx)
goto cleanup;
}
/*
* If this is a type that cannot occur in a question section,
* return failure.
*/
if (dns_rdatatype_notquestion(rdtype)) {
result = DNS_R_FORMERR;
goto cleanup;
}
/*
* Can't ask the same question twice.
*/