From 67d3660cd612c130f0962d6b4e7fa2d5da7be4ed Mon Sep 17 00:00:00 2001 From: Brian Wellington Date: Mon, 21 Aug 2000 22:41:13 +0000 Subject: [PATCH] The message code was checking to see if an rdata type could appear in the question section, and returning a formerr if it was invalid. This isn't exactly right, since it should be the caller's responsibility to check, not message_parse. It definitely caused weirdness when parsing responses, and the only places where queries were parsed already does the right thing. --- lib/dns/message.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/dns/message.c b/lib/dns/message.c index 8908b16e90..e10bd1a02a 100644 --- a/lib/dns/message.c +++ b/lib/dns/message.c @@ -15,7 +15,7 @@ * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ -/* $Id: message.c,v 1.140 2000/08/14 18:13:10 bwelling Exp $ */ +/* $Id: message.c,v 1.141 2000/08/21 22:41:13 bwelling Exp $ */ /*** *** Imports @@ -986,15 +986,6 @@ getquestions(isc_buffer_t *source, dns_message_t *msg, dns_decompress_t *dctx) goto cleanup; } - /* - * If this is a type that cannot occur in a question section, - * return failure. - */ - if (dns_rdatatype_notquestion(rdtype)) { - result = DNS_R_FORMERR; - goto cleanup; - } - /* * Can't ask the same question twice. */