VAULT-41142 amend omissions from ACME observations (#11027) (#11030)

* VAULT-41142 amend omissions from ACME observations

* Feedback

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
This commit is contained in:
Vault Automation 2025-11-28 10:46:42 -05:00 committed by GitHub
parent 32c1695825
commit 91a9b23651
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -339,13 +339,15 @@ func (b *backend) acmeFinalizeOrderHandler(ac *acmeContext, r *logical.Request,
observe.NewAdditionalPKIMetadata("issuer_id", issuerId.String()),
observe.NewAdditionalPKIMetadata("order_id", order.OrderId),
observe.NewAdditionalPKIMetadata("stored", stored),
observe.NewAdditionalPKIMetadata("not_before", signedCertBundle.Certificate.NotBefore.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("not_after", signedCertBundle.Certificate.NotAfter.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("subject_key_id", signedCertBundle.Certificate.SubjectKeyId),
observe.NewAdditionalPKIMetadata("authority_key_id", signedCertBundle.Certificate.AuthorityKeyId),
observe.NewAdditionalPKIMetadata("public_key_algorithm", signedCertBundle.Certificate.PublicKeyAlgorithm.String()),
observe.NewAdditionalPKIMetadata("public_key_size", certutil.GetPublicKeySize(signedCertBundle.Certificate.PublicKey)),
observe.NewAdditionalPKIMetadata("common_name", signedCertBundle.Certificate.Subject.CommonName),
observe.NewAdditionalPKIMetadata("serial_number", parsing.SerialFromCert(signedCertBundle.Certificate)),
observe.NewAdditionalPKIMetadata("certificate_expiry", order.CertificateExpiry.String()),
observe.NewAdditionalPKIMetadata("order_expires", order.Expires.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("status", ACMEOrderValid),
observe.NewAdditionalPKIMetadata("account_id", order.AccountId),
)
@ -887,10 +889,10 @@ func (b *backend) acmeNewOrderHandler(ac *acmeContext, req *logical.Request, _ *
observe.NewAdditionalPKIMetadata("role_name", role),
observe.NewAdditionalPKIMetadata("issuer_name", issuerName),
observe.NewAdditionalPKIMetadata("issuer_id", issuerId),
observe.NewAdditionalPKIMetadata("not_before", notBefore.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("not_after", notAfter.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("order_not_before", notBefore.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("order_not_after", notAfter.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("order_id", order.OrderId),
observe.NewAdditionalPKIMetadata("expires", order.Expires.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("order_expires", order.Expires.Format(time.RFC3339)),
observe.NewAdditionalPKIMetadata("account_id", order.AccountId),
)