From 5c640601ebd79b9db4502f46313f2fbb17a03d66 Mon Sep 17 00:00:00 2001 From: vishalnayak Date: Wed, 6 Apr 2016 12:51:49 -0400 Subject: [PATCH] Added a TODO for 'Check' function --- logical/testing/testing.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/logical/testing/testing.go b/logical/testing/testing.go index f13c0a3941..821797291f 100644 --- a/logical/testing/testing.go +++ b/logical/testing/testing.go @@ -257,6 +257,10 @@ func Test(t TestT, c TestCase) { // Either the 'err' was nil or if an error was expected, it was set to nil. // Call the 'Check' function if there is one. + // + // TODO: This works perfectly for now, but it would be better if 'Check' + // function takes in both the response object and the error, and decide on + // the action on its own. if err == nil && s.Check != nil { // Call the test method err = s.Check(resp)