upstream/vault
1
0
Fork 0
mirror of https://github.com/hashicorp/vault.git synced 2026-05-28 04:10:44 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

remove other superfluous slices

Browse source
This commit is contained in:
Chelsea Shaw 2024-03-08 18:52:23 -06:00
parent f81de50687
commit 51df83f44e
6 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ui/app/helpers/mountable-auth-methods.js
View file

@ -117,7 +117,7 @@ const MOUNTABLE_AUTH_METHODS = [
];
export function methods() {
return MOUNTABLE_AUTH_METHODS.slice();
return MOUNTABLE_AUTH_METHODS;
}
export function allMethods() {

2
ui/app/helpers/mountable-secret-engines.js
View file

@ -135,7 +135,7 @@ const MOUNTABLE_SECRET_ENGINES = [
];
export function mountableEngines() {
return MOUNTABLE_SECRET_ENGINES.slice();
return MOUNTABLE_SECRET_ENGINES;
}
export function allEngines() {

4
ui/app/helpers/tabs-for-auth-section.js
View file

@ -83,7 +83,7 @@ const TABS_FOR_SHOW = {};
export function tabsForAuthSection([model, sectionType = 'authSettings', paths]) {
let tabs;
if (sectionType === 'authSettings') {
tabs = (TABS_FOR_SETTINGS[model.type] || []).slice();
tabs = TABS_FOR_SETTINGS[model.type] || [];
tabs.push({
label: 'Method Options',
routeParams: ['vault.cluster.settings.auth.configure.section', 'options'],
@ -104,7 +104,7 @@ export function tabsForAuthSection([model, sectionType = 'authSettings', paths])
};
});
} else {
tabs = (TABS_FOR_SHOW[model.type] || []).slice();
tabs = TABS_FOR_SHOW[model.type] || [];
}
tabs.push({
label: 'Configuration',

10
ui/app/models/kmip/role.js
View file

@ -15,7 +15,7 @@ export const COMPUTEDS = {
}),
operationFieldsWithoutSpecial: computed('operationFields', function () {
return this.operationFields.slice().removeObjects(['operationAll', 'operationNone']);
return this.operationFields.removeObjects(['operationAll', 'operationNone']);
}),
tlsFields: computed(function () {
@ -25,12 +25,12 @@ export const COMPUTEDS = {
// For rendering on the create/edit pages
defaultFields: computed('newFields', 'operationFields', 'tlsFields', function () {
const excludeFields = ['role'].concat(this.operationFields, this.tlsFields);
return this.newFields.slice().removeObjects(excludeFields);
return this.newFields.removeObjects(excludeFields);
}),
// For adapter/serializer
nonOperationFields: computed('newFields', 'operationFields', function () {
return this.newFields.slice().removeObjects(this.operationFields);
return this.newFields.removeObjects(this.operationFields);
}),
};
@ -64,9 +64,7 @@ export default Model.extend(COMPUTEDS, {
const attributes = ['operationAddAttribute', 'operationGetAttributes'];
const server = ['operationDiscoverVersions'];
const others = this.operationFieldsWithoutSpecial
.slice()
.removeObjects(objects.concat(attributes, server));
const others = this.operationFieldsWithoutSpecial.removeObjects(objects.concat(attributes, server));
const groups = [
{ 'Managed Cryptographic Objects': objects },
{ 'Object Attributes': attributes },

2
ui/app/services/console.js
View file

@ -46,7 +46,7 @@ export default Service.extend({
const log = this.log;
let history;
if (!clearAll) {
history = this.commandHistory.slice();
history = this.commandHistory;
history.setEach('hidden', true);
}
log.clear();

1
ui/app/services/store.js
View file

@ -187,6 +187,7 @@ export default class StoreService extends Store {
);
// Hack to make sure all records get in model correctly. remove with update to ember-data@4.12
this.peekAll(modelName).length;
// Removing .slice() causes list.empty in ListView to behave incorrectly
const model = this.peekAll(modelName).slice();
model.set('meta', response.meta);
resolve(model);