mirror of
https://github.com/hashicorp/vault.git
synced 2026-02-18 18:38:08 -05:00
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
This commit is contained in:
parent
44ced707f9
commit
43c52cce1c
1 changed files with 2 additions and 10 deletions
12
.github/pull_request_template.md
vendored
12
.github/pull_request_template.md
vendored
|
|
@ -2,18 +2,10 @@
|
|||
What does this PR do?
|
||||
|
||||
### TODO only if you're a HashiCorp employee
|
||||
- [ ] **Backport Labels:** If this fix needs to be backported, use the appropriate `backport/` label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like `backport/x.x.x`, but older release branches will be `backport/ent/x.x.x+ent`.
|
||||
- [ ] **Backport Labels:** If this fix needs to be backported, use the appropriate `backport/` label that matches the desired release branch.
|
||||
- [ ] **LTS**: If this fixes a critical security vulnerability or [severity 1](https://www.hashicorp.com/customer-success/enterprise-support) bug, it will also need to be backported to the current [LTS versions](https://developer.hashicorp.com/vault/docs/enterprise/lts#why-is-there-a-risk-to-updating-to-a-non-lts-vault-enterprise-version) of Vault. To ensure this, use **all** available enterprise labels.
|
||||
- [ ] **ENT Breakage:** If this PR either 1) removes a public function OR 2) changes the signature
|
||||
of a public function, even if that change is in a CE file, _double check_ that
|
||||
applying the patch for this PR to the ENT repo and running tests doesn't
|
||||
break any tests. Sometimes ENT only tests rely on public functions in CE
|
||||
files.
|
||||
- [ ] **Jira:** If this change has an associated Jira, it's referenced either
|
||||
in the PR description, commit message, or branch name.
|
||||
- [ ] **Jira:** If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
|
||||
- [ ] **RFC:** If this change has an associated RFC, please link it in the description.
|
||||
- [ ] **ENT PR:** If this change has an associated ENT PR, please link it in the
|
||||
description. Also, make sure the changelog is in this PR, _not_ in your ENT PR.
|
||||
|
||||
### PCI review checklist
|
||||
<!-- heimdall_github_prtemplate:grc-pci_dss-2024-01-05 -->
|
||||
|
|
|
|||
Loading…
Reference in a new issue