upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2025-12-20 23:00:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

- Cleanup some comments and TODO text.

Browse source
This commit is contained in:
George Thessalonikefs 2022-07-23 19:55:15 +02:00
parent f993ffbb07
commit efdd70c7b5
4 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
services/authzone.c
View file

@ -8189,7 +8189,6 @@ auth_zone_verify_zonemd_key_with_ds(struct auth_zone* z,
keystorage->rk.type = htons(LDNS_RR_TYPE_DNSKEY); keystorage->rk.type = htons(LDNS_RR_TYPE_DNSKEY);
keystorage->rk.rrset_class = htons(z->dclass); keystorage->rk.rrset_class = htons(z->dclass);
auth_zone_log(z->name, VERB_QUERY, "zonemd: verify zone DNSKEY with DS"); auth_zone_log(z->name, VERB_QUERY, "zonemd: verify zone DNSKEY with DS");
// @TODO add EDE here? we currently just pass NULL
sec = val_verify_DNSKEY_with_DS(env, ve, keystorage, ds, sigalg, sec = val_verify_DNSKEY_with_DS(env, ve, keystorage, ds, sigalg,
why_bogus, NULL, NULL); why_bogus, NULL, NULL);
regional_free_all(env->scratch); regional_free_all(env->scratch);

2
sldns/wire2str.c
View file

@ -1071,7 +1071,7 @@ static int sldns_wire2str_svcparam_mandatory2str(char** s,
assert(data_len > 0); assert(data_len > 0);
if (data_len % sizeof(uint16_t)) if (data_len % sizeof(uint16_t))
return -1; // wireformat error, data_len must be multiple of shorts return -1; /* wireformat error, data_len must be multiple of shorts */
w += sldns_str_print(s, slen, "="); w += sldns_str_print(s, slen, "=");
w += sldns_print_svcparamkey(s, slen, sldns_read_uint16(data)); w += sldns_print_svcparamkey(s, slen, sldns_read_uint16(data));
data += 2; data += 2;

1
validator/val_utils.c
View file

@ -489,7 +489,6 @@ int val_favorite_ds_algo(struct ub_packed_rrset_key* ds_rrset)
return digest_algo; return digest_algo;
} }
// @TODO change the use of this function to _ede function in authzone.c:8111
enum sec_status enum sec_status
val_verify_DNSKEY_with_DS(struct module_env* env, struct val_env* ve, val_verify_DNSKEY_with_DS(struct module_env* env, struct val_env* ve,
struct ub_packed_rrset_key* dnskey_rrset, struct ub_packed_rrset_key* dnskey_rrset,

3
validator/validator.c
View file

@ -2493,7 +2493,8 @@ ds_response_to_ke(struct module_qstate* qstate, struct val_qstate* vq,
/* If they aren't usable, then we treat it like /* If they aren't usable, then we treat it like
* there was no DS. */ * there was no DS. */
// @TODO add EDE Unsupported DS Digest Type /* TODO add EDE Unsupported DS Digest Type; this needs
* EDE to be added on non SERVFAIL answers. */
*ke = key_entry_create_null(qstate->region, *ke = key_entry_create_null(qstate->region,
qinfo->qname, qinfo->qname_len, qinfo->qclass, qinfo->qname, qinfo->qname_len, qinfo->qclass,