upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2026-01-07 15:29:36 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve Windows NSIS installer script (setup.nsi) (#831)

Browse source 
* Improve Windows NSIS installer script (setup.nsi)

Two improvements of installer script :
- avoid error message when Unbound is running,
- add "DisplayVersion" in registry thus Windows package manager (Winget) can handle Unbound.

* Update setup.nsi ask user to stop unbound service + DisplayVersion in Windows registry
This commit is contained in:
Pierre4012 2024-03-25 16:43:49 +01:00 committed by GitHub
parent 73bd5a19aa
commit ef60dcac31
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
winrc/setup.nsi
View file

@ -78,6 +78,15 @@ section "Root anchor - DNSSEC" SectionRootKey
sectionEnd
section "-hidden.postinstall"
# if Unbund is already installed, ask to stop it to allow file replacement
IfFileExists "$INSTDIR\unbound-service-remove.exe" 0 next_label
MessageBox MB_YESNO "Unbound is already installed! Would you like to stop the service to continue with the update?" /SD IDYES IDNO false_label # defaults to yes on silent installations
nsExec::ExecToLog '"$INSTDIR\unbound-service-remove.exe" stop'
Sleep 1000
Goto next_label
false_label:
Quit
next_label:
# copy files
SetRegView 64
setOutPath $INSTDIR
@ -134,6 +143,7 @@ section "-hidden.postinstall"
# register uninstaller
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "DisplayName" "Unbound"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "DisplayVersion" "${VERSION}"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "UninstallString" "$\"$INSTDIR\uninst.exe$\""
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "QuietUninstallString" "$\"$INSTDIR\uninst.exe$\" /S"
WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "NoModify" "1"