upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2025-12-20 23:00:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

- New and better fix for Fix #4193: Fix that prefetch failure does

Browse source 
not overwrite valid cache entry with SERVFAIL.


git-svn-id: file:///svn/unbound/trunk@4982 be551aaa-1e26-0410-a405-d3ace91eadb9
This commit is contained in:
Wouter Wijngaards 2018-11-27 10:56:45 +00:00
parent 0ff5c52657
commit d96de4c222
2 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
doc/Changelog
View file

@ -3,6 +3,8 @@
other threads from picking up the wrong data. The module restores other threads from picking up the wrong data. The module restores
the previous no_cache_store setting when the the module is finished. the previous no_cache_store setting when the the module is finished.
- Fix #4208: 'stub-no-cache' and 'forward-no-cache' not work. - Fix #4208: 'stub-no-cache' and 'forward-no-cache' not work.
- New and better fix for Fix #4193: Fix that prefetch failure does
not overwrite valid cache entry with SERVFAIL.
26 November 2018: Wouter 26 November 2018: Wouter
- Fix to not set GLOB_NOSORT so the unbound.conf include: files are - Fix to not set GLOB_NOSORT so the unbound.conf include: files are

25
iterator/iterator.c
View file

@ -292,7 +292,7 @@ error_response_cache(struct module_qstate* qstate, int id, int rcode)
if(!qstate->no_cache_store) { if(!qstate->no_cache_store) {
/* store in cache */ /* store in cache */
struct reply_info err; struct reply_info err;
if(qstate->prefetch_leeway > 0) { if(qstate->prefetch_leeway > NORR_TTL) {
verbose(VERB_ALGO, "error response for prefetch in cache"); verbose(VERB_ALGO, "error response for prefetch in cache");
/* attempt to adjust the cache entry prefetch */ /* attempt to adjust the cache entry prefetch */
if(dns_cache_prefetch_adjust(qstate->env, &qstate->qinfo, if(dns_cache_prefetch_adjust(qstate->env, &qstate->qinfo,
@ -327,6 +327,29 @@ error_response_cache(struct module_qstate* qstate, int id, int rcode)
/* serving expired contents, but nothing is cached /* serving expired contents, but nothing is cached
* at all, so the servfail cache entry is useful * at all, so the servfail cache entry is useful
* (stops waste of time on this servfail NORR_TTL) */ * (stops waste of time on this servfail NORR_TTL) */
} else {
/* don't overwrite existing (non-expired) data in
* cache with a servfail */
struct msgreply_entry* msg;
if((msg=msg_cache_lookup(qstate->env,
qstate->qinfo.qname, qstate->qinfo.qname_len,
qstate->qinfo.qtype, qstate->qinfo.qclass,
qstate->query_flags, *qstate->env->now, 0))
!= NULL) {
struct reply_info* rep = (struct reply_info*)
msg->entry.data;
if(FLAGS_GET_RCODE(rep->flags) ==
LDNS_RCODE_NOERROR ||
FLAGS_GET_RCODE(rep->flags) ==
LDNS_RCODE_NXDOMAIN) {
/* we have a good entry,
* don't overwrite */
lock_rw_unlock(&msg->entry.lock);
return error_response(qstate, id, rcode);
}
lock_rw_unlock(&msg->entry.lock);
}
} }
memset(&err, 0, sizeof(err)); memset(&err, 0, sizeof(err));
err.flags = (uint16_t)(BIT_QR | BIT_RA); err.flags = (uint16_t)(BIT_QR | BIT_RA);