From bde92695101861381bd4303a8b81151081072f3e Mon Sep 17 00:00:00 2001 From: Ralph Dolmans Date: Mon, 10 Apr 2017 10:18:22 +0000 Subject: [PATCH] Respip dereference after NULL check. git-svn-id: file:///svn/unbound/trunk@4101 be551aaa-1e26-0410-a405-d3ace91eadb9 --- doc/Changelog | 5 +++-- respip/respip.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/Changelog b/doc/Changelog index 40bf83ab9..cbcb2cb6f 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -1,6 +1,7 @@ 10 April 2017: Ralph - - Remove ECS option after REFUSED answer - - Fix small memory leak in edns_opt_copy_alloc + - Remove ECS option after REFUSED answer. + - Fix small memory leak in edns_opt_copy_alloc. + - Respip dereference after NULL check. 7 April 2017: George - Fix pythonmod for cb changes. diff --git a/respip/respip.c b/respip/respip.c index f1a609f13..d71325111 100644 --- a/respip/respip.c +++ b/respip/respip.c @@ -125,11 +125,11 @@ respip_find_or_create(struct respip_set* set, const char* ipstr, int create) node = (struct resp_addr*)addr_tree_find(&set->ip_tree, &addr, addrlen, net); if(!node && create) { node = regional_alloc_zero(set->region, sizeof(*node)); - node->action = respip_none; if(!node) { log_err("out of memory"); return NULL; } + node->action = respip_none; if(!addr_tree_insert(&set->ip_tree, &node->node, &addr, addrlen, net)) { /* We know we didn't find it, so this should be