test and nicer error handling on target query failure.

git-svn-id: file:///svn/unbound/trunk@1530 be551aaa-1e26-0410-a405-d3ace91eadb9

doc/Changelog

@@ -1,3 +1,7 @@
+17 March 2009: Wouter
+	- unit test for unsupported algorithm in anchor warning.
+	- fixed so queries do not fail on opportunistic target queries.
+
 16 March 2009: Wouter
 	- fixup diff error printout in contrib/update-itar.sh.
 	- added contrib/unbound_cacti for statistics support in cacti,

iterator/iterator.c

@@ -1288,14 +1288,14 @@ processQueryTargets(struct module_qstate* qstate, struct iter_qstate* iq,
 	/* if there is a policy to fetch missing targets 
 	 * opportunistically, do it. we rely on the fact that once a 
 	 * query (or queries) for a missing name have been issued, 
-	 * they will not be show up again. */
+	 * they will not show up again. */
 	} else if(tf_policy != 0) {
 		int extra = 0;
 		verbose(VERB_ALGO, "attempt to get extra %d targets", 
 			tf_policy);
-		if(!query_for_targets(qstate, iq, ie, id, tf_policy, &extra)) {
+		(void)query_for_targets(qstate, iq, ie, id, tf_policy, &extra);
-			return error_response(qstate, id, LDNS_RCODE_SERVFAIL);
+		/* errors ignored, these targets are not strictly necessary for
-		}
+		 * this result, we do not have to reply with SERVFAIL */
 		iq->num_target_queries += extra;
 	}