upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2025-12-20 23:00:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

- Fix double file close in tcp pipelined response code.

Browse source
This commit is contained in:
W.C.A. Wijngaards 2019-05-27 11:23:41 +02:00
parent 0b77c9d676
commit a03f0a388e
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
doc/Changelog
View file

@ -1,3 +1,6 @@
27 May 2019: Wouter
- Fix double file close in tcp pipelined response code.
24 May 2019: Wouter 24 May 2019: Wouter
- Fix that spoolbuf is not used to store tcp pipelined response - Fix that spoolbuf is not used to store tcp pipelined response
between mesh send and callback end. between mesh send and callback end.

8
services/listen_dnsport.c
View file

@ -1774,13 +1774,7 @@ tcp_req_info_handle_readdone(struct tcp_req_info* req)
* If mesh failed to add a new entry and called commpoint_drop_reply. * If mesh failed to add a new entry and called commpoint_drop_reply.
* Then the mesh state has been cleared. */ * Then the mesh state has been cleared. */
if(req->is_drop) { if(req->is_drop) {
/* we can now call drop_reply without recursing into ourselves /* the reply has been dropped, stream has been closed. */
* whilst in the callback */
/* we have to close the stream because there is no reply,
* no servfail to send, but the query needs an action, for
* a stream that is close the connection */
sldns_buffer_clear(c->buffer);
comm_point_drop_reply(&c->repinfo);
return; return;
} }
/* If mesh failed(mallocfail) and called commpoint_send_reply with /* If mesh failed(mallocfail) and called commpoint_send_reply with