upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2025-12-20 23:00:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

review comments.

Browse source 
git-svn-id: file:///svn/unbound/trunk@1350 be551aaa-1e26-0410-a405-d3ace91eadb9
This commit is contained in:
Wouter Wijngaards 2008-11-13 13:45:27 +00:00
parent d0eb5cad47
commit 9fa2964d95
3 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
daemon/cachedump.c
View file

@ -99,17 +99,15 @@ dump_rrset_line(SSL* ssl, struct ub_packed_rrset_key* k,
return ssl_printf(ssl, "BADRR\n"); return ssl_printf(ssl, "BADRR\n");
} }
s = ldns_rr2str(rr); s = ldns_rr2str(rr);
ldns_rr_free(rr);
if(!s) { if(!s) {
ldns_rr_free(rr);
return ssl_printf(ssl, "BADRR\n"); return ssl_printf(ssl, "BADRR\n");
} }
if(!ssl_printf(ssl, "%s", s)) { if(!ssl_printf(ssl, "%s", s)) {
free(s); free(s);
ldns_rr_free(rr);
return 0; return 0;
} }
free(s); free(s);
ldns_rr_free(rr);
return 1; return 1;
} }
@ -635,13 +633,12 @@ load_qinfo(char* str, struct query_info* qinfo, ldns_buffer* buf,
qinfo->qclass = ldns_rr_get_class(rr); qinfo->qclass = ldns_rr_get_class(rr);
ldns_buffer_clear(buf); ldns_buffer_clear(buf);
status = ldns_dname2buffer_wire(buf, ldns_rr_owner(rr)); status = ldns_dname2buffer_wire(buf, ldns_rr_owner(rr));
ldns_rr_free(rr);
if(status != LDNS_STATUS_OK) { if(status != LDNS_STATUS_OK) {
(void)ssl_printf(ssl, "error cannot dname2wire: %s\n", (void)ssl_printf(ssl, "error cannot dname2wire: %s\n",
ldns_get_errorstr_by_id(status)); ldns_get_errorstr_by_id(status));
ldns_rr_free(rr);
return NULL; return NULL;
} }
ldns_rr_free(rr);
ldns_buffer_flip(buf); ldns_buffer_flip(buf);
qinfo->qname_len = ldns_buffer_limit(buf); qinfo->qname_len = ldns_buffer_limit(buf);
qinfo->qname = (uint8_t*)regional_alloc_init(region, qinfo->qname = (uint8_t*)regional_alloc_init(region,

1
doc/Changelog
View file

@ -4,6 +4,7 @@
- neater comments in worker.h. - neater comments in worker.h.
- removed doc/plan and updated doc/TODO. - removed doc/plan and updated doc/TODO.
- silenced EHOSTDOWN (verbosity 2 or higher to see it). - silenced EHOSTDOWN (verbosity 2 or higher to see it).
- review comments from Jelte, Matthijs. Neater code.
12 November 2008: Wouter 12 November 2008: Wouter
- add unbound-control manpage to makedist replace list. - add unbound-control manpage to makedist replace list.

1
doc/TODO
View file

@ -40,6 +40,7 @@ o cleaner code; return and func statements on newline.
o memcached module that sits before validator module; checks for memcached o memcached module that sits before validator module; checks for memcached
data (on local lan), stores recursion lookup. Provides one cache for data (on local lan), stores recursion lookup. Provides one cache for
multiple resolver machines, coherent reply content in anycast setup. multiple resolver machines, coherent reply content in anycast setup.
o no openssl_add_all_algorithms, but only the ones necessary, less space.
*** Features features, for later *** Features features, for later
* dTLS, TLS, look to need special port numbers, cert storage, recent libssl. * dTLS, TLS, look to need special port numbers, cert storage, recent libssl.