upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2025-12-20 23:00:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

lint, aliasing.

Browse source 
git-svn-id: file:///svn/unbound/trunk@1643 be551aaa-1e26-0410-a405-d3ace91eadb9
This commit is contained in:
Wouter Wijngaards 2009-06-08 14:51:00 +00:00
parent 3c5c0b2727
commit 8c36960c29
4 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Makefile.in
View file

@ -69,7 +69,7 @@ WINDRES=windres
LINT=splint LINT=splint
LINTFLAGS=+quiet -weak -warnposix -unrecog -Din_addr_t=uint32_t -Du_int=unsigned -Du_char=uint8_t -preproc -Drlimit=rlimit64 -D__gnuc_va_list=va_list -Dglob64=glob -Dglobfree64=globfree LINTFLAGS=+quiet -weak -warnposix -unrecog -Din_addr_t=uint32_t -Du_int=unsigned -Du_char=uint8_t -preproc -Drlimit=rlimit64 -D__gnuc_va_list=va_list -Dglob64=glob -Dglobfree64=globfree
# compat with openssl linux edition. # compat with openssl linux edition.
LINTFLAGS+="-DBN_ULONG=unsigned long" -Dkrb5_int32=int "-Dkrb5_ui_4=unsigned int" -DPQ_64BIT=uint64_t -DRC4_INT=unsigned LINTFLAGS+="-DBN_ULONG=unsigned long" -Dkrb5_int32=int "-Dkrb5_ui_4=unsigned int" -DPQ_64BIT=uint64_t -DRC4_INT=unsigned -fixedformalarray
INSTALL=$(srcdir)/install-sh INSTALL=$(srcdir)/install-sh
ifeq "$(WITH_PYTHONMODULE)" "yes" ifeq "$(WITH_PYTHONMODULE)" "yes"

2
doc/Changelog
View file

@ -4,6 +4,8 @@
- 1.3.0 tarball for release created. - 1.3.0 tarball for release created.
- 1.3.1 development in svn trunk. - 1.3.1 development in svn trunk.
- iana portlist updated. - iana portlist updated.
- fix lint from complaining on ldns/sha.h.
- help compiler figure out aliasing in priv_rrset_bad() routine.
3 June 2009: Wouter 3 June 2009: Wouter
- fixup bad free() when wrongly encoded DSA signature is seen. - fixup bad free() when wrongly encoded DSA signature is seen.

2
doc/TODO
View file

@ -72,8 +72,6 @@ o infra and lame cache: easier size config (in Mb), show usage in graphs.
- fwd above stub, make hole in fwds - fwd above stub, make hole in fwds
- munin use ps to print total mem - munin use ps to print total mem
- no swig, but ask python, configure fails. - no swig, but ask python, configure fails.
- iter/priv 227 strict aliasing stop compiler complaints
- fix lint complains on ldns/sha1
- fix indent # ifs - fix indent # ifs
- flush_* remove msg cache entry if one. - flush_* remove msg cache entry if one.
- do not flush/delete callback queries or call error on callback at least. - do not flush/delete callback queries or call error on callback at least.

3
iterator/iter_priv.c
View file

@ -216,10 +216,10 @@ int priv_rrset_bad(struct iter_priv* priv, ldns_buffer* pkt,
return 0; return 0;
} else { } else {
/* so its a public name, check the address */ /* so its a public name, check the address */
struct sockaddr_storage addr;
socklen_t len; socklen_t len;
struct rr_parse* rr; struct rr_parse* rr;
if(rrset->type == LDNS_RR_TYPE_A) { if(rrset->type == LDNS_RR_TYPE_A) {
struct sockaddr_storage addr;
struct sockaddr_in* sa = (struct sockaddr_in*)&addr; struct sockaddr_in* sa = (struct sockaddr_in*)&addr;
len = (socklen_t)sizeof(*sa); len = (socklen_t)sizeof(*sa);
memset(sa, 0, len); memset(sa, 0, len);
@ -235,6 +235,7 @@ int priv_rrset_bad(struct iter_priv* priv, ldns_buffer* pkt,
return 1; return 1;
} }
} else if(rrset->type == LDNS_RR_TYPE_AAAA) { } else if(rrset->type == LDNS_RR_TYPE_AAAA) {
struct sockaddr_storage addr;
struct sockaddr_in6* sa = (struct sockaddr_in6*)&addr; struct sockaddr_in6* sa = (struct sockaddr_in6*)&addr;
len = (socklen_t)sizeof(*sa); len = (socklen_t)sizeof(*sa);
memset(sa, 0, len); memset(sa, 0, len);