From 8aa53f027d125a586796caeee2829ec8a18dd020 Mon Sep 17 00:00:00 2001 From: Wouter Wijngaards Date: Mon, 16 Jul 2018 10:21:34 +0000 Subject: [PATCH] - Fix qname minimisation NXDOMAIN validation lookup failures causing error_supers assertion fails. git-svn-id: file:///svn/unbound/trunk@4780 be551aaa-1e26-0410-a405-d3ace91eadb9 --- doc/Changelog | 4 ++++ iterator/iterator.c | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/doc/Changelog b/doc/Changelog index 3710505ce..55cc4c70f 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -1,3 +1,7 @@ +16 July 2018: Wouter + - Fix qname minimisation NXDOMAIN validation lookup failures causing + error_supers assertion fails. + 12 July 2018: Wouter - Fix to improve systemd socket activation code file descriptor assignment. diff --git a/iterator/iterator.c b/iterator/iterator.c index 58a9bff66..2604856b5 100644 --- a/iterator/iterator.c +++ b/iterator/iterator.c @@ -230,11 +230,12 @@ error_supers(struct module_qstate* qstate, int id, struct module_qstate* super) qstate->qinfo.qname, qstate->qinfo.qname_len); if(!dpns) { /* not interested */ + /* this can happen, for eg. qname minimisation asked + * for an NXDOMAIN to be validated, and used qtype + * A for that, and the error of that, the name, is + * not listed in super_iq->dp */ verbose(VERB_ALGO, "subq error, but not interested"); log_query_info(VERB_ALGO, "superq", &super->qinfo); - if(super_iq->dp) - delegpt_log(VERB_ALGO, super_iq->dp); - log_assert(0); return; } else { /* see if the failure did get (parent-lame) info */