From 6ac9904ee57b831e4a2ed170a9b55e69dfaa986d Mon Sep 17 00:00:00 2001
From: Wouter Wijngaards <wouter@nlnetlabs.nl>
Date: Wed, 8 Mar 2017 08:27:17 +0000
Subject: [PATCH] please doxygen.

git-svn-id: file:///svn/unbound/trunk@4039 be551aaa-1e26-0410-a405-d3ace91eadb9
---
 respip/respip.c      | 15 ++++++++-------
 respip/respip.h      | 12 ++++++------
 services/view.c      |  2 +-
 util/data/msgreply.h |  2 +-
 4 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/respip/respip.c b/respip/respip.c
index 026788c74..e992d0347 100644
--- a/respip/respip.c
+++ b/respip/respip.c
@@ -632,16 +632,16 @@ make_new_reply_info(const struct reply_info* rep, struct regional* region,
  * the "no data" action in case of error.
  * @param raddr: address span that requires an action
  * @param action: action to apply
- * @apram qtype: original query type
+ * @param qtype: original query type
  * @param rep: original reply message
  * @param rrset_id: the rrset ID in 'rep' to which the action should apply
  * @param new_repp: see respip_rewrite_reply
- * @tag: if >= 0 the tag ID used to determine the action and data
- * @tag_datas: data corresponding to 'tag'.
- * @tag_datas_size: size of 'tag_datas'
- * @tagname: array of tag names, used for logging
- * @num_tags: size of 'tagname', used for logging
- * @redirect_rrsetp: ptr to redirect record
+ * @param tag: if >= 0 the tag ID used to determine the action and data
+ * @param tag_datas: data corresponding to 'tag'.
+ * @param tag_datas_size: size of 'tag_datas'
+ * @param tagname: array of tag names, used for logging
+ * @param num_tags: size of 'tagname', used for logging
+ * @param redirect_rrsetp: ptr to redirect record
  * @param region: region for building new reply
  * @return 1 if overridden, 0 if not overridden, -1 on error.
  */
@@ -729,6 +729,7 @@ respip_data_answer(const struct resp_addr* raddr, enum respip_action action,
  * @param action: found action
  * @param rep:
  * @param new_repp
+ * @param rrset_id
  * @param region: region for building new reply
  * @return 1 on success, 0 on error.
  */
diff --git a/respip/respip.h b/respip/respip.h
index 94e0dfae7..01309caec 100644
--- a/respip/respip.h
+++ b/respip/respip.h
@@ -213,15 +213,15 @@ int respip_set_is_empty(const struct respip_set* set);
 /**
  * print log information for a query subject to an inform or inform-deny
  * response-ip action.
- * @param resp_addr response-ip information that causes the action
- * @param qname query name in the context, will be ignored if local_alias is
+ * @param respip_addr: response-ip information that causes the action
+ * @param qname: query name in the context, will be ignored if local_alias is
  *   non-NULL.
- * @param qtype query type, in host byte order.
- * @param qclass query class, in host byte order.
- * @param local_alias set to a local alias if the query matches an alias in
+ * @param qtype: query type, in host byte order.
+ * @param qclass: query class, in host byte order.
+ * @param local_alias: set to a local alias if the query matches an alias in
  *  a local zone.  In this case its owner name will be considered the actual
  *  query name.
- * @param repinfo reply info containing the client's source address and port.
+ * @param repinfo: reply info containing the client's source address and port.
  */
 void respip_inform_print(struct respip_addr_info* respip_addr, uint8_t* qname,
 	uint16_t qtype, uint16_t qclass, struct local_rrset* local_alias,
diff --git a/services/view.c b/services/view.c
index 5ea5ef02e..33f4f4986 100644
--- a/services/view.c
+++ b/services/view.c
@@ -68,7 +68,7 @@ views_create(void)
 
 /** This prototype is defined in in respip.h, but we want to avoid
   * unnecessary dependencies */
-void respip_set_delete(struct respip_set *);
+void respip_set_delete(struct respip_set *set);
 
 void 
 view_delete(struct view* v)
diff --git a/util/data/msgreply.h b/util/data/msgreply.h
index 037bbaa79..60aacc031 100644
--- a/util/data/msgreply.h
+++ b/util/data/msgreply.h
@@ -362,7 +362,7 @@ struct reply_info* reply_info_copy(struct reply_info* rep,
  *	array should have bee allocated with NULL pointers.
  * @param alloc: how to allocate rrset keys.
  *	Not used if region!=NULL, it can be NULL in that case.
- * @region: if this parameter is NULL then the alloc is used.
+ * @param region: if this parameter is NULL then the alloc is used.
  *	otherwise, rrset keys are allocated in this region.
  *	In a region, no special rrset key structures are needed (not shared).
  *	and no rrset_ref array in the reply needs to be built up.