upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2025-12-20 23:00:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

- Fix #358: Squelch udp connect 'no route to host' errors on low

Browse source 
verbosity.
This commit is contained in:
W.C.A. Wijngaards 2020-12-01 09:09:13 +01:00
parent 174bb48ae8
commit 5906811ff1
2 changed files with 36 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
doc/Changelog
View file

@ -1,3 +1,7 @@
1 December 2020: Wouter
- Fix #358: Squelch udp connect 'no route to host' errors on low
verbosity.
30 November 2020: Wouter 30 November 2020: Wouter
- Fix assertion failure on double callback when iterator loses - Fix assertion failure on double callback when iterator loses
interest in query at head of line that then has the tcp stream interest in query at head of line that then has the tcp stream

35
services/outside_network.c
View file

@ -1745,6 +1745,33 @@ select_id(struct outside_network* outnet, struct pending* pend,
return 1; return 1;
} }
/** return true is UDP connect error needs to be logged */
static int udp_connect_needs_log(int err)
{
switch(err) {
case ECONNREFUSED:
# ifdef ENETUNREACH
case ENETUNREACH:
# endif
# ifdef EHOSTDOWN
case EHOSTDOWN:
# endif
# ifdef EHOSTUNREACH
case EHOSTUNREACH:
# endif
# ifdef ENETDOWN
case ENETDOWN:
# endif
if(verbosity >= VERB_ALGO)
return 1;
return 0;
default:
break;
}
return 1;
}
/** Select random interface and port */ /** Select random interface and port */
static int static int
select_ifport(struct outside_network* outnet, struct pending* pend, select_ifport(struct outside_network* outnet, struct pending* pend,
@ -1804,9 +1831,11 @@ select_ifport(struct outside_network* outnet, struct pending* pend,
/* connect() to the destination */ /* connect() to the destination */
if(connect(fd, (struct sockaddr*)&pend->addr, if(connect(fd, (struct sockaddr*)&pend->addr,
pend->addrlen) < 0) { pend->addrlen) < 0) {
log_err_addr("udp connect failed", if(udp_connect_needs_log(errno)) {
strerror(errno), &pend->addr, log_err_addr("udp connect failed",
pend->addrlen); strerror(errno), &pend->addr,
pend->addrlen);
}
sock_close(fd); sock_close(fd);
return 0; return 0;
} }