From 9ebc600e63f572446e176bf1064a4f3ca717c12b Mon Sep 17 00:00:00 2001 From: Russell McConnachie Date: Mon, 14 Dec 2020 15:50:33 -0800 Subject: [PATCH 1/2] Use NOTIMP rcode in addition to NOERROR as a valid rcode response so we forward it back to the client. --- iterator/iter_resptype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iterator/iter_resptype.c b/iterator/iter_resptype.c index f146a2b6b..b1f0a4c68 100644 --- a/iterator/iter_resptype.c +++ b/iterator/iter_resptype.c @@ -134,7 +134,7 @@ response_type_from_server(int rdset, /* Other response codes mean (so far) to throw the response away as * meaningless and move on to the next nameserver. */ - if(FLAGS_GET_RCODE(msg->rep->flags) != LDNS_RCODE_NOERROR) + if(FLAGS_GET_RCODE(msg->rep->flags) != LDNS_RCODE_NOERROR && FLAGS_GET_RCODE(msg->rep->flags) != LDNS_RCODE_NOTIMP) return RESPONSE_TYPE_THROWAWAY; /* Note: TC bit has already been handled */ From 2805bfd250e805ba23d53aa0d9b8649ce5df8a5b Mon Sep 17 00:00:00 2001 From: Russell McConnachie Date: Mon, 14 Dec 2020 15:57:38 -0800 Subject: [PATCH 2/2] LDNS_RCODE_NOTIMPL != LDNS_RCODE_NOTIMP --- iterator/iter_resptype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iterator/iter_resptype.c b/iterator/iter_resptype.c index b1f0a4c68..75fd184b0 100644 --- a/iterator/iter_resptype.c +++ b/iterator/iter_resptype.c @@ -134,7 +134,7 @@ response_type_from_server(int rdset, /* Other response codes mean (so far) to throw the response away as * meaningless and move on to the next nameserver. */ - if(FLAGS_GET_RCODE(msg->rep->flags) != LDNS_RCODE_NOERROR && FLAGS_GET_RCODE(msg->rep->flags) != LDNS_RCODE_NOTIMP) + if(FLAGS_GET_RCODE(msg->rep->flags) != LDNS_RCODE_NOERROR && FLAGS_GET_RCODE(msg->rep->flags) != LDNS_RCODE_NOTIMPL) return RESPONSE_TYPE_THROWAWAY; /* Note: TC bit has already been handled */