From 4f5b934688f293c92e800cce3b29e0499dd6c278 Mon Sep 17 00:00:00 2001 From: Ralph Dolmans Date: Thu, 30 Jan 2020 14:56:48 +0100 Subject: [PATCH] - Fix small memory leak in error condition remote.c - Fix double free in error condition view.c --- daemon/remote.c | 1 + doc/Changelog | 6 +++++- services/view.c | 2 -- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index f69e0ef07..5affaefe9 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -2527,6 +2527,7 @@ do_auth_zone_transfer(RES* ssl, struct worker* worker, char* arg) if(!az || !auth_zones_startprobesequence(az, &worker->env, nm, nmlen, LDNS_RR_CLASS_IN)) { (void)ssl_printf(ssl, "error zone xfr task not found %s\n", arg); + free(nm); return; } send_ok(ssl); diff --git a/doc/Changelog b/doc/Changelog index fd3d9aa05..d935daf09 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -1,6 +1,10 @@ +30 January 2020: Ralph + - Fix memory leak in error condition remote.c + - Fix double free in error condition view.c + 29 January 2020: Ralph - Merge PR#156 from Alexander Berkes; Added unbound-control - view_local_datas_remove command. + view_local_datas_remove command. 29 January 2020: Wouter - Fix #157: undefined reference to `htobe64'. diff --git a/services/view.c b/services/view.c index c6709e58f..db48ae954 100644 --- a/services/view.c +++ b/services/view.c @@ -198,8 +198,6 @@ views_apply_cfg(struct views* vs, struct config_file* cfg) log_err("failed to insert " "default zones into " "local-zone list"); - free(nd_str); - free(nd_type); lock_rw_unlock(&v->lock); return 0; }