upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2025-12-24 00:29:58 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix: log_assert does nothing if UNBOUND_DEBUG is undefined

Browse source 
Found by static analyzer svace
Static analyzer message: Integer value 'len' obtained from untrusted
source at tube.c:374 by passing as 2nd parameter to function 'read'
at tube.c:340 without checking its higher bound is used as a loop bound
at tube.c:374.


on-behalf-of: @ideco-team <github@ideco.ru>
This commit is contained in:
Shchelkunov Artem 2021-08-20 17:12:43 +05:00
parent 51f5b3ab44
commit 4ea9651624
No known key found for this signature in database
GPG key ID: E40FE4DB66ACF9FF
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
util/tube.c
View file

@ -363,7 +363,11 @@ int tube_read_msg(struct tube* tube, uint8_t** buf, uint32_t* len,
}
d += r;
}
log_assert(*len < 65536*2);
if (*len >= 65536*2) {
log_err("tube msg length is too big", *len);
(void)fd_set_nonblock(fd);
return 0;
}
*buf = (uint8_t*)malloc(*len);
if(!*buf) {
log_err("tube read out of memory");