upstream/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2025-12-20 23:00:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

- Fix Out of Bounds Write in sldns_str2wire_str_buf(),

Browse source 
reported by X41 D-Sec.
This commit is contained in:
W.C.A. Wijngaards 2019-12-03 16:01:31 +01:00
parent e183a66d60
commit 3f3cadd416
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
doc/Changelog
View file

@ -10,6 +10,8 @@
reported by X41 D-Sec. reported by X41 D-Sec.
- Fix OOB Read in sldns_wire2str_dname_scan(), - Fix OOB Read in sldns_wire2str_dname_scan(),
reported by X41 D-Sec. reported by X41 D-Sec.
- Fix Out of Bounds Write in sldns_str2wire_str_buf(),
reported by X41 D-Sec.
2 December 2019: Wouter 2 December 2019: Wouter
- Merge pull request #122 from he32: In tcp_callback_writer(), - Merge pull request #122 from he32: In tcp_callback_writer(),

2
sldns/str2wire.c
View file

@ -1103,7 +1103,7 @@ int sldns_str2wire_str_buf(const char* str, uint8_t* rd, size_t* len)
while(sldns_parse_char(&ch, &s)) { while(sldns_parse_char(&ch, &s)) {
if(sl >= 255) if(sl >= 255)
return RET_ERR(LDNS_WIREPARSE_ERR_INVALID_STR, s-str); return RET_ERR(LDNS_WIREPARSE_ERR_INVALID_STR, s-str);
if(*len < sl+1) if(*len < sl+2)
return RET_ERR(LDNS_WIREPARSE_ERR_BUFFER_TOO_SMALL, return RET_ERR(LDNS_WIREPARSE_ERR_BUFFER_TOO_SMALL,
s-str); s-str);
rd[++sl] = ch; rd[++sl] = ch;