- Fix for more maintainable code in localzone.

git-svn-id: file:///svn/unbound/trunk@4542 be551aaa-1e26-0410-a405-d3ace91eadb9
This commit is contained in:
Wouter Wijngaards 2018-02-19 13:21:57 +00:00
parent ec21a197ac
commit 3d57bf0a3b
2 changed files with 5 additions and 54 deletions

View file

@ -3,6 +3,7 @@
wrong RFC. wrong RFC.
- Fix #3494: local-zone noview can be used to break out of the view - Fix #3494: local-zone noview can be used to break out of the view
to the global local zone contents, for queries for that zone. to the global local zone contents, for queries for that zone.
- Fix for more maintainable code in localzone.
16 February 2018: Wouter 16 February 2018: Wouter
- Fixes for clang static analyzer, the missing ; in - Fixes for clang static analyzer, the missing ; in

View file

@ -1132,61 +1132,11 @@ void local_zones_print(struct local_zones* zones)
lock_rw_rdlock(&zones->lock); lock_rw_rdlock(&zones->lock);
log_info("number of auth zones %u", (unsigned)zones->ztree.count); log_info("number of auth zones %u", (unsigned)zones->ztree.count);
RBTREE_FOR(z, struct local_zone*, &zones->ztree) { RBTREE_FOR(z, struct local_zone*, &zones->ztree) {
char buf[64];
lock_rw_rdlock(&z->lock); lock_rw_rdlock(&z->lock);
switch(z->type) { snprintf(buf, sizeof(buf), "%s zone",
case local_zone_deny: local_zone_type2str(z->type));
log_nametypeclass(0, "deny zone", log_nametypeclass(0, buf, z->name, 0, z->dclass);
z->name, 0, z->dclass);
break;
case local_zone_refuse:
log_nametypeclass(0, "refuse zone",
z->name, 0, z->dclass);
break;
case local_zone_redirect:
log_nametypeclass(0, "redirect zone",
z->name, 0, z->dclass);
break;
case local_zone_transparent:
log_nametypeclass(0, "transparent zone",
z->name, 0, z->dclass);
break;
case local_zone_typetransparent:
log_nametypeclass(0, "typetransparent zone",
z->name, 0, z->dclass);
break;
case local_zone_static:
log_nametypeclass(0, "static zone",
z->name, 0, z->dclass);
break;
case local_zone_inform:
log_nametypeclass(0, "inform zone",
z->name, 0, z->dclass);
break;
case local_zone_inform_deny:
log_nametypeclass(0, "inform_deny zone",
z->name, 0, z->dclass);
break;
case local_zone_always_transparent:
log_nametypeclass(0, "always_transparent zone",
z->name, 0, z->dclass);
break;
case local_zone_always_refuse:
log_nametypeclass(0, "always_refuse zone",
z->name, 0, z->dclass);
break;
case local_zone_always_nxdomain:
log_nametypeclass(0, "always_nxdomain zone",
z->name, 0, z->dclass);
break;
case local_zone_noview:
log_nametypeclass(0, "noview zone",
z->name, 0, z->dclass);
break;
default:
log_nametypeclass(0, "badtyped zone",
z->name, 0, z->dclass);
break;
}
local_zone_out(z); local_zone_out(z);
lock_rw_unlock(&z->lock); lock_rw_unlock(&z->lock);
} }