mirror of
https://github.com/hashicorp/terraform.git
synced 2026-02-20 00:13:30 -05:00
* Add ability to parse backend blocks present in a test file's run blocks, validate configuration (#36541)
* Add ability to parse backend blocks from a run block
* Add validation to avoid multiple backend blocks across run blocks that use the same internal state file. Update tests.
* Add validation to avoid multiple backend blocks within a single run block. Update tests.
* Remove use of quotes in diagnostic messages
* Add validation to avoid backend blocks being used in plan run blocks. Update tests.
* Correct local backend blocks in new test fixtures
* Add test to show that different test files can use same backend block for same state key.
* Add validation to enforce state-storage backend types are used
* Remove TODO comment
We only need to consider one file at a time when checking if a state_key already has a backend associated with it; parallelism in `terraform test` is scoped down to individual files.
* Add validation to assert that the backend block must be in the first apply command for an internal state
* Consolidate backend block validation inside a single if statement
* Add initial version of validation that ensures a backend isn't re-used within a file
* Explicitly set the state_key at the point of parsing the config
TODO: What should be done with method (moduletest.Run).GetStateKey?
* Update test fixture now that reusing backend configs has been made invalid
* Add automated test showing validation of reused configuration blocks
* Skip test due to flakiness, minor change to test config naming
* Update test so it tolerates non-deterministic order run blocks are evaluated in
* Remove unnecessary value assignment to r.StateKey
* Replace use of GetStateKey() with accessing the state key that's now set during test config parsing
* Fix bug so that run blocks using child modules get the correct state key set at parsing time
* Update acceptance test to also cover scenario where root and child module state keys are in use
* Update test name
* Add newline to regex
* Ensure consistent place where repeat backend error is raised from
* Write leftover test state(s) to file (#36614)
* Add additional validation that the backend used in a run is a supported type (#36648)
* Prevent test run when leftover state data is present (#36685)
* `test`: Set the initial state for a state files from a backend, allow the run that defines a backend to write state to the backend (#36646)
* Allow use of backend block to set initial state for a state key
* Note about alternative place to keep 'backend factories'
* Allow the run block defining the backend to write state to it
* Fix rebase
* Change to accessing backend init functions via ContextOpts
* Add tests demonstrating how runs containing backend blocks use and update persisted state
* Fix test fixture
* Address test failure due to trouble opening the state file
This problem doesn't happen on MacOS, so I assume is due to the Linux environment of GitHub runners.
* Fix issue with paths properly
I hope
* Fix defect in test assertion
* Pivot back to approach introduced in 4afc3d7
* Let failing tests write to persistent state, add test case covering that.
I split the acceptance tests into happy/unhappy paths for this, which required some of the helper functions' declarations to be raised up to package-level.
* Change how we update internal state files, so that information about the associated backend is never lost
* Fix UpdateStateFile
* Ensure that the states map set by TestStateTransformer associates a backend with the correct run.
* Misc spelling fixes in comments and a log
* Replace state get/set functions with existing helpers (#36747)
* Replace state get/set functions with existing helpers
* Compare to string representation of state
* Compare to string representation of state
* Terraform Test: Allow skipping cleanup of entire test file or individual run blocks (#36729)
* Add validation to enforce skip_cleanup=false cannot be used with backend blocks (#36857)
* Integrate use of backend blocks in tests with skip_cleanup feature (#36848)
* Fix nil pointer error, update test to not be table-driven
* Make using a backend block implicitly set skip_cleanup to true
* Stop state artefacts being created when a backend is in use and no cleanup errors have occurred
* Return diagnostics so calling code knows if cleanup experienced issues or not
* Update tests to show that when cleanup fails a state artefact is created
* Add comment about why diag not returned
* Bug fix - actually pull in the state from the state manager!
* Split and simplify (?) tests to show the backend block can create and/or reuse prior state
* Update test to use new fixtures, assert about state artefact. Fix nil pointer
* Update test fixture in use, add guardrail for flakiness of forced error during cleanup
* Refactor so resource ID set in only one place
* Add documentation for using a `backend` block during `test` (#36832)
* Add backend as a documented block in a run block
* Add documentation about backend blocks in run blocks.
* Make the relationship between backends and state keys more clear, other improvements
* More test documentation (#36838)
* Terraform Test: cleanup command (#36847)
* Allow cleanup of states that depend on prior runs outputs (#36902)
* terraform test: refactor graph edge calculation
* create fake run block nodes during cleanup operation
* tidy up TODOs
* fix tests
* remove old changes
* Update internal/moduletest/graph/node_state_cleanup.go
Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com>
* Improve diagnostics around skip_cleanup conflicts (#37385)
* Improve diagnostics around skip_cleanup conflicts
* remove unused dynamic node
* terraform test: refactor manifest file for simplicity (#37412)
* test: refactor apply and plan functions so no run block is needed
* terraform test: write and load state manifest files
* Terraform Test: Allow skipping cleanup of entire test file or individual run blocks (#36729)
* terraform test: add support for skip_cleanup attr
* terraform test: add cleanup command
* terraform test: add backend blocks
* pause
* fix tests
* remove commented code
* terraform test: make controlling destroy functionality experimental (#37419)
* address comments
* Update internal/moduletest/graph/node_state_cleanup.go
Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com>
---------
Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com>
* add experimental changelog entries
---------
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com>
Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>
125 lines
3.1 KiB
Go
125 lines
3.1 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package graph
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/hashicorp/terraform/internal/addrs"
|
|
"github.com/hashicorp/terraform/internal/configs"
|
|
"github.com/hashicorp/terraform/internal/dag"
|
|
"github.com/hashicorp/terraform/internal/moduletest"
|
|
"github.com/hashicorp/terraform/internal/providers"
|
|
"github.com/hashicorp/terraform/internal/terraform"
|
|
)
|
|
|
|
// TestProvidersTransformer is a GraphTransformer that gathers all the providers
|
|
// from the module configurations that the test runs depend on and attaches the
|
|
// required providers to the test run nodes.
|
|
type TestProvidersTransformer struct {
|
|
Config *configs.Config
|
|
File *moduletest.File
|
|
Providers map[addrs.Provider]providers.Factory
|
|
}
|
|
|
|
func (t *TestProvidersTransformer) Transform(g *terraform.Graph) error {
|
|
|
|
type tuple struct {
|
|
configure *NodeProviderConfigure
|
|
close *NodeProviderClose
|
|
}
|
|
|
|
nodes := make(map[string]map[string]tuple)
|
|
|
|
for _, config := range t.File.Config.Providers {
|
|
provider := t.Config.ProviderForConfigAddr(config.Addr())
|
|
|
|
factory, ok := t.Providers[provider]
|
|
if !ok {
|
|
return fmt.Errorf("unknown provider %s", provider)
|
|
}
|
|
|
|
impl, err := factory()
|
|
if err != nil {
|
|
return fmt.Errorf("could not create provider instance: %w", err)
|
|
}
|
|
|
|
if config.Mock {
|
|
impl = &providers.Mock{
|
|
Provider: impl,
|
|
Data: config.MockData,
|
|
}
|
|
}
|
|
|
|
addr := addrs.RootProviderConfig{
|
|
Provider: provider,
|
|
Alias: config.Alias,
|
|
}
|
|
|
|
configure := &NodeProviderConfigure{
|
|
name: config.Name,
|
|
alias: config.Alias,
|
|
Addr: addr,
|
|
File: t.File,
|
|
Config: config,
|
|
Provider: impl,
|
|
Schema: impl.GetProviderSchema(),
|
|
}
|
|
g.Add(configure)
|
|
|
|
close := &NodeProviderClose{
|
|
name: config.Name,
|
|
alias: config.Alias,
|
|
Addr: addr,
|
|
File: t.File,
|
|
Config: config,
|
|
Provider: impl,
|
|
}
|
|
g.Add(close)
|
|
|
|
if _, exists := nodes[config.Name]; !exists {
|
|
nodes[config.Name] = make(map[string]tuple)
|
|
}
|
|
nodes[config.Name][config.Alias] = tuple{
|
|
configure: configure,
|
|
close: close,
|
|
}
|
|
|
|
// make sure the provider is only closed after the provider starts.
|
|
g.Connect(dag.BasicEdge(close, configure))
|
|
}
|
|
|
|
for vertex := range g.VerticesSeq() {
|
|
if vertex, ok := vertex.(*NodeTestRun); ok {
|
|
// providers aren't referenceable so the automatic reference
|
|
// transformer won't do this.
|
|
|
|
if len(vertex.Run().Config.Providers) > 0 {
|
|
for _, ref := range vertex.run.Config.Providers {
|
|
if node, ok := nodes[ref.InParent.Name][ref.InParent.Alias]; ok {
|
|
g.Connect(dag.BasicEdge(vertex, node.configure))
|
|
}
|
|
}
|
|
} else {
|
|
for provider := range requiredProviders(vertex.run.ModuleConfig) {
|
|
name := t.Config.Module.LocalNameForProvider(provider.Provider)
|
|
if node, ok := nodes[name][provider.Alias]; ok {
|
|
g.Connect(dag.BasicEdge(vertex, node.configure))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if vertex, ok := vertex.(*TeardownSubgraph); ok {
|
|
for _, node := range nodes {
|
|
for _, node := range node {
|
|
// close all the providers after the states have been
|
|
// cleaned up.
|
|
g.Connect(dag.BasicEdge(node.close, vertex))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|