upstream/terraform
1
0
Fork 0
mirror of https://github.com/hashicorp/terraform.git synced 2026-06-09 08:58:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

trace: add more logging around variable validations (#35535)

Browse source
This commit is contained in:
Liam Cervante 2024-08-06 10:55:14 +02:00 committed by GitHub
parent 4f62fcac53
commit ef168cb25c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/checks/state_report.go
View file

@ -5,6 +5,7 @@ package checks
import (
"fmt"
"log"
"github.com/hashicorp/terraform/internal/addrs"
)
@ -50,6 +51,7 @@ func (c *State) ReportCheckableObjects(configAddr addrs.ConfigCheckable, objectA
checks[checkType] = make([]Status, count)
}
log.Printf("[TRACE] ReportCheckableObjects: %s -> %s", configAddr, objectAddr)
st.objects.Put(objectAddr, checks)
}
}

8
internal/terraform/graph.go
View file

@ -51,6 +51,14 @@ func (g *Graph) walk(walker GraphWalker) tfdiags.Diagnostics {
log.Printf("[TRACE] vertex %q: starting visit (%T)", dag.VertexName(v), v)
defer func() {
if r := recover(); r != nil {
// If the walkFn panics, we get confusing logs about how the
// visit was complete. To stop this, we'll catch the panic log
// that the vertex panicked without finishing and re-panic.
log.Printf("[ERROR] vertex %q panicked", dag.VertexName(v))
panic(r) // re-panic
}
if diags.HasErrors() {
for _, diag := range diags {
if diag.Severity() == tfdiags.Error {

1
internal/terraform/node_module_variable.go
View file

@ -68,6 +68,7 @@ func (n *nodeExpandModuleVariable) DynamicExpand(ctx EvalContext) (*Graph, tfdia
forEachModuleInstance(expander, n.Module, false, func(module addrs.ModuleInstance) {
addr := n.Addr.Absolute(module)
if checkableAddrs != nil {
log.Printf("[TRACE] nodeExpandModuleVariable: found checkable object %s", addr)
checkableAddrs.Add(addr)
}