upstream/terraform
1
0
Fork 0
mirror of https://github.com/hashicorp/terraform.git synced 2026-06-09 00:42:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

test: emit a nice error message if the user uses ephemeral resource in terrafom test

Browse source
This commit is contained in:
Daniel Schmidt 2024-10-16 16:24:55 +02:00
parent 97ba67edea
commit ae103fc491
No known key found for this signature in database
GPG key ID: 377C3A4D62FBBBE2
2 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/command/test_test.go
View file

@ -273,7 +273,7 @@ func TestTest_Runs(t *testing.T) {
"ephemeral_resource": {
expectedOut: []string{"0 passed, 1 failed."},
// TODO: Improve error message, say something about ephemeral resources not being accessible in tests due to their ephemeral nature
expectedErr: []string{"Ephemeral resource instance has expired"},
expectedErr: []string{"Ephemeral resource instance has expired", "Ephemeral resources not supported in the context of tests"},
code: 1,
},
}

23
internal/moduletest/eval_context.go
View file

@ -92,6 +92,12 @@ func (ec *EvalContext) Evaluate() (Status, cty.Value, tfdiags.Diagnostics) {
ruleDiags = ruleDiags.Append(moreDiags)
refs = append(refs, moreRefs...)
// We want to emit diagnostics if users are using ephemeral resources in their checks
// as they are not supported since they are closed before this is evaluated.
// We do not remove the diagnostic about the ephemeral resource being closed already as it
// might be useful to the user.
ruleDiags = ruleDiags.Append(diagsForEphemeralResources(refs))
hclCtx, moreDiags := scope.EvalContext(refs)
ruleDiags = ruleDiags.Append(moreDiags)
if moreDiags.HasErrors() {
@ -198,6 +204,23 @@ func (ec *EvalContext) Evaluate() (Status, cty.Value, tfdiags.Diagnostics) {
return status, cty.ObjectVal(outputVals), diags
}
func diagsForEphemeralResources(refs []*addrs.Reference) (diags tfdiags.Diagnostics) {
for _, ref := range refs {
switch v := ref.Subject.(type) {
case addrs.ResourceInstance:
if v.Resource.Mode == addrs.EphemeralResourceMode {
diags = diags.Append(&hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "Ephemeral resources not supported in the context of tests",
Detail: "Ephemeral resources are not supported in the context of terraform test.",
Subject: ref.SourceRange.ToHCL().Ptr(),
})
}
}
}
return diags
}
// evaluationData augments an underlying lang.Data -- presumably resulting
// from a terraform.Context.PlanAndEval or terraform.Context.ApplyAndEval call --
// with results from prior runs that should therefore be available when