upstream/terraform
1
0
Fork 0
mirror of https://github.com/hashicorp/terraform.git synced 2026-06-09 08:58:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Reserve state and plan keywords in test files (#33846)

Browse source
This commit is contained in:
Liam Cervante 2023-09-09 07:48:57 +02:00 committed by GitHub
parent 80f10a47ee
commit 8912396504
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
internal/addrs/parse_ref.go
View file

@ -90,6 +90,7 @@ func ParseRef(traversal hcl.Traversal) (*Reference, tfdiags.Diagnostics) {
// scope and so should use this function to retrieve references.
func ParseRefFromTestingScope(traversal hcl.Traversal) (*Reference, tfdiags.Diagnostics) {
root := traversal.RootName()
rootRange := traversal[0].SourceRange()
var diags tfdiags.Diagnostics
var reference *Reference
@ -119,6 +120,17 @@ func ParseRefFromTestingScope(traversal hcl.Traversal) (*Reference, tfdiags.Diag
Remaining: remain,
}
diags = runDiags
case "plan", "state":
// These names are all pre-emptively reserved in the hope of landing
// some version of referencing the plan and state files in test
// assertions.
diags = diags.Append(&hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "Reserved symbol name",
Detail: fmt.Sprintf("The symbol name %q is reserved for use in a future Terraform version. If you are using a provider that already uses this as a resource type name, add the prefix \"resource.\" to force interpretation as a resource type name.", root),
Subject: rootRange.Ptr(),
})
return nil, diags
}
if reference != nil {